Why all my randoms are the same? [Answered]

Whiteboy · 2022-09-02T15:35:44.739Z

so there is the code and the outputs why are they the same and how to change it?

W

WhiteboyOP•9/2/22, 3:36 PM

private static double GetRandomNumber(double minimum, double maximum)
        {
            Random random = new();
            return random.NextDouble() * (maximum - minimum) + minimum;
        }

private static double GetRandomNumber(double minimum, double maximum)
        {
            Random random = new();
            return random.NextDouble() * (maximum - minimum) + minimum;
        }

private static double GetRandomNumber(double minimum, double maximum)
        {
            Random random = new();
            return random.NextDouble() * (maximum - minimum) + minimum;
        }

private static double GetRandomNumber(double minimum, double maximum)
        {
            Random random = new();
            return random.NextDouble() * (maximum - minimum) + minimum;
        }

W

WhiteboyOP•9/2/22, 3:36 PM

        public static void CreateInstance()
        {
            string strSeperator = ";";
            StringBuilder sbOutput = new();
            _ = new Random();

            double x = SharedClass.RarityLvlValue.Rarity * 0.4;

            for (var i = 1; i <= 5; i++)
            {
                RarityBonus["button" + i] = new RarityStats(
                    armorPen:       Math.Round(GetRandomNumber(12, 22), 1) * x,
                    hitRate:        Math.Round(GetRandomNumber(100, 250), 1) * x,
                    basicDmg:       Math.Round(GetRandomNumber(300, 900), 1) * x,
                    critChance:     Math.Round(GetRandomNumber(4, 11), 1) * x,
                    stunChance:     Math.Round(GetRandomNumber(1, 4), 1) * x,
                    elementalDmg:   Math.Round(GetRandomNumber(150, 900), 1) * x,
                    dmg:            Math.Round(GetRandomNumber(8, 18), 1) * x,
                    highMonster:    Math.Round(GetRandomNumber(17, 29), 1) * x,
                    lowMonster:     Math.Round(GetRandomNumber(14, 32), 1) * x);
            } 
            sbOutput.AppendLine(string.Join(strSeperator, RarityBonus));
            File.AppendAllText(@"C:\Users\Admin\Desktop\WiT\Semestr 4\Solutions\SimulatorApk\dictRarity.txt", sbOutput.ToString());
        }

        public static void CreateInstance()
        {
            string strSeperator = ";";
            StringBuilder sbOutput = new();
            _ = new Random();

            double x = SharedClass.RarityLvlValue.Rarity * 0.4;

            for (var i = 1; i <= 5; i++)
            {
                RarityBonus["button" + i] = new RarityStats(
                    armorPen:       Math.Round(GetRandomNumber(12, 22), 1) * x,
                    hitRate:        Math.Round(GetRandomNumber(100, 250), 1) * x,
                    basicDmg:       Math.Round(GetRandomNumber(300, 900), 1) * x,
                    critChance:     Math.Round(GetRandomNumber(4, 11), 1) * x,
                    stunChance:     Math.Round(GetRandomNumber(1, 4), 1) * x,
                    elementalDmg:   Math.Round(GetRandomNumber(150, 900), 1) * x,
                    dmg:            Math.Round(GetRandomNumber(8, 18), 1) * x,
                    highMonster:    Math.Round(GetRandomNumber(17, 29), 1) * x,
                    lowMonster:     Math.Round(GetRandomNumber(14, 32), 1) * x);
            } 
            sbOutput.AppendLine(string.Join(strSeperator, RarityBonus));
            File.AppendAllText(@"C:\Users\Admin\Desktop\WiT\Semestr 4\Solutions\SimulatorApk\dictRarity.txt", sbOutput.ToString());
        }

        public static void CreateInstance()
        {
            string strSeperator = ";";
            StringBuilder sbOutput = new();
            _ = new Random();

            double x = SharedClass.RarityLvlValue.Rarity * 0.4;

            for (var i = 1; i <= 5; i++)
            {
                RarityBonus["button" + i] = new RarityStats(
                    armorPen:       Math.Round(GetRandomNumber(12, 22), 1) * x,
                    hitRate:        Math.Round(GetRandomNumber(100, 250), 1) * x,
                    basicDmg:       Math.Round(GetRandomNumber(300, 900), 1) * x,
                    critChance:     Math.Round(GetRandomNumber(4, 11), 1) * x,
                    stunChance:     Math.Round(GetRandomNumber(1, 4), 1) * x,
                    elementalDmg:   Math.Round(GetRandomNumber(150, 900), 1) * x,
                    dmg:            Math.Round(GetRandomNumber(8, 18), 1) * x,
                    highMonster:    Math.Round(GetRandomNumber(17, 29), 1) * x,
                    lowMonster:     Math.Round(GetRandomNumber(14, 32), 1) * x);
            } 
            sbOutput.AppendLine(string.Join(strSeperator, RarityBonus));
            File.AppendAllText(@"C:\Users\Admin\Desktop\WiT\Semestr 4\Solutions\SimulatorApk\dictRarity.txt", sbOutput.ToString());
        }

        public static void CreateInstance()
        {
            string strSeperator = ";";
            StringBuilder sbOutput = new();
            _ = new Random();

            double x = SharedClass.RarityLvlValue.Rarity * 0.4;

            for (var i = 1; i <= 5; i++)
            {
                RarityBonus["button" + i] = new RarityStats(
                    armorPen:       Math.Round(GetRandomNumber(12, 22), 1) * x,
                    hitRate:        Math.Round(GetRandomNumber(100, 250), 1) * x,
                    basicDmg:       Math.Round(GetRandomNumber(300, 900), 1) * x,
                    critChance:     Math.Round(GetRandomNumber(4, 11), 1) * x,
                    stunChance:     Math.Round(GetRandomNumber(1, 4), 1) * x,
                    elementalDmg:   Math.Round(GetRandomNumber(150, 900), 1) * x,
                    dmg:            Math.Round(GetRandomNumber(8, 18), 1) * x,
                    highMonster:    Math.Round(GetRandomNumber(17, 29), 1) * x,
                    lowMonster:     Math.Round(GetRandomNumber(14, 32), 1) * x);
            } 
            sbOutput.AppendLine(string.Join(strSeperator, RarityBonus));
            File.AppendAllText(@"C:\Users\Admin\Desktop\WiT\Semestr 4\Solutions\SimulatorApk\dictRarity.txt", sbOutput.ToString());
        }

W

WhiteboyOP•9/2/22, 3:36 PM

the output

W

WhiteboyOP•9/2/22, 3:36 PM

[button1,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button2,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button3,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button4,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button5,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12]

[button1,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button2,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button3,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button4,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button5,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12]

[button1,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button2,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button3,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button4,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button5,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12]

[button1,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button2,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button3,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button4,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12];

[button5,  ArmorPenetration: 38.72
 BonusHitRate 322.56
 BonusBasicDmg: 969.92
 BonusCritChance: 12.8
 StunChance: 3.2
 ElementalDmg: 492.16
 BonusDmg: 25.92
 HighLvlMonsterDmg: 54.72
 LowLvlMonsterDmg: 45.12]

W

WhiteboyOP•9/2/22, 3:36 PM

why am i not getting "new" random for every instance?

K

Kesa•9/2/22, 3:37 PM

you are, it's just that it's happening so fast that the seed ends up being the same because you are creating a new

Random

Random

Random

Random every time. consider keeping around the

Random

Random

Random

Random instance and just re-using it instead of newing it up every time.

WWhiteboy ```cs private static double GetRandomNumber(double minimum, double maximum) ...

S

Susko3•9/2/22, 3:37 PM

make a static

Random

Random

Random

Random and use that instead of creating a new one

S

Susko3•9/2/22, 3:39 PM

also, due to

Math.Round

Math.Round

Math.Round

Math.Round you're not getting an even distribution of values

P

pox•9/2/22, 3:39 PM

Random.Shared

Random.Shared

Random.Shared

Random.Shared

W

WhiteboyOP•9/2/22, 3:39 PM

winforms

W

WhiteboyOP•9/2/22, 3:39 PM

.net framework 4.7.2

T

TheRanger•9/2/22, 3:40 PM

yeah

T

TheRanger•9/2/22, 3:40 PM

that doesnt happen in .Net core

W

WhiteboyOP•9/2/22, 3:40 PM

@TheRanger i have other similar class

W

WhiteboyOP•9/2/22, 3:40 PM

but on ints

W

WhiteboyOP•9/2/22, 3:40 PM

not doubles

W

WhiteboyOP•9/2/22, 3:40 PM

and works just fine

T

TheRanger•9/2/22, 3:40 PM

it seems Random in .Net Framework gives the same seed

W

WhiteboyOP•9/2/22, 3:41 PM

[button1,  Dmg: 232 - 814
 HitRate: 102
 CritChance: 13
 CritDmg: 304
 Rarity: 1
 Upgrade Lvl: 0];

[button2,  Dmg: 562 - 1942
 HitRate: 425
 CritChance: 8
 CritDmg: 356
 Rarity: 7
 Upgrade Lvl: 0];

[button3,  Dmg: 1380 - 1989
 HitRate: 1001
 CritChance: 11
 CritDmg: 437
 Rarity: 0
 Upgrade Lvl: 0];

[button4,  Dmg: 1751 - 2259
 HitRate: 893
 CritChance: 16
 CritDmg: 423
 Rarity: 3
 Upgrade Lvl: 0];

[button5,  Dmg: 2405 - 3041
 HitRate: 554
 CritChance: 11
 CritDmg: 273
 Rarity: 6
 Upgrade Lvl: 0]

[button1,  Dmg: 232 - 814
 HitRate: 102
 CritChance: 13
 CritDmg: 304
 Rarity: 1
 Upgrade Lvl: 0];

[button2,  Dmg: 562 - 1942
 HitRate: 425
 CritChance: 8
 CritDmg: 356
 Rarity: 7
 Upgrade Lvl: 0];

[button3,  Dmg: 1380 - 1989
 HitRate: 1001
 CritChance: 11
 CritDmg: 437
 Rarity: 0
 Upgrade Lvl: 0];

[button4,  Dmg: 1751 - 2259
 HitRate: 893
 CritChance: 16
 CritDmg: 423
 Rarity: 3
 Upgrade Lvl: 0];

[button5,  Dmg: 2405 - 3041
 HitRate: 554
 CritChance: 11
 CritDmg: 273
 Rarity: 6
 Upgrade Lvl: 0]

[button1,  Dmg: 232 - 814
 HitRate: 102
 CritChance: 13
 CritDmg: 304
 Rarity: 1
 Upgrade Lvl: 0];

[button2,  Dmg: 562 - 1942
 HitRate: 425
 CritChance: 8
 CritDmg: 356
 Rarity: 7
 Upgrade Lvl: 0];

[button3,  Dmg: 1380 - 1989
 HitRate: 1001
 CritChance: 11
 CritDmg: 437
 Rarity: 0
 Upgrade Lvl: 0];

[button4,  Dmg: 1751 - 2259
 HitRate: 893
 CritChance: 16
 CritDmg: 423
 Rarity: 3
 Upgrade Lvl: 0];

[button5,  Dmg: 2405 - 3041
 HitRate: 554
 CritChance: 11
 CritDmg: 273
 Rarity: 6
 Upgrade Lvl: 0]

[button1,  Dmg: 232 - 814
 HitRate: 102
 CritChance: 13
 CritDmg: 304
 Rarity: 1
 Upgrade Lvl: 0];

[button2,  Dmg: 562 - 1942
 HitRate: 425
 CritChance: 8
 CritDmg: 356
 Rarity: 7
 Upgrade Lvl: 0];

[button3,  Dmg: 1380 - 1989
 HitRate: 1001
 CritChance: 11
 CritDmg: 437
 Rarity: 0
 Upgrade Lvl: 0];

[button4,  Dmg: 1751 - 2259
 HitRate: 893
 CritChance: 16
 CritDmg: 423
 Rarity: 3
 Upgrade Lvl: 0];

[button5,  Dmg: 2405 - 3041
 HitRate: 554
 CritChance: 11
 CritDmg: 273
 Rarity: 6
 Upgrade Lvl: 0]

WWhiteboy but on ints

T

TheRanger•9/2/22, 3:42 PM

happens the same with ints

T

TheRanger•9/2/22, 3:42 PM

but was probably not called so fast which is why you get different numbers

W

WhiteboyOP•9/2/22, 3:43 PM

so how do i make static random?

T

TheRanger•9/2/22, 3:44 PM

the same way you define a static method

W

WhiteboyOP•9/2/22, 3:51 PM

i can't get it to work

WWhiteboy i can't get it to work

M

mtreit•9/2/22, 3:56 PM

Show your attempt

W

WhiteboyOP•9/2/22, 4:10 PM

@mtreit i don't know at all

M

mtreit•9/2/22, 4:11 PM

What part is not clear?

W

WhiteboyOP•9/2/22, 4:24 PM

@mtreit this

M

mtreit•9/2/22, 4:25 PM

"this" ?

W

WhiteboyOP•9/2/22, 4:25 PM

make a static Random and use that instead of creating a new one

M

mtreit•9/2/22, 4:25 PM

Do you know what static means?

W

WhiteboyOP•9/2/22, 4:25 PM

private static Random Random()
        {
            Random random = new();
            return random;
        }

private static Random Random()
        {
            Random random = new();
            return random;
        }

private static Random Random()
        {
            Random random = new();
            return random;
        }

private static Random Random()
        {
            Random random = new();
            return random;
        }

W

WhiteboyOP•9/2/22, 4:25 PM

sth like this?

W

WhiteboyOP•9/2/22, 4:25 PM

i get that there are static members

W

WhiteboyOP•9/2/22, 4:26 PM

but making a static random?

M

mtreit•9/2/22, 4:26 PM

No, make it a static field instead of a method

W

WhiteboyOP•9/2/22, 4:26 PM

so like
Random random = 0.5?

M

mtreit•9/2/22, 4:27 PM

Then have each method that needs random numbers access that field or take the Random instance as a method parameter and pass the static field as a parameter

M

mtreit•9/2/22, 4:28 PM

static Random _random = new Random();

M

mtreit•9/2/22, 4:28 PM

As a field of your class that contains the methods

M

mtreit•9/2/22, 4:29 PM

Be aware that Random isn't thread safe though

Mmtreit Be aware that Random isn't thread safe though

W

WhiteboyOP•9/2/22, 4:30 PM

what does that mean D:

WWhiteboy what does that mean D:

M

mtreit•9/2/22, 4:32 PM

It means if you are writing multi-threaded code you need to be careful and avoid concurrent access to instances of Random. If you aren't writing multi-threaded / concurrent code right now, don't worry about it.

W

WhiteboyOP•9/2/22, 4:33 PM

okay thank you, now it works

A

AccordAPP•9/2/22, 4:33 PM

This post has been marked as answered!

Why all my randoms are the same? [Answered]

Similar Threads

Similar Threads

Similar Threads