How to put enum values in a list [SOLVED]

CoreVisional · 2022-10-25T09:48:17.516Z

Hi, I'm quite new to C# and I'm still learning, but I'm tasked to debug a piece of code using C#, I managed to fix it but I have like a super long if statement that contains the same thing, except for the values of enum. I came from Python and usually, I'd just declare a list like `my_list = [1, 2]`, but from what I found, I just need to use Enum.GetValues().

C

CoreVisionalOP•10/25/22, 9:50 AM

the if statement looks something like

if (test.IsValid && item.ItemType != ItemType.FirstItem && item.File != null)

if (test.IsValid && item.ItemType != ItemType.FirstItem && item.File != null)

if (test.IsValid && item.ItemType != ItemType.FirstItem && item.File != null)

if (test.IsValid && item.ItemType != ItemType.FirstItem && item.File != null)

I need to validate for the second item as well, and my current solution makes it super redundant

if ((test.IsValid && item.ItemType != ItemType.FirstItem && item.File != null) && (test.IsValid && item.ItemType != ItemType.SecondItem&& item.File != null))

if ((test.IsValid && item.ItemType != ItemType.FirstItem && item.File != null) && (test.IsValid && item.ItemType != ItemType.SecondItem&& item.File != null))

if ((test.IsValid && item.ItemType != ItemType.FirstItem && item.File != null) && (test.IsValid && item.ItemType != ItemType.SecondItem&& item.File != null))

if ((test.IsValid && item.ItemType != ItemType.FirstItem && item.File != null) && (test.IsValid && item.ItemType != ItemType.SecondItem&& item.File != null))

C

CoreVisionalOP•10/25/22, 9:51 AM

So I'm wondering if there's a way for me to put

ItemType.FirstItem

ItemType.FirstItem

and

ItemType.SecondItem

ItemType.SecondItem

into like an array for the if statement to check

K

Kouhai•10/25/22, 10:10 AM

You can use a ValueTuples like this

void Match(FirstEnum first, SecondEnum second)
{
    switch ((first, second))
    {
        case (FirstEnum.FirstItem, SecondEnum.Invalid):
            Console.WriteLine("First and invalid");
            break;
        case (FirstEnum.SecondItem, SecondEnum.Invalid):
            Console.WriteLine("Second and invalid");
            break;
        default:
            Console.WriteLine("Default");
            break;
    }

}

void Match(FirstEnum first, SecondEnum second)
{
    switch ((first, second))
    {
        case (FirstEnum.FirstItem, SecondEnum.Invalid):
            Console.WriteLine("First and invalid");
            break;
        case (FirstEnum.SecondItem, SecondEnum.Invalid):
            Console.WriteLine("Second and invalid");
            break;
        default:
            Console.WriteLine("Default");
            break;
    }

}

void Match(FirstEnum first, SecondEnum second)
{
    switch ((first, second))
    {
        case (FirstEnum.FirstItem, SecondEnum.Invalid):
            Console.WriteLine("First and invalid");
            break;
        case (FirstEnum.SecondItem, SecondEnum.Invalid):
            Console.WriteLine("Second and invalid");
            break;
        default:
            Console.WriteLine("Default");
            break;
    }

}

void Match(FirstEnum first, SecondEnum second)
{
    switch ((first, second))
    {
        case (FirstEnum.FirstItem, SecondEnum.Invalid):
            Console.WriteLine("First and invalid");
            break;
        case (FirstEnum.SecondItem, SecondEnum.Invalid):
            Console.WriteLine("Second and invalid");
            break;
        default:
            Console.WriteLine("Default");
            break;
    }

}

K

Kouhai•10/25/22, 10:12 AM

Or if you just want to return a value for each condition you can go with pattern matching

K

Kouhai•10/25/22, 10:13 AM

void Match(FirstEnum first, SecondEnum second)
{
    var str = (first, second) switch
    {
        (FirstEnum.FirstItem, SecondEnum.Invalid) => "First and invalid",
        (FirstEnum.SecondItem, SecondEnum.Invalid) => "Second and invalid",
        _ => null
    };

}

void Match(FirstEnum first, SecondEnum second)
{
    var str = (first, second) switch
    {
        (FirstEnum.FirstItem, SecondEnum.Invalid) => "First and invalid",
        (FirstEnum.SecondItem, SecondEnum.Invalid) => "Second and invalid",
        _ => null
    };

}

void Match(FirstEnum first, SecondEnum second)
{
    var str = (first, second) switch
    {
        (FirstEnum.FirstItem, SecondEnum.Invalid) => "First and invalid",
        (FirstEnum.SecondItem, SecondEnum.Invalid) => "Second and invalid",
        _ => null
    };

}

void Match(FirstEnum first, SecondEnum second)
{
    var str = (first, second) switch
    {
        (FirstEnum.FirstItem, SecondEnum.Invalid) => "First and invalid",
        (FirstEnum.SecondItem, SecondEnum.Invalid) => "Second and invalid",
        _ => null
    };

}

C

CoreVisionalOP•10/25/22, 10:25 AM

I'm actually working with ASP NET as well, my bad I forgot to put in the tag nor mention it. The code after the if statement is taken care of, though I can still refactor it. I'm just looking to perhaps shorten the if statement

C

CoreVisionalOP•10/25/22, 10:36 AM

Welp, piping it doesn't work, I tried

if (test.IsValid && item.ItemType != (ItemType.FirstItem | Itemtype.SecondItem) && item.File != null)

if (test.IsValid && item.ItemType != (ItemType.FirstItem | Itemtype.SecondItem) && item.File != null)

C

CoreVisionalOP•10/25/22, 10:53 AM

Ohh I think I found the solution. I just use

Enum.GetValues()

Enum.GetValues()

and within my if statement, I just wrote

if (!test.IsValid && item.ItemType.Equals(listOfItems) && item.File != null)

if (!test.IsValid && item.ItemType.Equals(listOfItems) && item.File != null)

C

CoreVisionalOP•10/25/22, 10:54 AM

It works lol

C

CoreVisionalOP•10/25/22, 10:54 AM

Still, thank you for the help @Kouhai

How to put enum values in a list [SOLVED]

Similar Threads

Similar Threads

Similar Threads