❔ Compare Enum Values with submitted value

CoreVisional · 2022-11-15T14:32:03.684Z

Hi, how can I compare the submitted value with values in an enum without using switch-case? For example, ```csharp public enum Weekends { Saturday, Sunday } [HttpPost] public async Task Create([FromForm] Day day) { var weekendvalues = Enum.GetNames(typeof(Weekends)); var values = string.Join(", ", weekendvalues); if (day.Day != values) { // Do something } else if () { // Some other things } } ```

C

CoreVisionalOP•11/15/22, 2:32 PM

I hope this gives more context than my previous post on what I'm trying achieve

S

Samarichitane•11/15/22, 2:36 PM

You can use compare with values i suppose

S

Samarichitane•11/15/22, 2:37 PM

But why you are avoiding using switch case ?

C

CoreVisionalOP•11/15/22, 2:41 PM

I'm not, I'm just looking to see if it's possible to use it within the if statement rather than having another switch-case block just for that one comparison, like

if (Model.State.IsValid && day.Day != values && day.File != null)

if (Model.State.IsValid && day.Day != values && day.File != null)

if (Model.State.IsValid && day.Day != values && day.File != null)

if (Model.State.IsValid && day.Day != values && day.File != null), so that means I have a switch-case block just for

day.Day != values

day.Day != values

day.Day != values

day.Day != values

SSamarichitane You can use compare with values i suppose

C

CoreVisionalOP•11/15/22, 2:41 PM

the

compareto()

compareto()

compareto()

compareto()?

S

Samarichitane•11/15/22, 2:42 PM

Basicly Enum values are int actually

S

Samarichitane•11/15/22, 2:42 PM

underlying type is int

S

Samarichitane•11/15/22, 2:42 PM

If you count Monday as a 0

S

Samarichitane•11/15/22, 2:42 PM

5 and 6 is weekends

C

CoreVisionalOP•11/15/22, 2:45 PM

I'm guessing it's not pretty to do it within the if statement, but do something like?

  switch (day.Day) {
    case Day.Saturday:
      // Do something
      break;
  }

  switch (day.Day) {
    case Day.Saturday:
      // Do something
      break;
  }

  switch (day.Day) {
    case Day.Saturday:
      // Do something
      break;
  }

  switch (day.Day) {
    case Day.Saturday:
      // Do something
      break;
  }

M

MODiX•11/15/22, 2:45 PM

Toshiya Joshima#3472

REPL Result: Success

private enum Days
{
    Monday,
    Tuesday,
    Wednesday,
    Thursday,
    Friday,
    Saturday,
    Sunday
}
    var names = Enum.GetNames<Days>();
    var values = Enum.GetValues<Days>().Cast<int>();

    var collection = names.Zip(values, (s, days) => (days, s));

    Console.WriteLine(string.Join(Environment.NewLine, collection));

private enum Days
{
    Monday,
    Tuesday,
    Wednesday,
    Thursday,
    Friday,
    Saturday,
    Sunday
}
    var names = Enum.GetNames<Days>();
    var values = Enum.GetValues<Days>().Cast<int>();

    var collection = names.Zip(values, (s, days) => (days, s));

    Console.WriteLine(string.Join(Environment.NewLine, collection));

private enum Days
{
    Monday,
    Tuesday,
    Wednesday,
    Thursday,
    Friday,
    Saturday,
    Sunday
}
    var names = Enum.GetNames<Days>();
    var values = Enum.GetValues<Days>().Cast<int>();

    var collection = names.Zip(values, (s, days) => (days, s));

    Console.WriteLine(string.Join(Environment.NewLine, collection));

private enum Days
{
    Monday,
    Tuesday,
    Wednesday,
    Thursday,
    Friday,
    Saturday,
    Sunday
}
    var names = Enum.GetNames<Days>();
    var values = Enum.GetValues<Days>().Cast<int>();

    var collection = names.Zip(values, (s, days) => (days, s));

    Console.WriteLine(string.Join(Environment.NewLine, collection));

Console Output

(0, Monday)
(1, Tuesday)
(2, Wednesday)
(3, Thursday)
(4, Friday)
(5, Saturday)
(6, Sunday)

(0, Monday)
(1, Tuesday)
(2, Wednesday)
(3, Thursday)
(4, Friday)
(5, Saturday)
(6, Sunday)

(0, Monday)
(1, Tuesday)
(2, Wednesday)
(3, Thursday)
(4, Friday)
(5, Saturday)
(6, Sunday)

(0, Monday)
(1, Tuesday)
(2, Wednesday)
(3, Thursday)
(4, Friday)
(5, Saturday)
(6, Sunday)

Compile: 727.529ms | Execution: 111.930ms | React with ❌ to remove this embed.

S

Samarichitane•11/15/22, 2:46 PM

you can check index number it's 5 or 6 etc

S

Samarichitane•11/15/22, 2:47 PM

  switch (day.Day) {
    case Day.Saturday or Day.Sunday:
      // Do something
      break;
    default:
      // Do something else for weekdays
      break;
  }

  switch (day.Day) {
    case Day.Saturday or Day.Sunday:
      // Do something
      break;
    default:
      // Do something else for weekdays
      break;
  }

  switch (day.Day) {
    case Day.Saturday or Day.Sunday:
      // Do something
      break;
    default:
      // Do something else for weekdays
      break;
  }

  switch (day.Day) {
    case Day.Saturday or Day.Sunday:
      // Do something
      break;
    default:
      // Do something else for weekdays
      break;
  }

S

Samarichitane•11/15/22, 2:47 PM

with switch

S

Samarichitane•11/15/22, 2:47 PM

it should be look something like this

C

CoreVisionalOP•11/15/22, 2:54 PM

Hmm, another reason why I didn't wanna use switch case is because there's a chunk of code under the if body, so moving them inside the case won't look neat.

D

D.Mentia•11/15/22, 2:56 PM

er... if I'm understanding this right, you're just looking for

if (day.Day == Days.Saturday)

if (day.Day == Days.Saturday)

if (day.Day == Days.Saturday)

if (day.Day == Days.Saturday)

DD.Mentia er... if I'm understanding this right, you're just looking for `if (day.Day == D...

C

CoreVisionalOP•11/15/22, 2:57 PM

No, both values. The above except the post itself were just examples

D

D.Mentia•11/15/22, 2:58 PM

Then put an or in

C

CoreVisionalOP•11/15/22, 3:04 PM

Yeah, something like

if (Model.State.IsValid && day.Day != Saturday or day.Day != Sunday && day.File != null)

if (Model.State.IsValid && day.Day != Saturday or day.Day != Sunday && day.File != null)

if (Model.State.IsValid && day.Day != Saturday or day.Day != Sunday && day.File != null)

if (Model.State.IsValid && day.Day != Saturday or day.Day != Sunday && day.File != null), I was also hoping if it was possible to just extract the values and assign them to a variable

D

D.Mentia•11/15/22, 3:04 PM

but really, make a

Day[] Weekends = new() { Days.Saturday, Days.Sunday }

Day[] Weekends = new() { Days.Saturday, Days.Sunday }

Day[] Weekends = new() { Days.Saturday, Days.Sunday }

Day[] Weekends = new() { Days.Saturday, Days.Sunday } and check

if (Weekends.Contains(day.Day))

if (Weekends.Contains(day.Day))

if (Weekends.Contains(day.Day))

if (Weekends.Contains(day.Day))

DD.Mentia but really, make a `Day[] Weekends = new() { Days.Saturday, Days.Sunday }` and c...

C

CoreVisionalOP•11/15/22, 3:06 PM

I'm assuming this one checks against the values in

enum Weekends

enum Weekends

enum Weekends

enum Weekends? Or is it creating a new enum?

D

D.Mentia•11/15/22, 3:06 PM

It is assuming there is

enum Days

enum Days

enum Days

enum Days, and replaces

enum Weekends

enum Weekends

enum Weekends

enum Weekends

D

D.Mentia•11/15/22, 3:08 PM

Also I'd rename that variable,

day

day

day

day

it's not a Day, day.Day is a Day...

S

Samarichitane•11/15/22, 3:13 PM

if (day.Day is Days.Saturday or Days.Sunday)

S

Samarichitane•11/15/22, 3:13 PM

is fine too

S

Samarichitane•11/15/22, 3:13 PM

after handling weekends

S

Samarichitane•11/15/22, 3:13 PM

else part is weekdays

DD.Mentia It is assuming there is `enum Days`, and replaces `enum Weekends`

C

CoreVisionalOP•11/15/22, 3:29 PM

Assumes there is

enum Days

enum Days

enum Days

enum Days...hmm, so, it is creating a new enum then? If not, I still don't get this part

SSamarichitane if (day.Day is Days.Saturday or Days.Sunday)

C

CoreVisionalOP•11/15/22, 3:50 PM

I'm assuming it should be

if (day.Day is Days.Saturday or day.Day is Days.Sunday)

if (day.Day is Days.Saturday or day.Day is Days.Sunday)

if (day.Day is Days.Saturday or day.Day is Days.Sunday)

if (day.Day is Days.Saturday or day.Day is Days.Sunday)?

S

Samarichitane•11/15/22, 3:51 PM

no

DD.Mentia but really, make a `Day[] Weekends = new() { Days.Saturday, Days.Sunday }` and c...

C

CoreVisionalOP•11/15/22, 7:02 PM

Btw, this wouldn't really work as

day

day

day

day gets value from user selection. So

Weekends.Contains(day.Day))

Weekends.Contains(day.Day))

Weekends.Contains(day.Day))

Weekends.Contains(day.Day)) checks for the value in that enum, when it should be the other way around

D

D.Mentia•11/15/22, 9:19 PM

The user selects a Day, from enum Days. Weekends is a collection of Days. If the user-selected Day is in Weekends, it's a weekend

DD.Mentia The user selects a Day, from enum Days. Weekends is a collection of Days. If t...

C

CoreVisionalOP•11/16/22, 3:57 AM

Apparently I get errors saying that Day[] cannot be used as a context of type new()

C

CoreVisionalOP•11/16/22, 3:58 AM

Also, Days doesn't exist error as well...

C

CoreVisionalOP•11/16/22, 6:24 AM

Yea but flag is checking for value existence tho, I'm not checking to see if the value exists

C

CoreVisionalOP•11/16/22, 6:25 AM

I'm checking if the selected value is the same as the one in enum. The dropdown value is retrieved from the enum, so in other words, values already exist, just need to check what the user selects

C

CoreVisionalOP•11/16/22, 6:28 AM

Plus, I'm not looking to modify my model class. It seems like Flags requires some modifications to it

H

hippiewho•11/16/22, 6:45 AM

If im understanding correctly you just want to make the expression shorter?
Maybe something like

var weekends = Weekends.Saturday | Weekends.Sunday;
bool isWeekEnd = weekends.HasFlag(day.Day);

var weekends = Weekends.Saturday | Weekends.Sunday;
bool isWeekEnd = weekends.HasFlag(day.Day);

var weekends = Weekends.Saturday | Weekends.Sunday;
bool isWeekEnd = weekends.HasFlag(day.Day);

var weekends = Weekends.Saturday | Weekends.Sunday;
bool isWeekEnd = weekends.HasFlag(day.Day);

C

CoreVisionalOP•11/16/22, 6:55 AM

Hmm, how about this?

var weekendValues= new[] { Weekends.Saturday, Weekends.Sunday}.Contains(day.Day);

var weekendValues= new[] { Weekends.Saturday, Weekends.Sunday}.Contains(day.Day);

var weekendValues= new[] { Weekends.Saturday, Weekends.Sunday}.Contains(day.Day);

var weekendValues= new[] { Weekends.Saturday, Weekends.Sunday}.Contains(day.Day);

C

CoreVisionalOP•11/16/22, 6:56 AM

and in my if statement, since I don't want to accept these two values, I just negate like

if (!weekendValues)

if (!weekendValues)

if (!weekendValues)

if (!weekendValues). I tried it and it works, but I'm not sure if there's some underlying caveat here

Hhippiewho If im understanding correctly you just want to make the expression shorter? Mayb...

C

CoreVisionalOP•11/16/22, 7:01 AM

Getting error "Type must be an enum that does not have an associated FlagsAttribute. (Parameter 'TEnum')"

H

hippiewho•11/16/22, 7:02 AM

are you using the flags attribute?

Hhippiewho are you using the flags attribute?

C

CoreVisionalOP•11/16/22, 7:03 AM

Yea, I have [Flags] placed above the public enum

H

hippiewho•11/16/22, 7:04 AM

do you need it? you cant use it if you want to use HasFlag

C

CoreVisionalOP•11/16/22, 7:04 AM

Does this [Flags] modify anything? Or it's there awaiting for instruction? Like the use of "HasFlag"

C

CoreVisionalOP•11/16/22, 7:04 AM

Because if it does modify, this solution won't work for me, it will disrupt 80+ other references to this enum

C

CoreVisionalOP•11/16/22, 7:04 AM

Ohh, so no need the [Flags] right?

H

hippiewho•11/16/22, 7:04 AM

nope

❔ Compare Enum Values with submitted value

Similar Threads

Similar Threads

Similar Threads