C#•3y ago

❔ Help C# countdown timer

I'm creating a countdown timer, I managed to make the minutes and seconds work, however I need it to have hours too but I'm not managing to set the code logic to show the hours, in my case the user type in a textbox the time and click on the button time starts running until it reaches 0, please could someone help me

int time = 0;
        int minutes = 0;
        int seconds = 0;
        int hours = 0;

private void btnStart_Click(object sender, EventArgs e)
        {
           time = Convert.ToInt32(txtTempo.Text);

            if(time >= 60)
            {
                hours = time / 24;
                minutes = time % 60;
                seconds = time % 60;  
            }
            else
            {
                hours = 0;
                minutes = 0;
                seconds = time;
               
            }
            lblTempo.Text = string.Format("{0}:{1}:{2}", hours.ToString().PadLeft(2, '0'), minutes.ToString().PadLeft(2, '0'), seconds.ToString().PadLeft(2, '0'));
            timer1.Enabled = true;
        }

        private void timer1_Tick(object sender, EventArgs e)
        {
            seconds--;

            if (hours > 0)
            {
                if (minutes < 0)
                {
                    minutes = 59;
                    hours--;
                    
                    if (minutes > 0)
                    {
                        if (seconds < 0)
                        {
                            seconds = 59;
                            minutes--;
                            
                        }
                    }
                }
            }
            lblTempo.Text = string.Format("{0}:{1}:{2}", hours.ToString().PadLeft(2, '0'), minutes.ToString().PadLeft(2, '0'), seconds.ToString().PadLeft(2, '0'));

            if (hours == 0 && minutes == 0 && seconds == 0)
            {
                timer1.Enabled = false;
            }
        }

int time = 0;
        int minutes = 0;
        int seconds = 0;
        int hours = 0;

private void btnStart_Click(object sender, EventArgs e)
        {
           time = Convert.ToInt32(txtTempo.Text);

            if(time >= 60)
            {
                hours = time / 24;
                minutes = time % 60;
                seconds = time % 60;  
            }
            else
            {
                hours = 0;
                minutes = 0;
                seconds = time;
               
            }
            lblTempo.Text = string.Format("{0}:{1}:{2}", hours.ToString().PadLeft(2, '0'), minutes.ToString().PadLeft(2, '0'), seconds.ToString().PadLeft(2, '0'));
            timer1.Enabled = true;
        }

        private void timer1_Tick(object sender, EventArgs e)
        {
            seconds--;

            if (hours > 0)
            {
                if (minutes < 0)
                {
                    minutes = 59;
                    hours--;
                    
                    if (minutes > 0)
                    {
                        if (seconds < 0)
                        {
                            seconds = 59;
                            minutes--;
                            
                        }
                    }
                }
            }
            lblTempo.Text = string.Format("{0}:{1}:{2}", hours.ToString().PadLeft(2, '0'), minutes.ToString().PadLeft(2, '0'), seconds.ToString().PadLeft(2, '0'));

            if (hours == 0 && minutes == 0 && seconds == 0)
            {
                timer1.Enabled = false;
            }
        }

int time = 0;
        int minutes = 0;
        int seconds = 0;
        int hours = 0;

private void btnStart_Click(object sender, EventArgs e)
        {
           time = Convert.ToInt32(txtTempo.Text);

            if(time >= 60)
            {
                hours = time / 24;
                minutes = time % 60;
                seconds = time % 60;  
            }
            else
            {
                hours = 0;
                minutes = 0;
                seconds = time;
               
            }
            lblTempo.Text = string.Format("{0}:{1}:{2}", hours.ToString().PadLeft(2, '0'), minutes.ToString().PadLeft(2, '0'), seconds.ToString().PadLeft(2, '0'));
            timer1.Enabled = true;
        }

        private void timer1_Tick(object sender, EventArgs e)
        {
            seconds--;

            if (hours > 0)
            {
                if (minutes < 0)
                {
                    minutes = 59;
                    hours--;
                    
                    if (minutes > 0)
                    {
                        if (seconds < 0)
                        {
                            seconds = 59;
                            minutes--;
                            
                        }
                    }
                }
            }
            lblTempo.Text = string.Format("{0}:{1}:{2}", hours.ToString().PadLeft(2, '0'), minutes.ToString().PadLeft(2, '0'), seconds.ToString().PadLeft(2, '0'));

            if (hours == 0 && minutes == 0 && seconds == 0)
            {
                timer1.Enabled = false;
            }
        }

int time = 0;
        int minutes = 0;
        int seconds = 0;
        int hours = 0;

private void btnStart_Click(object sender, EventArgs e)
        {
           time = Convert.ToInt32(txtTempo.Text);

            if(time >= 60)
            {
                hours = time / 24;
                minutes = time % 60;
                seconds = time % 60;  
            }
            else
            {
                hours = 0;
                minutes = 0;
                seconds = time;
               
            }
            lblTempo.Text = string.Format("{0}:{1}:{2}", hours.ToString().PadLeft(2, '0'), minutes.ToString().PadLeft(2, '0'), seconds.ToString().PadLeft(2, '0'));
            timer1.Enabled = true;
        }

        private void timer1_Tick(object sender, EventArgs e)
        {
            seconds--;

            if (hours > 0)
            {
                if (minutes < 0)
                {
                    minutes = 59;
                    hours--;
                    
                    if (minutes > 0)
                    {
                        if (seconds < 0)
                        {
                            seconds = 59;
                            minutes--;
                            
                        }
                    }
                }
            }
            lblTempo.Text = string.Format("{0}:{1}:{2}", hours.ToString().PadLeft(2, '0'), minutes.ToString().PadLeft(2, '0'), seconds.ToString().PadLeft(2, '0'));

            if (hours == 0 && minutes == 0 && seconds == 0)
            {
                timer1.Enabled = false;
            }
        }

phaseshift•2/28/23, 1:07 AM

Hours= time/24 (your code)

phaseshift•2/28/23, 1:07 AM

What units does time have here?

Pphaseshift What units does time have here?

The JokerOP•2/28/23, 1:37 AM

Hours, Minutes and Seconds

Pphaseshift What units does time have here?

The JokerOP•2/28/23, 1:37 AM

the user will type in the text box the time in seconds

phaseshift•2/28/23, 1:38 AM

Tell me, what is seconds/24?

phaseshift•2/28/23, 1:41 AM

Or what are you trying to calculate with that?

Pphaseshift Tell me, what is seconds/24?

The JokerOP•2/28/23, 1:49 AM

precisely this part that I don't understand, I managed to get minutes and seconds to work but the hours I couldn't

phaseshift•2/28/23, 1:51 AM

Well how many seconds do you need to display 1hr ?

Pphaseshift Well how many seconds do you need to display 1hr ?

The JokerOP•2/28/23, 1:53 AM

3600

phaseshift•2/28/23, 1:53 AM

So where did you pull '24' from?

Pphaseshift So where did you pull '24' from?

The JokerOP•2/28/23, 1:54 AM

I don't know

The JokerOP•2/28/23, 1:54 AM

I'm still a beginner

phaseshift•2/28/23, 1:54 AM

Beginner at multiplication?

phaseshift•2/28/23, 1:56 AM

You have a lot of 'if' without else. Looks very complicated

phaseshift•2/28/23, 1:58 AM

But it seems like the first thing you do is take away 1 second, correct?

phaseshift•2/28/23, 1:59 AM

So tell me in words, what is the order of checks you need to do for changing seconds, minutes, hours

phaseshift•2/28/23, 2:00 AM

Eg starting from 1h01m01s

Pphaseshift So tell me in words, what is the order of checks you need to do for changing sec...

The JokerOP•2/28/23, 2:04 AM

the order is the user types in the text box a value that is counted in seconds, when I click on start automatically the label presents me with the value converted into hh:mm:ss, minutes and seconds I managed to make it work, but when the user types for example 3700 seconds it does not count the time. that is, it does not appear

The JokerOP•2/28/23, 2:04 AM

this what i'm doing is a countdown timer

phaseshift•2/28/23, 2:04 AM

I don't think your seconds/minutes works anyway. But I'm not talking about that order

phaseshift•2/28/23, 2:05 AM

I'm asking about the order of checks you need to make in the code

phaseshift•2/28/23, 2:05 AM

The algorithm.

The JokerOP•2/28/23, 2:05 AM

The JokerOP•2/28/23, 2:06 AM

minutes and seconds work

The JokerOP•2/28/23, 2:06 AM

my problem is with values above 3600 seconds

The JokerOP•2/28/23, 2:07 AM

The JokerOP•2/28/23, 2:07 AM

3800 sec

phaseshift•2/28/23, 2:07 AM

That's broken at 0 minutes 59s

phaseshift•2/28/23, 2:07 AM

Right?

The JokerOP•2/28/23, 2:07 AM

the hours do not appear, it only increases in minutes

The JokerOP•2/28/23, 2:09 AM

yes seconds to 0 return for 59

phaseshift•2/28/23, 2:10 AM

Oh ok, I see it .

phaseshift•2/28/23, 2:13 AM

Well, you know how when you're watching a digital countdown, the smallest unit moves first, then slowly it works to the left/larger things

phaseshift•2/28/23, 2:14 AM

That's the order your checks should be. You have them backwards

phaseshift•2/28/23, 2:15 AM

And since you're trying to get things working backwards, you've got an impossible combination of ifs

Pphaseshift And since you're trying to get things working backwards, you've got an impossibl...

The JokerOP•2/28/23, 2:15 AM

and how would it be correct?

phaseshift•2/28/23, 2:16 AM

Check seconds first

phaseshift•2/28/23, 2:16 AM

phaseshift•2/28/23, 2:17 AM

If minutes is LT 0 it can never be GT 0. that inner block will never be hit

The JokerOP•2/28/23, 2:19 AM

ok thanks

The JokerOP•2/28/23, 2:19 AM

wow very complicated

phaseshift•2/28/23, 2:22 AM

If you keep going with hours > minutes > seconds, then yes. Hence why I suggest you reverse your order

phaseshift•2/28/23, 2:23 AM

Or the alternative is just redo the initial calculation with 1 fewer seconds

The JokerOP•2/28/23, 2:24 AM

can you give me an example

phaseshift•2/28/23, 2:29 AM

Of what

The JokerOP•2/28/23, 12:25 PM

Can someone please help me?

TThe Joker Can someone please help me?

Anton•2/28/23, 12:40 PM

use DateTime

Anton•2/28/23, 12:40 PM

there's DateTime.FromSeconds

Anton•2/28/23, 12:41 PM

it does all of that for you

Anton•2/28/23, 12:42 PM

and you could also do dt -= DateTime.FromSeconds(1)dt -= DateTime.FromSeconds(1) if you use that

❔ Help C# countdown timer

Similar Threads

Similar Threads

Similar Threads