TanStack•3y ago•

6 replies

full-green

Does `useMutation().mutate()` batch calls to `onSuccess`?

I have an array of persons I want to create in some kind of API using a POST request. Unfortunately my Backend only exposes a singular

create-person

create-person

endpoint.

So I loop over this array and create a bucket of Promises using the mutations returned from

useMutation()

useMutation()

- they are all the same call in the end. I add a

onSuccess

onSuccess

callback. The code looks something like this:

mutations.push(
  new Promise((resolve, reject) => {
    createPerson(
      {
        companyId: id,
        person: parsedPersonValues,
      },
      {
        onError: reject,
        onSuccess: () =>
          resolve(
            translate('feedback.success.createPerson', {
              replacements: [response.name],
            }),
          ),
      },
    );
  }),
);

mutations.push(
  new Promise((resolve, reject) => {
    createPerson(
      {
        companyId: id,
        person: parsedPersonValues,
      },
      {
        onError: reject,
        onSuccess: () =>
          resolve(
            translate('feedback.success.createPerson', {
              replacements: [response.name],
            }),
          ),
      },
    );
  }),
);

createPerson()

createPerson()

comes from a custom hook that returns

useMutation()

useMutation()

with a queryFn and some callbacks.

I later than call

Promise.allSettled(mutations)

Promise.allSettled(mutations)

to wait for all requests and work display the results (errors or success toasts).

When triggering with just one new person it works fine. But when triggering this with multiple persons, only the last Promise resolves or rejects. All other Promises never fulfil - they all remain

pending

pending

causing my

Promise.allSettled()

Promise.allSettled()

to never trigger and causing my app to hang in an infinite "submitting" state although all API calls were made successfully.

I traced it down to the

onSuccess

onSuccess

on the actual

mutate()

mutate()

call not firing (onError and onSettled also don't trigger). Does react-query do some sort of batching here?

Thanks for any help

TanStack•3y ago•

6 replies

full-green

Does `useMutation().mutate()` batch calls to `onSuccess`?

I have an array of persons I want to create in some kind of API using a POST request. Unfortunately my Backend only exposes a singular

create-person

create-person

endpoint.

So I loop over this array and create a bucket of Promises using the mutations returned from

useMutation()

useMutation()

- they are all the same call in the end. I add a

onSuccess

onSuccess

callback. The code looks something like this:

mutations.push(
  new Promise((resolve, reject) => {
    createPerson(
      {
        companyId: id,
        person: parsedPersonValues,
      },
      {
        onError: reject,
        onSuccess: () =>
          resolve(
            translate('feedback.success.createPerson', {
              replacements: [response.name],
            }),
          ),
      },
    );
  }),
);

mutations.push(
  new Promise((resolve, reject) => {
    createPerson(
      {
        companyId: id,
        person: parsedPersonValues,
      },
      {
        onError: reject,
        onSuccess: () =>
          resolve(
            translate('feedback.success.createPerson', {
              replacements: [response.name],
            }),
          ),
      },
    );
  }),
);

createPerson()

createPerson()

comes from a custom hook that returns

useMutation()

useMutation()

with a queryFn and some callbacks.

I later than call

Promise.allSettled(mutations)

Promise.allSettled(mutations)

pending

pending

causing my

Promise.allSettled()

Promise.allSettled()

to never trigger and causing my app to hang in an infinite "submitting" state although all API calls were made successfully.

I traced it down to the

onSuccess

onSuccess

on the actual

mutate()

mutate()

call not firing (onError and onSettled also don't trigger). Does react-query do some sort of batching here?

Thanks for any help

Does `useMutation().mutate()` batch calls to `onSuccess`?

Similar Threads

Does `useMutation().mutate()` batch calls to `onSuccess`?

Similar Threads

Similar Threads

Similar Threads