Maximum execution time of 60 seconds exceeded

Chrysippus · 2023-06-28T09:03:24.202Z

I have this Observer where I want to get the total whenever I create or update on my OrderResource It's working but taking a long time to process and gets error at the end of the process "maximum execution time error of 60 seconds"

C

ChrysippusOP•6/28/23, 9:04 AM

OrderResource

OrderResource.txt13.53KB

C

ChrysippusOP•6/28/23, 9:04 AM

OrderObserver

<?php

namespace App\Observers;

use App\Models\Order;

class OrderObserver
{
    public function saved(Order $order)
    {
        $this->updateTotal($order);
    }

    public function deleted(Order $order)
    {
        $this->updateTotal($order);
    }

    private function updateTotal(Order $order)
    {
        $orderItems = $order->orderItems()->get();
        $shippingFee = $order->shipping_fee;
        $subtotal = $orderItems->sum(function ($item) {
            return $item->product_quantity * $item->product_price;
        });
        $total = $subtotal + $shippingFee;
        $order->total = $total;
        $order->save();
    }
}

<?php

namespace App\Observers;

use App\Models\Order;

class OrderObserver
{
    public function saved(Order $order)
    {
        $this->updateTotal($order);
    }

    public function deleted(Order $order)
    {
        $this->updateTotal($order);
    }

    private function updateTotal(Order $order)
    {
        $orderItems = $order->orderItems()->get();
        $shippingFee = $order->shipping_fee;
        $subtotal = $orderItems->sum(function ($item) {
            return $item->product_quantity * $item->product_price;
        });
        $total = $subtotal + $shippingFee;
        $order->total = $total;
        $order->save();
    }
}

<?php

namespace App\Observers;

use App\Models\Order;

class OrderObserver
{
    public function saved(Order $order)
    {
        $this->updateTotal($order);
    }

    public function deleted(Order $order)
    {
        $this->updateTotal($order);
    }

    private function updateTotal(Order $order)
    {
        $orderItems = $order->orderItems()->get();
        $shippingFee = $order->shipping_fee;
        $subtotal = $orderItems->sum(function ($item) {
            return $item->product_quantity * $item->product_price;
        });
        $total = $subtotal + $shippingFee;
        $order->total = $total;
        $order->save();
    }
}

<?php

namespace App\Observers;

use App\Models\Order;

class OrderObserver
{
    public function saved(Order $order)
    {
        $this->updateTotal($order);
    }

    public function deleted(Order $order)
    {
        $this->updateTotal($order);
    }

    private function updateTotal(Order $order)
    {
        $orderItems = $order->orderItems()->get();
        $shippingFee = $order->shipping_fee;
        $subtotal = $orderItems->sum(function ($item) {
            return $item->product_quantity * $item->product_price;
        });
        $total = $subtotal + $shippingFee;
        $order->total = $total;
        $order->save();
    }
}

D

Dennis Koch•6/28/23, 9:06 AM

What's the question?

DDennis Koch What's the question?

C

ChrysippusOP•6/28/23, 9:08 AM

The process of getting the total whenever I create/update was working but only after 60seconds and i get the 60seconds timeout

D

Dennis Koch•6/28/23, 9:09 AM

Again: What is your question?

D

Dennis Koch•6/28/23, 9:10 AM

Why does that simple summarization code take so long?

DDennis Koch Why does that simple summarization code take so long?

C

ChrysippusOP•6/28/23, 9:10 AM

yes

D

Dennis Koch•6/28/23, 9:12 AM

That's something you need to figure out. It's hard to debug performance issues via chat.

D

Dennis Koch•6/28/23, 9:13 AM

Start by checking the execution time of the updateTotal method.

C

ChrysippusOP•6/28/23, 9:13 AM

Is my method correct or there's more suitable solution to do this?

D

Dennis Koch•6/28/23, 9:14 AM

I guess you are running into a loop: When you call

$order->save()

$order->save()

$order->save()

$order->save() your Observer::saved() method is called again

DDennis Koch I guess you are running into a loop: When you call `$order->save()` your Observe...

C

ChrysippusOP•6/28/23, 11:33 AM

Can't I just get the total directly from the textInput something like this

TextInput::make('total')
  ->dehydrated(false)
  ->label('Total Price')
  ->default(function ($get) {
      $orderItems = collect($get('orderItems'));
      $shippingFee = $get('shipping_fee');
      $subtotal = $orderItems->sum(function ($item) {
          return $item['product_quantity'] * $item['product_price'];
      });
      return $subtotal + $shippingFee;
  }),

TextInput::make('total')
  ->dehydrated(false)
  ->label('Total Price')
  ->default(function ($get) {
      $orderItems = collect($get('orderItems'));
      $shippingFee = $get('shipping_fee');
      $subtotal = $orderItems->sum(function ($item) {
          return $item['product_quantity'] * $item['product_price'];
      });
      return $subtotal + $shippingFee;
  }),

TextInput::make('total')
  ->dehydrated(false)
  ->label('Total Price')
  ->default(function ($get) {
      $orderItems = collect($get('orderItems'));
      $shippingFee = $get('shipping_fee');
      $subtotal = $orderItems->sum(function ($item) {
          return $item['product_quantity'] * $item['product_price'];
      });
      return $subtotal + $shippingFee;
  }),

TextInput::make('total')
  ->dehydrated(false)
  ->label('Total Price')
  ->default(function ($get) {
      $orderItems = collect($get('orderItems'));
      $shippingFee = $get('shipping_fee');
      $subtotal = $orderItems->sum(function ($item) {
          return $item['product_quantity'] * $item['product_price'];
      });
      return $subtotal + $shippingFee;
  }),

H

Hiighsky•6/28/23, 11:46 AM

You can just use saveQuietly() instead save() to prevent this endless loop in your observer.

HHiighsky You can just use saveQuietly() instead save() to prevent this endless loop in yo...

C

ChrysippusOP•6/28/23, 11:49 AM

yes, problem already solved but created another problem.
the mthod only works when I updated but when I tried to create my total value is the same of $shippingFee which means $subTotal doesnt have value.

So maybe can resolve both if I can just directly get the total using the TextInput and disregard the Observer

H

Hiighsky•6/28/23, 11:54 AM

My suggestion would be to make this whole thing reactive and calculate the total on the fly

H

Hiighsky•6/28/23, 11:55 AM

https://filamentphp.com/docs/2.x/forms/advanced#reloading-the-form-when-a-field-is-updated

H

Hiighsky•6/28/23, 11:57 AM

So basically you make orderItems and shippingFee reactive and on the total field you listen for changes and calculate everything

C

ChrysippusOP•6/28/23, 12:06 PM

so i'll need do use afterStateUpdated multiple times?

H

Hiighsky•6/28/23, 12:13 PM

Why multiple times? If I got you correct you just need it for your total field

C

ChrysippusOP•6/28/23, 12:16 PM

ohh, I forgot to mention that im using the total outside the repeater

C

ChrysippusOP•6/28/23, 12:26 PM

This is what I got when im using Placeholder but its only Placeholder, I need the TextInput

Placeholder::make('total')
  ->dehydrated(false)
  ->label('Total Price')
  ->content(function ($get) {
      $orderItems = collect($get('orderItems'));
      $shippingFee = $get('shipping_fee');
      $subtotal = $orderItems->sum(function ($item) {
          return $item['product_quantity'] * $item['product_price'];
      });
      return $subtotal + $shippingFee;
  }),

Placeholder::make('total')
  ->dehydrated(false)
  ->label('Total Price')
  ->content(function ($get) {
      $orderItems = collect($get('orderItems'));
      $shippingFee = $get('shipping_fee');
      $subtotal = $orderItems->sum(function ($item) {
          return $item['product_quantity'] * $item['product_price'];
      });
      return $subtotal + $shippingFee;
  }),

Placeholder::make('total')
  ->dehydrated(false)
  ->label('Total Price')
  ->content(function ($get) {
      $orderItems = collect($get('orderItems'));
      $shippingFee = $get('shipping_fee');
      $subtotal = $orderItems->sum(function ($item) {
          return $item['product_quantity'] * $item['product_price'];
      });
      return $subtotal + $shippingFee;
  }),

Placeholder::make('total')
  ->dehydrated(false)
  ->label('Total Price')
  ->content(function ($get) {
      $orderItems = collect($get('orderItems'));
      $shippingFee = $get('shipping_fee');
      $subtotal = $orderItems->sum(function ($item) {
          return $item['product_quantity'] * $item['product_price'];
      });
      return $subtotal + $shippingFee;
  }),

but its not working when I used TextInput instead of Placeholder

H

Hiighsky•6/28/23, 12:47 PM

Can you show me the repeater code?

C

ChrysippusOP•6/28/23, 12:53 PM

this is what I have so far, I was able to get the total for now but only if I set/updated the shipping_fee

repeater.php7.72KB

C

ChrysippusOP•6/28/23, 12:55 PM

H

Hiighsky•6/28/23, 12:57 PM

Yes because you only have afterStateUpdated on the shipping_fee field, you need it for product_quantity and price too

C

ChrysippusOP•6/28/23, 12:58 PM

but when I tried it didnt work I think because total is outside the repeater.

H

Hiighsky•6/28/23, 12:59 PM

$set('../../total', ....

$set('../../total', ....

$set('../../total', ....

$set('../../total', ....

That should work from inside the repeater

D

Dennis Koch•6/28/23, 12:59 PM

Make those fields reactive and use a placeholder field instead of `afterStateUpdated

H

Hiighsky•6/28/23, 1:00 PM

He don't want a placeholder field, he want it as a TextInput

HHiighsky ```php $set('../../total', .... ``` That should work from inside the repeater

C

ChrysippusOP•6/28/23, 1:00 PM

should I still use the orderItem collection? inside repeater?

HHiighsky He don't want a placeholder field, he want it as a TextInput

D

Dennis Koch•6/28/23, 1:01 PM

Sorry, skipped that part

CChrysippus should I still use the orderItem collection? inside repeater?

H

Hiighsky•6/28/23, 1:02 PM

You probably have to

HHiighsky You probably have to

C

ChrysippusOP•6/28/23, 1:23 PM

collection returns null but its working now,
I just need to used $get then do the '../../TextInput_outside_repeater', to get other the necessary values.
now I wont have to use Observer, idk which one is better but atleast for now its working.

Thankyou!

HHiighsky You probably have to

C

ChrysippusOP•6/30/23, 5:33 PM

I didnt notice that It has an issue if I have 2 values on my repeater it will only get the total of the recent value.

Maximum execution time of 60 seconds exceeded

Similar Threads

Similar Threads

Similar Threads