Looping a query bad practice? Good alternative?

This is my end-point atm:

[HttpPost]
public async Task<ActionResult<List<Step>>> PostNewStepInfo(List<Step> steps)
{
    using var connection = new SqlConnection(_config.GetConnectionString("Default"));

    // loop?

    return Ok(steps);
}

[HttpPost]
public async Task<ActionResult<List<Step>>> PostNewStepInfo(List<Step> steps)
{
    using var connection = new SqlConnection(_config.GetConnectionString("Default"));

    // loop?

    return Ok(steps);
}

The data it receives:
(In this case there is only 2, but this can be big, can also reach like 100 objects with each multiple parameters.)

[
  {
    name: 'fortable1',
    parameters: [
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      },
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      }
    ]
  },
  {
    name: 'fortable1',
    parameters: [
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      },
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      },
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      }
    ]
  }
]

[
  {
    name: 'fortable1',
    parameters: [
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      },
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      }
    ]
  },
  {
    name: 'fortable1',
    parameters: [
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      },
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      },
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      }
    ]
  }
]

Now ofcourse I could just loop over each object and then also loop over the parameters and execute a query for each item to the table i want.
This feels like bad practice and would love to hear your opinion on it and maybe a good alternative.
Thanks in advance!

C#•3y ago•

3 replies

Zil

Looping a query bad practice? Good alternative?

This is my end-point atm:

[HttpPost]
public async Task<ActionResult<List<Step>>> PostNewStepInfo(List<Step> steps)
{
    using var connection = new SqlConnection(_config.GetConnectionString("Default"));

    // loop?

    return Ok(steps);
}

[HttpPost]
public async Task<ActionResult<List<Step>>> PostNewStepInfo(List<Step> steps)
{
    using var connection = new SqlConnection(_config.GetConnectionString("Default"));

    // loop?

    return Ok(steps);
}

The data it receives:
(In this case there is only 2, but this can be big, can also reach like 100 objects with each multiple parameters.)

[
  {
    name: 'fortable1',
    parameters: [
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      },
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      }
    ]
  },
  {
    name: 'fortable1',
    parameters: [
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      },
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      },
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      }
    ]
  }
]

[
  {
    name: 'fortable1',
    parameters: [
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      },
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      }
    ]
  },
  {
    name: 'fortable1',
    parameters: [
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      },
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      },
      {
        something: 'fortable2',
        somethingElse: 'fortable2'
      }
    ]
  }
]

Looping a query bad practice? Good alternative?

Similar Threads

Looping a query bad practice? Good alternative?

Similar Threads

Similar Threads

Similar Threads