C#C
C#3y ago
SWEETPONY

✅ How to improve my code?

I have following 2 methods:

static public UISchemaBuilderBase AddField(
        this UISchemaGroupBuilder builder,
        CustomField.CustomField field,
        CultureInfo culture,
        ICustomFieldSetItemParameters parameters = null)
    {
        var valueRequired = parameters != null
            && parameters.ValueRequired;

        switch (field.Type)
        {
            case CustomFieldType.Boolean:
                var booleanTitle = field.Title.GetValue(culture);
                builder.AddBoolean(
                    booleanTitle,
                    booleanTitle,
                    valueRequired);
                break;
        }

        return builder;
    }

    static public UISchemaBuilderBase AddField(
        this UISchemaBuilderBase builder,
        CustomField.CustomField field,
        CultureInfo culture,
        ICustomFieldSetItemParameters parameters = null)
    {
        var valueRequired = parameters != null
            && parameters.ValueRequired;

        switch (field.Type)
        {
        case CustomFieldType.Boolean:
            var booleanTitle = field.Title.GetValue(culture);
            builder.AddBoolean(
                booleanTitle,
                booleanTitle,
                valueRequired);
            break;
        }

        return builder;
    }


the difference is: builder type but another code is the same
Was this page helpful?