Filament•3y ago•

6 replies

Table text filter not showing indicator

I have the following table filter:

Tables\Filters\Filter::make('project')
  ->form([
    Forms\Components\TextInput::make('name')
  ])
  ->query(function ($query, array $data) {
    return $query->when($data['name'], function ($query, $name) {
      return $query->where('name', 'like', '%' . $name . '%');
      });
  })

Tables\Filters\Filter::make('project')
  ->form([
    Forms\Components\TextInput::make('name')
  ])
  ->query(function ($query, array $data) {
    return $query->when($data['name'], function ($query, $name) {
      return $query->where('name', 'like', '%' . $name . '%');
      });
  })

The filter works but no indicator shows in the filter section nor on the filter badge count. I just want to make sure I'm doing this right before opening an issue.

Thanks.

Solution

I looked into it and it's not a bug per se...

Filter

Filter

by default is a checkbox form component which means it either has an

active

active

inactive

inactive

state. Think

is_visible

is_visible

is_featured

is_featured

. The default indicator for this default state is to use the

label()

label()

indicator()

indicator()

. However, if you add a custom form field to this Filter, it then expects it to have

indicateUsing()

indicateUsing()

to show the filter.

I've made a PR to clarify the docs: https://github.com/filamentphp/filament/pull/7889

GitHub

[Docs] Clarify using a custom indicator with filter forms by archil...

Using indicator() to define an active indicator doesn't work with custom filter forms. This adds a clarifying sentance so devs know to use indicateUsing() to show an active indicator.

Jump to solution

Filament•3y ago•

6 replies

Brian Kidd

Table text filter not showing indicator

I have the following table filter:

Tables\Filters\Filter::make('project')
  ->form([
    Forms\Components\TextInput::make('name')
  ])
  ->query(function ($query, array $data) {
    return $query->when($data['name'], function ($query, $name) {
      return $query->where('name', 'like', '%' . $name . '%');
      });
  })

Tables\Filters\Filter::make('project')
  ->form([
    Forms\Components\TextInput::make('name')
  ])
  ->query(function ($query, array $data) {
    return $query->when($data['name'], function ($query, $name) {
      return $query->where('name', 'like', '%' . $name . '%');
      });
  })

The filter works but no indicator shows in the filter section nor on the filter badge count. I just want to make sure I'm doing this right before opening an issue.

Thanks.

Solution

I looked into it and it's not a bug per se...

Filter

Filter

by default is a checkbox form component which means it either has an

active

active

inactive

inactive

state. Think

is_visible

is_visible

is_featured

is_featured

. The default indicator for this default state is to use the

label()

label()

indicator()

indicator()

. However, if you add a custom form field to this Filter, it then expects it to have

indicateUsing()

indicateUsing()

to show the filter.

I've made a PR to clarify the docs: https://github.com/filamentphp/filament/pull/7889

GitHub

[Docs] Clarify using a custom indicator with filter forms by archil...

Using indicator() to define an active indicator doesn't work with custom filter forms. This adds a clarifying sentance so devs know to use indicateUsing() to show an active indicator.

Jump to solution

Table text filter not showing indicator

Table text filter not showing indicator

Similar Threads

Similar Threads

Similar Threads