11 replies

Mechanism for Indicating Discriminator in Struct Property

Is there a good mechanism for indicating that a struct property is meant to be a discriminator? Currently when a schema fails to parse with a union I get errors like this:

   ├─ union member
   │  └─ ["_tag"]
   │     └─ Expected "TypeA", actual "TypeC"
   ├─ union member
   │  └─ ["_tag"]
   │     └─ Expected "TypeB", actual "TypeC"
   ├─ union member
   │  └─ ["someTypeCProp"]
   │     └─ Expected string, actual object.

   ├─ union member
   │  └─ ["_tag"]
   │     └─ Expected "TypeA", actual "TypeC"
   ├─ union member
   │  └─ ["_tag"]
   │     └─ Expected "TypeB", actual "TypeC"
   ├─ union member
   │  └─ ["someTypeCProp"]
   │     └─ Expected string, actual object.

Clearly this this is a

TypeC

TypeC

that has some /other/ error, but the errors about other types make the error reporting confusing.
Ideally I would see something more like:

   ├─ Discriminated union member with property { "_tag": "TypeC" }
   │  └─ ["someTypeCProp"]
   │     └─ Expected string, actual object.

   ├─ Discriminated union member with property { "_tag": "TypeC" }
   │  └─ ["someTypeCProp"]
   │     └─ Expected string, actual object.

Effect Community•3y ago•

11 replies

spaethnl

Mechanism for Indicating Discriminator in Struct Property

Is there a good mechanism for indicating that a struct property is meant to be a discriminator? Currently when a schema fails to parse with a union I get errors like this:

   ├─ union member
   │  └─ ["_tag"]
   │     └─ Expected "TypeA", actual "TypeC"
   ├─ union member
   │  └─ ["_tag"]
   │     └─ Expected "TypeB", actual "TypeC"
   ├─ union member
   │  └─ ["someTypeCProp"]
   │     └─ Expected string, actual object.

   ├─ union member
   │  └─ ["_tag"]
   │     └─ Expected "TypeA", actual "TypeC"
   ├─ union member
   │  └─ ["_tag"]
   │     └─ Expected "TypeB", actual "TypeC"
   ├─ union member
   │  └─ ["someTypeCProp"]
   │     └─ Expected string, actual object.

Clearly this this is a

TypeC

TypeC

that has some /other/ error, but the errors about other types make the error reporting confusing.
Ideally I would see something more like:

   ├─ Discriminated union member with property { "_tag": "TypeC" }
   │  └─ ["someTypeCProp"]
   │     └─ Expected string, actual object.

   ├─ Discriminated union member with property { "_tag": "TypeC" }
   │  └─ ["someTypeCProp"]
   │     └─ Expected string, actual object.

Mechanism for Indicating Discriminator in Struct Property

Similar Threads

Mechanism for Indicating Discriminator in Struct Property

Similar Threads

Similar Threads

Similar Threads