Should the language server warn about this case?

Consider the following code:

fn f() -> Int:
  <body>

fn f() -> Int:
  <body>

Mojo language server doesn't produce a type error when body doesn't contain a

return

return

. There are cases where this makes sense, like when

<body>

<body>

contains only

pass

pass

...

...

. However, for the majority of cases, this clearly won't type check. So, I'm not sure if it's a bug or intended behaviour.

FYI, Python language server like

pyright

pyright

produces the following error message:

def f() -> int:
#          ^^^ Function with declared return type "int" must return value on all code paths
  a = 1

def f() -> int:
#          ^^^ Function with declared return type "int" must return value on all code paths
  a = 1

Modular•3y ago•

12 replies

sora

Should the language server warn about this case?

Consider the following code:

fn f() -> Int:
  <body>

fn f() -> Int:
  <body>

Mojo language server doesn't produce a type error when body doesn't contain a

return

return

. There are cases where this makes sense, like when

<body>

<body>

contains only

pass

pass

...

...

. However, for the majority of cases, this clearly won't type check. So, I'm not sure if it's a bug or intended behaviour.

FYI, Python language server like

pyright

pyright

produces the following error message:

def f() -> int:
#          ^^^ Function with declared return type "int" must return value on all code paths
  a = 1

def f() -> int:
#          ^^^ Function with declared return type "int" must return value on all code paths
  a = 1

Should the language server warn about this case?

Similar Threads

Should the language server warn about this case?

Similar Threads

Similar Threads

Similar Threads