Broken query when parametized query is undefined
Postgres dialect generates broken query when one of the parametized query is undefined
generates
generates
Yhttps://node-postgres.com/features/queries#parameterized-query
node-pg convert both null and undefined to null
node-pg convert both null and undefined to null
AThis is not how drizzle treats undefined
AIn Drizzle, undefined and null have very different meanings
AFor this you can just do:
YNo worries, just checking if there is any other way to do it more elegantly rather than casting to null or conditionally checking everytime
YDo you have more info on how drizzle treats undefined and null very differently?
Aundefined is ignored, while null is an actual valid value that could be inserted/selected in a database
AFor example, if you have column with a default value, say
createdAtbut if you pass undefined, then it will be ignored and the default value will be inserted to the db
YI get it that undefined is converted to
default in ORM queries, but when using sql`` templating, is undefined ignored for any good reason? Sorry if im missing somethingYboth node-pg (https://node-postgres.com/features/queries#parameterized-query) and postgres.js (https://github.com/porsager/postgres#transform-undefined-values) allows transformation of undefined values in parametized query while drizzle totally omit undefined value in params
ADrizzle also actively ignores undefined in
selectselectYou could do
select * from users where id = ${userId}${deletedUser ? ' and deleted = true' : undefined};ADo you know if those drivers have patterns like this?
YI only used node-pg, but we have to do query and params separatedly
AIn any case, if you think this would be a good feature to have, please add an issue in the GH repo
YI dont think this works in drizzle
YThis works
select * from users where id = ${userId}${deletedUser ? sql.raw(' and deleted = true') : undefined}; since we cannot parametized the 2ndAYep, but you get the idea
YYeah it makes sense to ignore undefined if dynamic filters are widely used
YCasting to null would cause too many troubles
AActually, now that I think about it, the query builders internally rely on this to build the query
YModifying undefined at this point in time is a huge breaking change I supposed
YWould be cool to have something that can transform undefined to null like in postgres.js, maybe at sql templating level instead of driver level, something like inlineParams?
AJust to avoid doing
undefined ?? null? IDKYJust to avoid accidentally breaking queries that uses undefined, and for people migrating from other drivers where undefined just works as params.
YThanks for the help 
