How to work better with records

Joreyk ( IXLLEGACYIXL ) · 2024-01-13T15:06:47.976Z

https://gist.github.com/IXLLEGACYIXL/e3c5575656de0bebf314096699e9d42c I have this and want the modified item after breakthrough is applied, but i dont want to modify the original item but it seems like this shouldnt be the way to work with records... can i simplify that syntax?

P

Pobiega•1/13/24, 3:10 PM

your

Apply

Apply

Apply

Apply method should return the new record instance

P

Pobiega•1/13/24, 3:10 PM

so it can't be a void

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:10 PM

yes

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:10 PM

it was more about the changing of the record itself

P

Pobiega•1/13/24, 3:11 PM

you don't change records. you can't without doing some quite evil stuff

P

Pobiega•1/13/24, 3:11 PM

also, why are you using full syntax instead of record syntax?

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:11 PM

like line 10-13 should this "be the way" its intended to be?

PPobiega also, why are you using full syntax instead of record syntax?

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:12 PM

thats the question that i wanted to ask

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:12 PM

how to write it in better syntax

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:12 PM

whats the record syntax?

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:13 PM

or how could i write the lines i have "better" in a better syntax

P

Pobiega•1/13/24, 3:13 PM

internal record ComboDice(int Count, int Sides, int Fix)
{
    public virtual int Roll()
    {
        int total = 0;
        for (var i = 0; i < Count; i++)
        {
            total += IDice.Random.Next(1, Sides + 1);
        }
        return total + Fix;
    }
}

internal record ComboDice(int Count, int Sides, int Fix)
{
    public virtual int Roll()
    {
        int total = 0;
        for (var i = 0; i < Count; i++)
        {
            total += IDice.Random.Next(1, Sides + 1);
        }
        return total + Fix;
    }
}

internal record ComboDice(int Count, int Sides, int Fix)
{
    public virtual int Roll()
    {
        int total = 0;
        for (var i = 0; i < Count; i++)
        {
            total += IDice.Random.Next(1, Sides + 1);
        }
        return total + Fix;
    }
}

internal record ComboDice(int Count, int Sides, int Fix)
{
    public virtual int Roll()
    {
        int total = 0;
        for (var i = 0; i < Count; i++)
        {
            total += IDice.Random.Next(1, Sides + 1);
        }
        return total + Fix;
    }
}

P

Pobiega•1/13/24, 3:13 PM

thats how you declare a record.

P

Pobiega•1/13/24, 3:14 PM

if you're going to manually create the props, then why bother with records in the first place?

PPobiega ```cs internal record ComboDice(int Count, int Sides, int Fix) { public virt...

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:14 PM

the reason i dont have it this way is that the engine cant handle it

P

Pobiega•1/13/24, 3:14 PM

I don't really understand what you are trying to do, because what you have right now does not work

P

Pobiega•1/13/24, 3:15 PM

internal record class Breakthrough : ComboDice
{
    public void Apply(Character target, Character source, Item targetItem, Item sourceItem)
    {
        var x = targetItem with {
            Base = targetItem.Base with {
                Fix = targetItem.Base.Fix - Roll()
            }
        };
    }
}

internal record class Breakthrough : ComboDice
{
    public void Apply(Character target, Character source, Item targetItem, Item sourceItem)
    {
        var x = targetItem with {
            Base = targetItem.Base with {
                Fix = targetItem.Base.Fix - Roll()
            }
        };
    }
}

internal record class Breakthrough : ComboDice
{
    public void Apply(Character target, Character source, Item targetItem, Item sourceItem)
    {
        var x = targetItem with {
            Base = targetItem.Base with {
                Fix = targetItem.Base.Fix - Roll()
            }
        };
    }
}

internal record class Breakthrough : ComboDice
{
    public void Apply(Character target, Character source, Item targetItem, Item sourceItem)
    {
        var x = targetItem with {
            Base = targetItem.Base with {
                Fix = targetItem.Base.Fix - Roll()
            }
        };
    }
}

this does absolutely nothing

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:15 PM

imagine it returns targetitem XD

P

Pobiega•1/13/24, 3:15 PM

but why is this its own class?

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:15 PM

how do you mean?

P

Pobiega•1/13/24, 3:15 PM

its just a method. so add it as an extension method, or a normal method

P

Pobiega•1/13/24, 3:16 PM

Breakthrough

Breakthrough

Breakthrough

Breakthrough doesn't add or change anything in

ComboDice

ComboDice

ComboDice

ComboDice

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:17 PM

because i want a List of "buffs" with for example breakthrough to reduce armor
and imagine that i have

return targetItem....

return targetItem....

return targetItem....

return targetItem....

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:18 PM

so i have the original one and a "modified" version

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:20 PM

thats an example armor how it should look like in yaml

Armor :
    Base : { Rolls : 4 , Side : 8 FIx: 12 }
    Buffs:
        - BreakThrough : { Rolls : 0 , Sides : 0 Fix: 4 }
        - ArmorIncrease : { Rolls : 1 , Sides : 6 Fix: 0 }

Armor :
    Base : { Rolls : 4 , Side : 8 FIx: 12 }
    Buffs:
        - BreakThrough : { Rolls : 0 , Sides : 0 Fix: 4 }
        - ArmorIncrease : { Rolls : 1 , Sides : 6 Fix: 0 }

Armor :
    Base : { Rolls : 4 , Side : 8 FIx: 12 }
    Buffs:
        - BreakThrough : { Rolls : 0 , Sides : 0 Fix: 4 }
        - ArmorIncrease : { Rolls : 1 , Sides : 6 Fix: 0 }

Armor :
    Base : { Rolls : 4 , Side : 8 FIx: 12 }
    Buffs:
        - BreakThrough : { Rolls : 0 , Sides : 0 Fix: 4 }
        - ArmorIncrease : { Rolls : 1 , Sides : 6 Fix: 0 }

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:20 PM

breakthrough reduces armor and armorincrease increases it
but i dont want to modify "the original armors base" as i apply the buffs in each combat

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:21 PM

thats why records as they are good for "keeping the original" and getting a copy that i can modify with the buffs

P

Pobiega•1/13/24, 3:23 PM

okay, sure

P

Pobiega•1/13/24, 3:24 PM

you're gonna have some issues with how the code is written thou.

public ComboDice Base { get; init; } = new ComboDice();

public ComboDice Base { get; init; } = new ComboDice();

public ComboDice Base { get; init; } = new ComboDice();

public ComboDice Base { get; init; } = new ComboDice(); for example

P

Pobiega•1/13/24, 3:24 PM

that

new ComboDice

new ComboDice

new ComboDice

new ComboDice does nothing, if

Item

Item

Item

Item is intended to be deserialized

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:25 PM

oh

P

Pobiega•1/13/24, 3:25 PM

in general, records without constructors are not going to work very well here

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:26 PM

what would you advise for "modification" and keeping the original

P

Pobiega•1/13/24, 3:26 PM

im not sure about yaml deserializers specifically, but the json ones create the object (either via a parameterless ctor or the "best" ctor match) then use reflection to access the property setters

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:27 PM

we have yamlsharp from 2008 and my yaml serilaizer that i wrote cant handle it either

P

Pobiega•1/13/24, 3:27 PM

how would the API look for this?

P

Pobiega•1/13/24, 3:27 PM

ie, how do you "activate" the buffs?

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:27 PM

how do you mean?

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:29 PM

if i get the collision event from the weapon,
i take the source ( attacking wepaon and character ) and calculate it against the targets armor and character
now all buffs get applied and at the end its just damage - armor

armor would be modified if the weapon has breakthrough so in the last step it would resist less

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:29 PM

thats the plan to do

P

Pobiega•1/13/24, 3:39 PM

but.. your armor value isnt fixed. its not part of the record

P

Pobiega•1/13/24, 3:39 PM

its made by calling the

Roll

Roll

Roll

Roll method

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:47 PM

if my current armor has this as base

{ Rolls : 4 , Side : 8 FIx: 12 }

{ Rolls : 4 , Side : 8 FIx: 12 }

{ Rolls : 4 , Side : 8 FIx: 12 }

{ Rolls : 4 , Side : 8 FIx: 12 } then the new record will have

{ Rolls : 4 , Side : 8 FIx: 8 }

{ Rolls : 4 , Side : 8 FIx: 8 }

{ Rolls : 4 , Side : 8 FIx: 8 }

{ Rolls : 4 , Side : 8 FIx: 8 }
with a breakthrough of a roll of 4
if i would calculate now the armors value it would be 4 dices a 8 sides + 8

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:47 PM

so its reduced

P

Pobiega•1/13/24, 3:48 PM

Ah I see, so they modify the base roll

P

Pobiega•1/13/24, 3:48 PM

they dont make their own rolls

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:49 PM

yes

P

Pobiega•1/13/24, 3:49 PM

I see.

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:49 PM

a 1 roll of 6 sides for armor increase with a result of 3 would increase the armors fix value by 3

J

Joreyk ( IXLLEGACYIXL )OP•1/13/24, 3:50 PM

after all modifications, the armor rolls with the end result

How to work better with records

Similar Threads

Similar Threads

Similar Threads