C#•2y ago

Thread safe moving value between two objects

I have problem. Consider following class:

public class Foo {
  public int Amount { get; set; }
  public int MaxAmount { get; set; }
}

var foo1 = new Foo{ Amount = 75, MaxAmount = 100 };
var foo2 = new Foo{ Amount = 75, MaxAmount = 100 };

public class Foo {
  public int Amount { get; set; }
  public int MaxAmount { get; set; }
}

var foo1 = new Foo{ Amount = 75, MaxAmount = 100 };
var foo2 = new Foo{ Amount = 75, MaxAmount = 100 };

what i want to do is to thread safe move amount from one "Foo" object, to another that it won't overflow above "MaxAmount".

foo1.Transfer(foo2, 25); // Ok, foo2 now is full, foo1 have amount 50, foo2 amount 100
foo1.Transfer(foo2, 25); // Throw overflow exception, because 100 + 25 > 125
foo1.Transfer(foo2, 100); // Throw other exception, because now foo1 have Amount = 50

foo1.Transfer(foo2, 25); // Ok, foo2 now is full, foo1 have amount 50, foo2 amount 100
foo1.Transfer(foo2, 25); // Throw overflow exception, because 100 + 25 > 125
foo1.Transfer(foo2, 100); // Throw other exception, because now foo1 have Amount = 50

A bif more context: It is for game for items stacking purpose, it is used server side so two clients at once may attempt to move items.

Please focus on thread safety aspect

canton7•2/11/24, 12:53 PM

... locks?

canton7•2/11/24, 12:54 PM

It's unclear what your problem is. Your post doesn't actually contain a question.

CrosRoad95OP•2/11/24, 12:54 PM

I know that i can use locks, but how?

do you know nice pattern?

canton7•2/11/24, 12:55 PM

CrosRoad95OP•2/11/24, 12:56 PM

Right now i endup with lock spaghetti, but i know someone know nice solution

CrosRoad95OP•2/11/24, 12:57 PM

Had idea to do inventory level lock for items changing purpose

CrosRoad95OP•2/11/24, 12:57 PM

But, items can be stacked across inventories so i endup with same issue just level highier

canton7•2/11/24, 12:59 PM

I think you've over-simplified your question? Your actual problem isn't really related to your post

Buddy•2/11/24, 1:01 PM

Either manual locks or the use of Interlocked class

CrosRoad95OP•2/11/24, 1:03 PM

Had idea to introduce some helper method like that i can lock object from outside

CrosRoad95OP•2/11/24, 1:04 PM

CrosRoad95OP•2/11/24, 1:06 PM

What do you think about pattern like this ^

canton7•2/11/24, 1:08 PM

Prone to deadlocks, if someone tries to acquire those same locks in the opposite order

canton7•2/11/24, 1:09 PM

Why can't you have one lock for everything? You're never going to be holding it for more than a couple of instructions, so it'll probably never be contended

dance?•2/11/24, 2:58 PM

another pattern could be a queue of actions of players (so that they are serialized)
but it depends on what game is this (like 3d fps, 2d action, textual...)

CrosRoad95OP•2/11/24, 3:17 PM

Maybe

hugeman•2/13/24, 9:40 PM

Something like that seems like it should only ever really be done on a single or "safe" thread, not just any random thread

hugeman•2/13/24, 9:41 PM

So if you can, you could invoke your game thread's dispatcher or scheduler (or whatever the equivalent is for what you're using) and use it to invoke the modification on that thread

hugeman•2/13/24, 9:42 PM

But if you're saying a client wants to modify that value, then i'd probably just implement a data packet system where client sends something like AddFooPacket

hugeman•2/13/24, 9:42 PM

And process those packets on the main/server/game thread

hugeman•2/13/24, 9:47 PM

If it's a 3d game for like an inventory/chest management system then it might not be that straight forward, it could be something like PlayerClickGuiPacket, then maybe you invoke an interface method e.g. or something along those lines (and you'd need some way of serialising/deserialising Foo ofc)

hugeman•2/13/24, 9:50 PM

I dunno what that concept is called but the idea is the client and server sync their data via packets (by updating server or being notified of server changes). Not sure if this is what you're going for