Sort by related hasOno of Many model field Bug

Hey guys. I have some problem with relations. Tried to sort by field which is accessible via ->hasMany()->one()->ofMany()->some_field
For example I have 2 models - Channel and ChannelPost
A Channel has many ChannelPost.
A ChannelPost have

views

views

field with count of views.
Now in Channel model I have this relations:

/**
     * @return HasMany
     */
    public function posts(): HasMany
    {
        return $this->hasMany(ChannelPost::class);
    }

    /**
     * @return HasOne
     */
    public function lastPost(): HasOne
    {
        return $this->posts()->one()->ofMany('post_id', 'max');
    }

/**
     * @return HasMany
     */
    public function posts(): HasMany
    {
        return $this->hasMany(ChannelPost::class);
    }

    /**
     * @return HasOne
     */
    public function lastPost(): HasOne
    {
        return $this->posts()->one()->ofMany('post_id', 'max');
    }

In Filament table I use

Tables\Columns\TextColumn::make('lastPost.views')

Tables\Columns\TextColumn::make('lastPost.views')

When I tried to sort by this field - it was sorted randomly.

So I tried to find the problem and did some debugging.

Here we are receiving an empty model for Post - https://github.com/filamentphp/tables/blob/3.x/src/Columns/Concerns/InteractsWithTableQuery.php#L144
And then https://github.com/filamentphp/support/blob/3.x/src/Concerns/HasCellState.php#L172 - here we are getting query with channel_id = null (because empty model has id = null)

And because this it generates looong SQL order by clause: with

channel_posts

channel_posts

channel_id

channel_id

is null
```

GitHub

support/src/Concerns/HasCellState.php at 3.x · filamentphp/support

[READ ONLY] Subtree split of Filament's Support package (see filamentphp/filament) - filamentphp/support

GitHub

tables/src/Columns/Concerns/InteractsWithTableQuery.php at 3.x · fi...

[READ ONLY] Subtree split of the Filament Table Builder (see filamentphp/filament) - filamentphp/tables

Sort by related hasOno of Many model field Bug

views

views

field with count of views.
Now in Channel model I have this relations:

/**
     * @return HasMany
     */
    public function posts(): HasMany
    {
        return $this->hasMany(ChannelPost::class);
    }

    /**
     * @return HasOne
     */
    public function lastPost(): HasOne
    {
        return $this->posts()->one()->ofMany('post_id', 'max');
    }

/**
     * @return HasMany
     */
    public function posts(): HasMany
    {
        return $this->hasMany(ChannelPost::class);
    }

    /**
     * @return HasOne
     */
    public function lastPost(): HasOne
    {
        return $this->posts()->one()->ofMany('post_id', 'max');
    }

In Filament table I use

Tables\Columns\TextColumn::make('lastPost.views')

Tables\Columns\TextColumn::make('lastPost.views')

channel_posts

channel_posts

channel_id

channel_id

is null
```

GitHub

support/src/Concerns/HasCellState.php at 3.x · filamentphp/support

[READ ONLY] Subtree split of Filament's Support package (see filamentphp/filament) - filamentphp/support

GitHub

tables/src/Columns/Concerns/InteractsWithTableQuery.php at 3.x · fi...

[READ ONLY] Subtree split of the Filament Table Builder (see filamentphp/filament) - filamentphp/tables

Sort by related hasOno of Many model field Bug

Sort by related hasOno of Many model field Bug

Similar Threads

Similar Threads

Similar Threads