Seeking Feedback on Service & Layer Implementation Practices

export interface IOrderRepository {
  byId(
    shopId: ShopId,
    orderId: OrderId
  ): Effect.Effect<Order, OrderNotFoundError | RepositoryConnectionError>;
}

export const IOrderRepository =
  Context.GenericTag<IOrderRepository>("IOrderRepository");

export const InMemoryStubOrderRepository = (): IOrderRepository & {
  feedWith: (initialOrders: Order[]) => void;
} => {
  let inMemoryStubOrders: Order[] = [];

  return {
    byId(shopId, orderId) {
      const order = inMemoryStubOrders.find((_order) => _order.id === orderId);

      if (order) {
        return Effect.succeed(order);
      } else {
        return Effect.fail(new OrderNotFoundError({ shopId, orderId }));
      }
    },
    feedWith: (orders: Order[]) => {
      inMemoryStubOrders = [...orders];
    },
  };
};

export type InMemoryStubOrderRepository = IOrderRepository & {
  feedWith: (initialOrders: Order[]) => void;
};

export const GadgetApiOrderRepository = (
  gadgetApi: Client
): IOrderRepository => ({
  byId: (shopId, orderId) =>
    Effect.tryPromise({
      try: async () => {
        const record = await gadgetApi.shopifyOrder.maybeFindFirst({
          filter: {
            AND: [
              {
                shopId: { equals: shopId },
              },
              {
                id: { equals: orderId },
              },
            ],
          },
          select: {
            id: true,
            currency: true,
            totalPrice: true,
            // ...
          },
        });

        if (!record) {
          throw new OrderNotFoundError({ shopId, orderId });
        }

        const order = createOrder({
          id: record.id,
          currency: decodeUnknownISO4217CurrencyCode(record.currency),
          totalPrice: decodeUnknownNonNegativeMonetaryAmount(record.totalPrice),
          // ...
        });

        return order;
      },
      catch: (unknown) =>
        new RepositoryConnectionError({
          unknown,
          metadata: { shopId, orderId },
        }),
    }),
});