C#•2y ago

✅ JSON + ASP.NET attribute usage

Hi! My JSON class looks like this:

public class Car
{
  [JsonConstructor]
  public Car(string brand)
  {
    ArgumentException.ThrowIfNullOrWhiteSpace(brand);
    Brand = brand;
  }

  [JsonProperty("brand")]
  public string Brand { get; }
}

public class Car
{
  [JsonConstructor]
  public Car(string brand)
  {
    ArgumentException.ThrowIfNullOrWhiteSpace(brand);
    Brand = brand;
  }

  [JsonProperty("brand")]
  public string Brand { get; }
}

public class Car
{
  [JsonConstructor]
  public Car(string brand)
  {
    ArgumentException.ThrowIfNullOrWhiteSpace(brand);
    Brand = brand;
  }

  [JsonProperty("brand")]
  public string Brand { get; }
}

public class Car
{
  [JsonConstructor]
  public Car(string brand)
  {
    ArgumentException.ThrowIfNullOrWhiteSpace(brand);
    Brand = brand;
  }

  [JsonProperty("brand")]
  public string Brand { get; }
}

It works just fine.

An issue occurs whenever I got code like this:

[ApiController]
public class CarsController : ControllerBase
{
  [HttpPost]
  public IActionResult CreateCar([FromBody] Car car])
  {
    // [...]
  }
}

[ApiController]
public class CarsController : ControllerBase
{
  [HttpPost]
  public IActionResult CreateCar([FromBody] Car car])
  {
    // [...]
  }
}

[ApiController]
public class CarsController : ControllerBase
{
  [HttpPost]
  public IActionResult CreateCar([FromBody] Car car])
  {
    // [...]
  }
}

[ApiController]
public class CarsController : ControllerBase
{
  [HttpPost]
  public IActionResult CreateCar([FromBody] Car car])
  {
    // [...]
  }
}

Binding the model fails now (because the constructor of

Car

Car

Car

Car is throwing an exception) which results in an HTTP status code 500 (Internal Server Error) instead of my desired 400 (Bad Request).

My current idea (I don't like it): Create a copy of that class without the JSON attributes but with DataAnnotations.
Do you have any other ideas?

Thanks in advance!

Angius•5/15/24, 11:42 PM

You should be using model validation here

Angius•5/15/24, 11:43 PM

Not throwing exceptions from the ctor

qqdevOP•5/17/24, 11:06 AM

Thanks, I ended up with creating an adjusted copy of that class

qqdevOP•5/17/24, 11:07 AM

Throwing in the ctor is no good (as you pointed out) although it makes sense in our case

✅ JSON + ASP.NET attribute usage

Similar Threads

Similar Threads

Similar Threads