C#•2y ago

Incorrect syntax near the keyword 'NOT'. error during ef database update

I've been following a Asp.net core web api tutorial https://www.youtube.com/watch?v=SIQhe-yt3mA&t=436s and I keep getting this error when trying to do the dotnet ef database update command. I've tried lots of things, but I'm a bit stumped here Error Number:156,State:1,Class:15 Incorrect syntax near the keyword 'NOT'.

Teddy Smith

YouTube

ASP.NET Core Web API .NET 8 2024 - 3. Entity Framework

ASP.NET Core Web API .NET 8 2024 - 3. Entity Framework Github: https://github.com/teddysmithdev/FinShark SQL Server Connection String Template (WINDOWS):
"Data Source={PCNAME}\SQLEXPRESS;Initial Catalog={DATABASENAME};Integrated Security=True;Connect Timeout=30;Encrypt=False;TrustServerCertificate=False;ApplicationIntent=ReadWrite;MultiSub...

126 Replies

Pobiega•2y ago

you'll need to show your code

RjOP•2y ago

I did on my first post :( it was on the code review what particular files?

Pobiega•2y ago

just upload it all to github tbh, much easier for everyone

RjOP•2y ago

okay

Pobiega•2y ago

what database engine are you using? looks like mssql based on what connector its using but what version?

RjOP•2y ago

ssms

Pobiega•2y ago

your error is that the SQL server responded that the query is invalid, which is weird since ... "NOT NULL" in a create table is definately valid SSMS isnt a database, its a database client

RjOP•2y ago

AHHHH sqlexpress

Pobiega•2y ago

right

RjOP•2y ago

um hear me out

Pobiega•2y ago

try running that query manually in SSMS, just to see if it works?

RjOP•2y ago

Im gonna need to download the github thing okay

Pobiega•2y ago

can do it in a transaction, if you dont want it saved you dont need to download the github thing - VS has built in git and you dont need their client in fact, I think their client is trash

RjOP•2y ago

yea the guy was using vscode im trying not to kms rn

Pobiega•2y ago

vscode also has built in git 🙂

RjOP•2y ago

WHERE IS IT I founmd ioit

Pobiega•2y ago

BEGIN TRAN;
CREATE TABLE ... -- your code here, cant copypaste from an image...

ROLLBACK TRAN;

BEGIN TRAN;
CREATE TABLE ... -- your code here, cant copypaste from an image...

ROLLBACK TRAN;

RjOP•2y ago

https://github.com/Yeeeef/WebApi um

Pobiega•2y ago

404

RjOP•2y ago

can u see a private one orr...

Pobiega•2y ago

no, thats what private means :p

RjOP•2y ago

im so sorry man this site is too godamn big

Pobiega•2y ago

ignore git for now then, run the query

RjOP•2y ago

it's the nots maybe actually

Pobiega•2y ago

oh wait I see the error

RjOP•2y ago

Pobiega•2y ago

decimal (18,2

RjOP•2y ago

omg

Pobiega•2y ago

.. did you write the query yourself?

RjOP•2y ago

Pobiega•2y ago

I find it unlikely that EF would generate an invalid query

RjOP•2y ago

model idk

Pobiega•2y ago

look at your typenames wtf >_>

RjOP•2y ago

LMFAOOO no it wasn't doing it itself i was having to do it I was going to i promise

Pobiega•2y ago

repeat after me: I will use IEntityTypeConfiguration<T> in the future, not the silly attributes

RjOP•2y ago

WHAT IN THE FUCJ what

Pobiega•2y ago

configuring your models with [Bla] is not recommended

RjOP•2y ago

woah

Pobiega•2y ago

only a very small subset of configuration can be done with attributes and also lead to shit like this

RjOP•2y ago

yea it was too easy :\

Pobiega•2y ago

explicit IEntityTypeConfigurations are better. anyways, easy fix - fix your attributes, remove the migration and snapshot, generate a new migration

RjOP•2y ago

bro I might cry

RjOP•2y ago

im not even on a chatbot

RjOP•2y ago

why

Pobiega•2y ago

... what

RjOP•2y ago

idk

Pobiega•2y ago

why are people alergic to the documentation

RjOP•2y ago

god I looked

Pobiega•2y ago

RjOP•2y ago

it was words and more documentation

Pobiega•2y ago

top 2 results

RjOP•2y ago

yes I have it open 😭

Pobiega•2y ago

https://learn.microsoft.com/en-us/ef/core/modeling/#grouping-configuration so read this?

RjOP•2y ago

yea I was like where is that exactly like in the model?

Pobiega•2y ago

no a separate class

public class BlogEntityTypeConfiguration : IEntityTypeConfiguration<Blog>
{
    public void Configure(EntityTypeBuilder<Blog> builder)
    {
        builder
            .Property(b => b.Url)
            .IsRequired();
    }
}

public class BlogEntityTypeConfiguration : IEntityTypeConfiguration<Blog>
{
    public void Configure(EntityTypeBuilder<Blog> builder)
    {
        builder
            .Property(b => b.Url)
            .IsRequired();
    }
}

this class configures EF for Blog

RjOP•2y ago

so can i put this in data or is this a model thing

Pobiega•2y ago

its an EF thing. it should live near your context.

RjOP•2y ago

my current files

Pobiega•2y ago

if your Context is at Project.Data, I'd put it in Project.Data.Configurations

RjOP•2y ago

okay

Pobiega•2y ago

then do modelBuilder.ApplyConfigurationsFromAssembly(typeof(BlogEntityTypeConfiguration).Assembly); in your contexts OnModelConfiguring to load all the configs you dont need the attribute to associate the model with the config bit of a rant thou, why are young coders so against reading docs

RjOP•2y ago

lmfdaoooo idk it's more because it's all abstract things

Pobiega•2y ago

sure, documentation is long and wordy, but thats cause its not a direct answer to a single question, its describing an entire section or feature

RjOP•2y ago

and I'm like sitting here rn thinking god I hate following tutorials okay I name this FInshark Configurations orsomething like FinsharkConfigurations and then or stock

Pobiega•2y ago

generally you make one of these for each model

RjOP•2y ago

yea stockentitytypeconfiguration okay

Pobiega•2y ago

so the config for Stockwould be internal class StockConfiguration : IEntityTypeConfigration<Stock> eh, maybe make it public, doesnt really matter

RjOP•2y ago

why does my vscode hate me

RjOP•2y ago

it says is a reference missing HELP ME VSCODE HELP ME THEN GIVE ME THE REFERENCE PAL 😭

RjOP•2y ago

okay I was being an asshole it worked except the url thing

Pobiega•2y ago

uuh why is it nested

RjOP•2y ago

dude

RjOP•2y ago

okay

Pobiega•2y ago

cursed indentation :p but sure

RjOP•2y ago

is the url thing fine or am i dead

Pobiega•2y ago

do you have a property called Uri?

RjOP•2y ago

not that I've been using this far in my minmdddd I can go check nope

Pobiega•2y ago

based on the model you showed before, you'd configure the properties for Profit and Purchase since you had changed their types

RjOP•2y ago

can I get rid of them :)))

Pobiega•2y ago

wdym? if you dont need to configure them at all, then why have we just wasted 15 min setting up entity configuration?

RjOP•2y ago

eh ykw lets keep going but if the numbers truly were the issue omfg

Pobiega•2y ago

...

RjOP•2y ago

it's for a tutorial man

Pobiega•2y ago

the numbers were not the issue

RjOP•2y ago

oh see

Pobiega•2y ago

the issue was THE MISSING PARENTHESIS

RjOP•2y ago

I can't fix that

Pobiega•2y ago

decimal(18,2 is NOT THE SAME as decimal(18,2)

RjOP•2y ago

I didn't make it

Pobiega•2y ago

"I cant fix that" sure you can

RjOP•2y ago

is fixing it

Pobiega•2y ago

you have the file ON YOUR COMPUTER >_> its literally two characters jesusadxgfhujbsanojfgas

RjOP•2y ago

lmfaooo well long route works idrk how would I fix that tho

Pobiega•2y ago

what are you fucking on about LOOK AT YOUR MODEL

RjOP•2y ago

hm its not

Pobiega•2y ago

RjOP•2y ago

LFMAOOO

Pobiega•2y ago

blind legally blind illegally blind? maybe.

RjOP•2y ago

hm. touche why why did you walk me down that long ass road just to stop me there

Pobiega•2y ago

RjOP•2y ago

we were about to embark on like one piece or smth

Pobiega•2y ago

I pointed it out 30 min ago

RjOP•2y ago

hey

Pobiega•2y ago

but you should not do EF configuration using DataAnnotation attributes

SleepWellPupper•2y ago

this is quite entertaining, keep it up guys

RjOP•2y ago

this is why I fucking hate this discord omg 😭

Pobiega•2y ago

thats why I said use IETC lol?

RjOP•2y ago

im sorry I love you thank you for your help i was laughing my ass off explain this tho so configurations they are like optional right

Pobiega•2y ago

in a way

RjOP•2y ago

my thing will run with the ones from ms unless I change whatever for whatever I need

Pobiega•2y ago

if you dont use configurations in any way, you get the defaults sometimes thats fine sometimes you need to configure stuff

RjOP•2y ago

yeaa :3

Pobiega•2y ago

there are 3 ways to configure an EF entity 1. data annotations - the attributes you are currently using 2. inside the context 3. with dedicated entity type configration classes 3 is the recommended approach

RjOP•2y ago

preach

Pobiega•2y ago

1 is what all shitty youtube tutorials do, because their examples are trivial and would you believe it, in a trivial example, you can often get away with it but for configuring a Many-to-Many relationship, or a two way type conversion, or owned entities, you need to use 2 or 3, and 3 is just "cleaner" since its each model for itself instead of all of them in one blob

RjOP•2y ago

um so question

Pobiega•2y ago

I'm quivering in anticipation

RjOP•2y ago

documentation may serve it's purpose for once in my life tbh

RjOP•2y ago

https://github.com/Yeeeef/WebApi

GitHub

GitHub - Yeeeef/WebApi

Contribute to Yeeeef/WebApi development by creating an account on GitHub.

RjOP•2y ago

got it um okay it's building cool thanks for the help

Gaming

Programming

Incorrect syntax near the keyword 'NOT'. error during ef database update

Did you find this page helpful?