C#•2y ago

How to fix a simple (hopefully) error?

I am doing a leetcode solution, and I have this so far:

public class Solution {
    public int HeightChecker(int[] heights) {
        int[] correctOrder = [];
        int amountWrong = 0;
        foreach(int i in heights) { 
            int iter = i;
            while (iter <= heights.Length){
                iter++;
                if (heights[i] < heights[iter]) {
                    int curr = heights[iter-1];
                   correctOrder[i] = correctOrder[heights[iter-1]];
                   heights[iter] = curr;
                }
            }
        }
        foreach(int i in heights) {
            if(heights[i] != correctOrder[i]){
                amountWrong++;
            }
        }
        return amountWrong;
    }
}

public class Solution {
    public int HeightChecker(int[] heights) {
        int[] correctOrder = [];
        int amountWrong = 0;
        foreach(int i in heights) { 
            int iter = i;
            while (iter <= heights.Length){
                iter++;
                if (heights[i] < heights[iter]) {
                    int curr = heights[iter-1];
                   correctOrder[i] = correctOrder[heights[iter-1]];
                   heights[iter] = curr;
                }
            }
        }
        foreach(int i in heights) {
            if(heights[i] != correctOrder[i]){
                amountWrong++;
            }
        }
        return amountWrong;
    }
}

public class Solution {
    public int HeightChecker(int[] heights) {
        int[] correctOrder = [];
        int amountWrong = 0;
        foreach(int i in heights) { 
            int iter = i;
            while (iter <= heights.Length){
                iter++;
                if (heights[i] < heights[iter]) {
                    int curr = heights[iter-1];
                   correctOrder[i] = correctOrder[heights[iter-1]];
                   heights[iter] = curr;
                }
            }
        }
        foreach(int i in heights) {
            if(heights[i] != correctOrder[i]){
                amountWrong++;
            }
        }
        return amountWrong;
    }
}

public class Solution {
    public int HeightChecker(int[] heights) {
        int[] correctOrder = [];
        int amountWrong = 0;
        foreach(int i in heights) { 
            int iter = i;
            while (iter <= heights.Length){
                iter++;
                if (heights[i] < heights[iter]) {
                    int curr = heights[iter-1];
                   correctOrder[i] = correctOrder[heights[iter-1]];
                   heights[iter] = curr;
                }
            }
        }
        foreach(int i in heights) {
            if(heights[i] != correctOrder[i]){
                amountWrong++;
            }
        }
        return amountWrong;
    }
}

I am getting this error

samisaskinnyqueenOP•6/10/24, 4:10 PM

I'm a beginner so if anything here is bad practice please let me know

Jimmacle•6/10/24, 4:15 PM

index out of range means you tried to access an array element that doesn't exist

Jimmacle•6/10/24, 4:15 PM

valid array indexes are from 0 to 1 less than the length of the array

Jimmacle•6/10/24, 4:16 PM

also, arrays are fixed size so if you're trying to put elements into an empty array it won't work

samisaskinnyqueenOP•6/10/24, 4:16 PM

so how should i do it instead

Jimmacle•6/10/24, 4:17 PM

make the array large enough to hold the data you want to put in it, or use a

List

List

which automatically expands to add items

samisaskinnyqueenOP•6/10/24, 4:18 PM

so would making correctOrder a list fix that error?

Jimmacle•6/10/24, 4:18 PM

if you change to a list and call Add, that would be one solution

Jimmacle•6/10/24, 4:18 PM

or just make the array big enough to hold all the heights like var correctOrder = new int[heights.Length];var correctOrder = new int[heights.Length];

samisaskinnyqueenOP•6/10/24, 4:19 PM

I switched it to a list

samisaskinnyqueenOP•6/10/24, 4:19 PM

looks like a similar if not the same error

samisaskinnyqueenOP•6/10/24, 4:19 PM

Jimmacle•6/10/24, 4:19 PM

and call Addand call Add

Jimmacle•6/10/24, 4:19 PM

you have to do that to put new items in a list

samisaskinnyqueenOP•6/10/24, 4:20 PM

can add put it in a specific spot

Jimmacle•6/10/24, 4:20 PM

you could use InsertInsert for that

samisaskinnyqueenOP•6/10/24, 4:20 PM

Ill try that real quick'

samisaskinnyqueenOP•6/10/24, 4:24 PM

Still the same error

samisaskinnyqueenOP•6/10/24, 4:24 PM

public class Solution {
    public int HeightChecker(int[] heights) {
        List<int> correctOrder = new List<int>();
        int amountWrong = 0;
        foreach(int i in heights) { 
            int iter = i;
            while (iter <= heights.Length){
                iter++;
                if (heights[i] < heights[iter]) {
                    int curr = heights[iter-1];
                   correctOrder.Insert(iter-1, correctOrder[heights[iter-1]]);
                   correctOrder.Insert(iter, curr);
                }
            }
        }
        foreach(int i in heights) {
            if(heights[i] != correctOrder[i]){
                amountWrong++;
            }
        }
        return amountWrong;
    }
}

public class Solution {
    public int HeightChecker(int[] heights) {
        List<int> correctOrder = new List<int>();
        int amountWrong = 0;
        foreach(int i in heights) { 
            int iter = i;
            while (iter <= heights.Length){
                iter++;
                if (heights[i] < heights[iter]) {
                    int curr = heights[iter-1];
                   correctOrder.Insert(iter-1, correctOrder[heights[iter-1]]);
                   correctOrder.Insert(iter, curr);
                }
            }
        }
        foreach(int i in heights) {
            if(heights[i] != correctOrder[i]){
                amountWrong++;
            }
        }
        return amountWrong;
    }
}

Jimmacle•6/10/24, 4:25 PM

correctOrder[heights[iter-1]]correctOrder[heights[iter-1]]

Jimmacle•6/10/24, 4:25 PM

there will not be anything here, the list is empty

samisaskinnyqueenOP•6/10/24, 4:26 PM

should i just make correctOrder the same as heights but in list form in the beginning

samisaskinnyqueenOP•6/10/24, 4:26 PM

is that possible

Jimmacle•6/10/24, 4:27 PM

if your "correct order" is a known fixed size there's no reason to use the list

samisaskinnyqueenOP•6/10/24, 4:28 PM

then why'd you tell me to

Jimmacle•6/10/24, 4:28 PM

it sounds like what you want is How to fix a simple (hopefully) error?

MODiX•6/10/24, 4:28 PM

Jimmacle

or just make the array big enough to hold all the heights like var correctOrder = new int[heights.Length];var correctOrder = new int[heights.Length];

Quoted by

@901546879530172498 from #How to fix a simple (hopefully) error? (click here)

React with ❌ to remove this embed.

•

6/10/24, 4:18 PM

Ssamisaskinnyqueen then why'd you tell me to

Jimmacle•6/10/24, 4:28 PM

i'm giving you multiple options, not the answer

samisaskinnyqueenOP•6/10/24, 4:28 PM

which option is the best then

Jimmacle•6/10/24, 4:28 PM

that's up to you, i have no idea what the actual problem being solved is

Jimmacle•6/10/24, 4:28 PM

i'm just going based off of a code snippet

Jimmacle•6/10/24, 4:29 PM

lists are generally for collections that change size, arrays can be used for collections that are always the same size

samisaskinnyqueenOP•6/10/24, 4:30 PM

so array would make more sense

samisaskinnyqueenOP•6/10/24, 4:30 PM

but i dont understand where i am getting a negative index

Jimmacle•6/10/24, 4:31 PM

foreach(int i in heights)foreach(int i in heights) seems off

Jimmacle•6/10/24, 4:31 PM

this will give you the values in heights, not the indexes

Jimmacle•6/10/24, 4:31 PM

are you sure you don't want a for loop?

samisaskinnyqueenOP•6/10/24, 4:33 PM

i need all the values, then i am sorting them smallest to biggest

samisaskinnyqueenOP•6/10/24, 4:33 PM

then comparing the new sorted array to the old one to see how many are wrong

samisaskinnyqueenOP•6/10/24, 4:34 PM

should i use a for loop?

samisaskinnyqueenOP•6/10/24, 4:37 PM

public class Solution {
    public int HeightChecker(int[] heights) {
        int[] correctOrder= new int[heights.Length];
        int amountWrong = 0;
        foreach(int i in heights) { 
            int iter = i;
            while (iter <= heights.Length){
                iter++;
                if (heights[i] < heights[iter]) {
                    int curr = heights[iter-1];
                   correctOrder[iter-1] = heights[iter-1];
                   correctOrder[iter] = curr;
                }
            }
        }
        foreach(int i in heights) {
            if(heights[i] != correctOrder[i]){
                amountWrong++;
            }
        }
        return amountWrong;
    }
}

public class Solution {
    public int HeightChecker(int[] heights) {
        int[] correctOrder= new int[heights.Length];
        int amountWrong = 0;
        foreach(int i in heights) { 
            int iter = i;
            while (iter <= heights.Length){
                iter++;
                if (heights[i] < heights[iter]) {
                    int curr = heights[iter-1];
                   correctOrder[iter-1] = heights[iter-1];
                   correctOrder[iter] = curr;
                }
            }
        }
        foreach(int i in heights) {
            if(heights[i] != correctOrder[i]){
                amountWrong++;
            }
        }
        return amountWrong;
    }
}

updated code, similar error

Jimmacle•6/10/24, 4:44 PM

if you need the index, use a for loop

Jimmacle•6/10/24, 4:44 PM

your code doesn't make sense because you're using the actual height value as an index into the array

samisaskinnyqueenOP•6/10/24, 4:44 PM

i need the values, no?

Jimmacle•6/10/24, 4:45 PM

ii is not storing an index in your code, it's storing a height

Jimmacle•6/10/24, 4:46 PM

then you're trying to use it as an index into the arrays, which is probably where your bad index is coming from

samisaskinnyqueenOP•6/10/24, 4:46 PM

switched it and im still getting that same error ^

samisaskinnyqueenOP•6/10/24, 4:47 PM

Jimmacle•6/10/24, 4:48 PM

i <= heights.Lengthi <= heights.Length

Jimmacle•6/10/24, 4:48 PM

remember what i said about valid indexes

How to fix a simple (hopefully) error?

Similar Threads

Similar Threads

Similar Threads