7 replies

Event before precondition OR access the command via MessageCommandDenied

Hi all,

I have extended my Command Options to include a property

shouldDeleteOnPost

shouldDeleteOnPost

- which should delete the message once it has been posted.
I'd like to do this in the most universal way possible - I thought using

MessageCommandRun

MessageCommandRun

would have fired before any of the preconditions, but it seems it does not.

When a precondition returns this.error, the code within

MessageCommandRun

MessageCommandRun

does not fire. It fires if the precondition is passed, or does not exist.

I'm not sure if there is an event that will fire before the precondition is run - pass or fail ?
If there is, that's where I would put effectively something like the following

        const drpgOptions = request.command.options as IDrpgCommandOptions;
        if (drpgOptions.deleteAfterPost) request.message.delete();

        const drpgOptions = request.command.options as IDrpgCommandOptions;
        if (drpgOptions.deleteAfterPost) request.message.delete();

To get around this, I thought I would try doing effectively the same out of the

MessageCommandAccepted

MessageCommandAccepted

and

MessageCommandDenied

MessageCommandDenied

events - which would have worked perfectly, until I realised that

MessageCommandDenied

MessageCommandDenied

doesn't appear to have any context of what the command itself actually was.

How can I either...
- Run some event before a precondition, pass or fail (preferred)
- Access the command inside of

MessageCommandDenied

MessageCommandDenied

(unlikely?)

Happy to hear other ideas of how I might achieve the goal of flagging some commands with

shouldDeleteOnPost

shouldDeleteOnPost

and deleting them, regardless of precondition status.

Solution

I think I found it actually,

PreMessageCommandRun

PreMessageCommandRun

- though still open to feedback about whether this is the best possible place for it

import { Events, Listener, ListenerOptions, PreMessageCommandRunPayload } from "@sapphire/framework";

import { IDrpgCommandOptions } from "../../lib/structures";

export class MessageCommandAccepted extends Listener<typeof Events.PreMessageCommandRun> {
    public constructor(context: Listener.LoaderContext, options?: ListenerOptions) {
        super(context, { ...options, event: Events.PreMessageCommandRun });
    }

    public run(payload: PreMessageCommandRunPayload): void {
        const drpgOptions = payload.command?.options as IDrpgCommandOptions;
        if (drpgOptions?.deleteAfterPost) payload.message.delete();
    }
}

import { Events, Listener, ListenerOptions, PreMessageCommandRunPayload } from "@sapphire/framework";

import { IDrpgCommandOptions } from "../../lib/structures";

export class MessageCommandAccepted extends Listener<typeof Events.PreMessageCommandRun> {
    public constructor(context: Listener.LoaderContext, options?: ListenerOptions) {
        super(context, { ...options, event: Events.PreMessageCommandRun });
    }

    public run(payload: PreMessageCommandRunPayload): void {
        const drpgOptions = payload.command?.options as IDrpgCommandOptions;
        if (drpgOptions?.deleteAfterPost) payload.message.delete();
    }
}

Jump to solution

Event before precondition OR access the command via MessageCommandDenied

Hi all,

I have extended my Command Options to include a property

shouldDeleteOnPost

shouldDeleteOnPost

- which should delete the message once it has been posted.
I'd like to do this in the most universal way possible - I thought using

MessageCommandRun

MessageCommandRun

would have fired before any of the preconditions, but it seems it does not.

When a precondition returns this.error, the code within

MessageCommandRun

MessageCommandRun

        const drpgOptions = request.command.options as IDrpgCommandOptions;
        if (drpgOptions.deleteAfterPost) request.message.delete();

        const drpgOptions = request.command.options as IDrpgCommandOptions;
        if (drpgOptions.deleteAfterPost) request.message.delete();

To get around this, I thought I would try doing effectively the same out of the

MessageCommandAccepted

MessageCommandAccepted

and

MessageCommandDenied

MessageCommandDenied

events - which would have worked perfectly, until I realised that

MessageCommandDenied

MessageCommandDenied

doesn't appear to have any context of what the command itself actually was.

How can I either...
- Run some event before a precondition, pass or fail (preferred)
- Access the command inside of

MessageCommandDenied

MessageCommandDenied

(unlikely?)

Happy to hear other ideas of how I might achieve the goal of flagging some commands with

shouldDeleteOnPost

shouldDeleteOnPost

and deleting them, regardless of precondition status.

Solution

I think I found it actually,

PreMessageCommandRun

PreMessageCommandRun

- though still open to feedback about whether this is the best possible place for it

import { Events, Listener, ListenerOptions, PreMessageCommandRunPayload } from "@sapphire/framework";

import { IDrpgCommandOptions } from "../../lib/structures";

export class MessageCommandAccepted extends Listener<typeof Events.PreMessageCommandRun> {
    public constructor(context: Listener.LoaderContext, options?: ListenerOptions) {
        super(context, { ...options, event: Events.PreMessageCommandRun });
    }

    public run(payload: PreMessageCommandRunPayload): void {
        const drpgOptions = payload.command?.options as IDrpgCommandOptions;
        if (drpgOptions?.deleteAfterPost) payload.message.delete();
    }
}

import { Events, Listener, ListenerOptions, PreMessageCommandRunPayload } from "@sapphire/framework";

import { IDrpgCommandOptions } from "../../lib/structures";

export class MessageCommandAccepted extends Listener<typeof Events.PreMessageCommandRun> {
    public constructor(context: Listener.LoaderContext, options?: ListenerOptions) {
        super(context, { ...options, event: Events.PreMessageCommandRun });
    }

    public run(payload: PreMessageCommandRunPayload): void {
        const drpgOptions = payload.command?.options as IDrpgCommandOptions;
        if (drpgOptions?.deleteAfterPost) payload.message.delete();
    }
}

Jump to solution

Event before precondition OR access the command via MessageCommandDenied

Event before precondition OR access the command via MessageCommandDenied

Continue the conversation

Sapphire - Imagine a Framework

Similar Threads

Similar Threads

Continue the conversation

Sapphire - Imagine a Framework

Similar Threads