✅wrong warning

I came across a case where the C# extension in visual studio code generated the warning: The result of the expression is always 'true' since a value of type 'decimal' is never equal to 'null' of type 'decimal?'CS0472
code below

var aux = query
                .GroupBy(x => x.Data)
                .Select(gp => new Metrics
                {
                    Data = gp.Key.Date,
                    // #pragma warning disable CS0472
                    OrganicTrash = gp.Sum(x => x.Quantidade.Value) != null ? gp.Sum(x => x.Quantidade.Value) : 0
                    // #pragma warning restore CS0472
                }).ToList();
            
            return aux;

var aux = query
                .GroupBy(x => x.Data)
                .Select(gp => new Metrics
                {
                    Data = gp.Key.Date,
                    // #pragma warning disable CS0472
                    OrganicTrash = gp.Sum(x => x.Quantidade.Value) != null ? gp.Sum(x => x.Quantidade.Value) : 0
                    // #pragma warning restore CS0472
                }).ToList();
            
            return aux;

It turns out that OrganicTrash was returning null in cases where quantity was null. I know I can use pragma to stop the warning, but I was curious if I could try to fix this, I took a look at the repository and I'm thinking that I'll actually need to work on the roslyn repository. Any opinions? I'm a beginner and looking for more experienced opinion.

C#•2y ago•

4 replies

xandyMelo

✅wrong warning

var aux = query
                .GroupBy(x => x.Data)
                .Select(gp => new Metrics
                {
                    Data = gp.Key.Date,
                    // #pragma warning disable CS0472
                    OrganicTrash = gp.Sum(x => x.Quantidade.Value) != null ? gp.Sum(x => x.Quantidade.Value) : 0
                    // #pragma warning restore CS0472
                }).ToList();
            
            return aux;

var aux = query
                .GroupBy(x => x.Data)
                .Select(gp => new Metrics
                {
                    Data = gp.Key.Date,
                    // #pragma warning disable CS0472
                    OrganicTrash = gp.Sum(x => x.Quantidade.Value) != null ? gp.Sum(x => x.Quantidade.Value) : 0
                    // #pragma warning restore CS0472
                }).ToList();
            
            return aux;

✅wrong warning

Similar Threads

✅wrong warning

Similar Threads

Similar Threads

Similar Threads