T
tscircuit8mo ago
Seve

Seve mad about CLI

37 Replies
Seve
SeveOP8mo ago
Seve mad about CLI
om
om8mo ago
I am also mad about runframe thing lol have to setup both cli and runframe in local and then test...
Seve
SeveOP8mo ago
ya haha like we're so close to it being actually good the automatic type installation from @shibo and @DOPΣ is pretty sick but we NEED to show that the snippet is loading or errored or whatever, it's pretty frusterating that just like nothing changed same for the "Save Snippet" button
om
om8mo ago
@DOPΣ knows how event bus and runframe works I was trying to understand architecture little bit unclear
DOPΣ
DOPΣ8mo ago
😞 kya fayda
om
om8mo ago
tum krdete aur me chahkar bhi nhi kr pata
DOPΣ
DOPΣ8mo ago
Use cursor bro, it works on your laptop, nothing hard,
ansh.grover
ansh.grover8mo ago
@om @DOPΣ do not use hindi use english
om
om8mo ago
its paid isnt it I am using cline
DOPΣ
DOPΣ8mo ago
Change it cline isn't best, #general
shibo
shibo8mo ago
didn't we merge a pr for that?
om
om8mo ago
thats still open
ansh.grover
ansh.grover8mo ago
@shibo nope, i am working on it but left of in between if anyone want to work on this feel free to make a PR.
shibo
shibo8mo ago
I see
ansh.grover
ansh.grover8mo ago
@shibo actually the thing is i have done it cli part but there is some problem on ui related part
om
om8mo ago
Its 2 repo problem have to emit events from devserver and receive in runframe
ansh.grover
ansh.grover8mo ago
as events are catching correclt like circuit_rendering_finished but the ui is not updating according to that ohh so thats why it is not happening
om
om8mo ago
you have to do dev in 2 repos haha
ansh.grover
ansh.grover8mo ago
yeah if u want you can solve it @om
om
om8mo ago
hm
Rishabh
Rishabh8mo ago
@Seve This repo will be needing cleanup. The tests are in bad shape, we didn't have CI on this so a lot a failing tests have been merged. https://github.com/tscircuit/cli/pull/62 As you say this is getting Sabotaged!! 💣
Seve
SeveOP8mo ago
Omg SABOTAGE
om
om8mo ago
I have created this already 👀
DOPΣ
DOPΣ8mo ago
Well, Keeping all things aside, although it isn't fully my fault but somehow i forget to mention cons of my prs, I'm trying to send patches to fix issues one by one after inspecting myself I also tried fixing the already present code of other peeps, hope you'll co-operate thanks
DOPΣ
DOPΣ8mo ago
Inspection 1: Name not generated in PKG.json https://github.com/tscircuit/cli/pull/63
GitHub
refactor: init & clone by ArnavK-09 · Pull Request #63 · tscircuit/...
avoid writing same code again using dry principles will init pakcage json before adding deps so name is there fix logs error free feat: allow init in custom directory
DOPΣ
DOPΣ8mo ago
Is something changed? Unable to get save to snippets button
No description
Rishabh
Rishabh8mo ago
@DOPΣ Make sure you are testing things before making a PR https://github.com/tscircuit/cli/pull/65/files. We are not using cjs, this breaks the cli
DOPΣ
DOPΣ8mo ago
Ohmg me dumb, also remove these outdated comments, i forgot to commit https://github.com/tscircuit/cli/pull/66
om
om8mo ago
No description
om
om8mo ago
Here test-package used but it uses actual api to check
om
om8mo ago
No description
Seve
SeveOP8mo ago
hey sorry for the delay- are you able to use the fake api to test? if the fake api is missing a feature we can introduce it to the fake api (the fake api is inside the tscircuit.com repo)
om
om8mo ago
Ok this test sometimes pass sometimes fail and in workflow entierly different error 💀
No description
om
om8mo ago
This is passing too localy
No description
Seve
SeveOP8mo ago
if it's failing on ci it might be because the fake-api isn't being used 🤔
om
om8mo ago
will try that but for dev server I am confused

Did you find this page helpful?