TypeError: Cannot read properties of undefined (reading 'value') at withReturning

this is a fun error

TypeError: Cannot read properties of undefined (reading 'value')
    at withReturning (/Users/omar/code/1up/node_modules/better-auth/dist/adapters/drizzle-adapter/index.cjs:169:38)

TypeError: Cannot read properties of undefined (reading 'value')
    at withReturning (/Users/omar/code/1up/node_modules/better-auth/dist/adapters/drizzle-adapter/index.cjs:169:38)

with some fun code to match

    withReturning: async (model, builder, data, where) => {
      if (config.provider !== "mysql") {
        const c = await builder.returning();
        return c[0];
      }
      await builder.execute();
      const schemaModel = getSchema(model);
      const builderVal = builder.config?.values;
      if (where?.length) {
        const clause = convertWhereClause(where, model);
        const res = await db.select().from(schemaModel).where(...clause);
        return res[0];
      } else if (builderVal) {
        const tId = builderVal[0]?.id.value;
        const res = await db.select().from(schemaModel).where(drizzleOrm.eq(schemaModel.id, tId));
        return res[0];
      } else if (data.id) {
        const res = await db.select().from(schemaModel).where(drizzleOrm.eq(schemaModel.id, data.id));
        return res[0];
      }
    },

    withReturning: async (model, builder, data, where) => {
      if (config.provider !== "mysql") {
        const c = await builder.returning();
        return c[0];
      }
      await builder.execute();
      const schemaModel = getSchema(model);
      const builderVal = builder.config?.values;
      if (where?.length) {
        const clause = convertWhereClause(where, model);
        const res = await db.select().from(schemaModel).where(...clause);
        return res[0];
      } else if (builderVal) {
        const tId = builderVal[0]?.id.value;
        const res = await db.select().from(schemaModel).where(drizzleOrm.eq(schemaModel.id, tId));
        return res[0];
      } else if (data.id) {
        const res = await db.select().from(schemaModel).where(drizzleOrm.eq(schemaModel.id, data.id));
        return res[0];
      }
    },

12 Replies

McPizzaOP•2mo ago

using planetscale via drizzle id column is a customType column (dont think it makes a difference) heres the value of builderVal[0]

  val: {
    identifier: Param {
      brand: undefined,
      value: 'sign-in-otp-omar@mcpizza',
      encoder: [MySqlVarChar]
    },
    value: Param {
      brand: undefined,
      value: '157997',
      encoder: [MySqlVarChar]
    },
    expiresAt: Param {
      brand: undefined,
      value: 2025-03-16T23:52:23.981Z,
      encoder: [MySqlTimestamp]
    },
    createdAt: Param {
      brand: undefined,
      value: 2025-03-16T23:47:23.981Z,
      encoder: [MySqlTimestamp]
    },
    updatedAt: Param {
      brand: undefined,
      value: 2025-03-16T23:47:23.981Z,
      encoder: [MySqlTimestamp]
    }
  }

  val: {
    identifier: Param {
      brand: undefined,
      value: 'sign-in-otp-omar@mcpizza',
      encoder: [MySqlVarChar]
    },
    value: Param {
      brand: undefined,
      value: '157997',
      encoder: [MySqlVarChar]
    },
    expiresAt: Param {
      brand: undefined,
      value: 2025-03-16T23:52:23.981Z,
      encoder: [MySqlTimestamp]
    },
    createdAt: Param {
      brand: undefined,
      value: 2025-03-16T23:47:23.981Z,
      encoder: [MySqlTimestamp]
    },
    updatedAt: Param {
      brand: undefined,
      value: 2025-03-16T23:47:23.981Z,
      encoder: [MySqlTimestamp]
    }
  }

there is no ID column being returned for refrence, this is how the schema looks

      id: MySqlCustomColumn {
      name: 'id',
      keyAsName: false,
      primary: true,
      notNull: true,
      default: undefined,
      defaultFn: [Function (anonymous)],
      onUpdateFn: undefined,
      hasDefault: true,
      isUnique: false,
      uniqueName: 'verification_tokens_id_unique',
      uniqueType: undefined,
      dataType: 'custom',
      columnType: 'MySqlCustomColumn',
      enumValues: undefined,
      generated: undefined,
      generatedIdentity: undefined,
      config: [Object],
      table: [Circular *1],
      sqlName: 'BINARY(16)',
      mapTo: [Function: toDriver],
      mapFrom: [Function: fromDriver]
    },

      id: MySqlCustomColumn {
      name: 'id',
      keyAsName: false,
      primary: true,
      notNull: true,
      default: undefined,
      defaultFn: [Function (anonymous)],
      onUpdateFn: undefined,
      hasDefault: true,
      isUnique: false,
      uniqueName: 'verification_tokens_id_unique',
      uniqueType: undefined,
      dataType: 'custom',
      columnType: 'MySqlCustomColumn',
      enumValues: undefined,
      generated: undefined,
      generatedIdentity: undefined,
      config: [Object],
      table: [Circular *1],
      sqlName: 'BINARY(16)',
      mapTo: [Function: toDriver],
      mapFrom: [Function: fromDriver]
    },

note the mapTo and mapFrom functions this is what drizzle uses to transform the custom data from and to the DB so far my solution is to do the following:

const tId = builderVal[0]?.id?.value;
        if(tId) {
          const res = await db.select().from(schemaModel).where(drizzleOrm.eq(schemaModel.id, tId));
          return res[0];
        }
        const fieldValue = builderVal[0]?.identifier?.value;
        if(fieldValue) {
          const res = await db.select().from(schemaModel).where(drizzleOrm.eq(schemaModel.identifier, fieldValue));
          return res[0];
        }
        return null;

const tId = builderVal[0]?.id?.value;
        if(tId) {
          const res = await db.select().from(schemaModel).where(drizzleOrm.eq(schemaModel.id, tId));
          return res[0];
        }
        const fieldValue = builderVal[0]?.identifier?.value;
        if(fieldValue) {
          const res = await db.select().from(schemaModel).where(drizzleOrm.eq(schemaModel.identifier, fieldValue));
          return res[0];
        }
        return null;

obviously this only works on one type of auth table but at lease i can test more now

bekacru•2mo ago

Are you on the latest version of better auth?

McPizzaOP•2mo ago

on v1.2.3 @bekacru

bekacru•2mo ago

We have had similar problem before with mysql + drizzle. It was fixed some versions ago and we have specefic test for mysql :)) But seems like we missed something or there is an issue specifically with planetscale. Will look into it.

McPizzaOP•2mo ago

epic db schema is available in https://github.com/un/1up/tree/main/packages/db

GitHub

1up/packages/db at main · un/1up

Open Source Longevity System; Live Longer + Sharper + Better - un/1up

McPizzaOP•4w ago

@bekacru did you have a think about this? or should I just open an issue on GH to track?

bekacru•4w ago

Oh yeah I did. I think I pushed some changes, if you haven't tried it on latest do that and let me know if it's still an issue.

McPizzaOP•4w ago

ok thanks, will give it a go still in latest version @bekacru will keep my patches in place for now

McPizzaOP•4w ago

the patch file that works for me https://github.com/un/1up/blob/main/patches/better-auth.patch

GitHub

1up/patches/better-auth.patch at main · un/1up

Open Source Longevity System; Live Longer + Sharper + Better - un/1up

bekacru•4w ago

Just went through the issue. For your use case, you can fix it by actually passing the id generator in your auth config instead

const auth = betterAuth({
  advanced: {
     generateId: ({ model }) => cloudTypeIdGenerator(model)
  }
})

const auth = betterAuth({
  advanced: {
     generateId: ({ model }) => cloudTypeIdGenerator(model)
  }
})

bekacru•4w ago

and general fix https://github.com/better-auth/better-auth/pull/2136

GitHub

fix(drizzle adapter): drizzle adapter failing when used with mysql ...

McPizzaOP•4w ago

great! appreciate it

Gaming

Programming

TypeError: Cannot read properties of undefined (reading 'value') at withReturning

Did you find this page helpful?