Prevent multiple calls to the same model

I have the following scenario

Select::make('inventory_id')
    ->relationship('inventory', 'title')
    ->searchable()
    ->preload()
    ->live()
    ->required(),
TextInput::make('quantity')
    ->required()
    ->numeric()
    ->maxValue(fn(Get $get) => $get('inventory_id') ? Inventory::find($get('inventory_id'))->quantity : null)
    ->helperText(fn (Get $get) => $get('inventory_id') ? ['quantity' => Inventory::find($get('inventory_id'))->quantity] : null),

Select::make('inventory_id')
    ->relationship('inventory', 'title')
    ->searchable()
    ->preload()
    ->live()
    ->required(),
TextInput::make('quantity')
    ->required()
    ->numeric()
    ->maxValue(fn(Get $get) => $get('inventory_id') ? Inventory::find($get('inventory_id'))->quantity : null)
    ->helperText(fn (Get $get) => $get('inventory_id') ? ['quantity' => Inventory::find($get('inventory_id'))->quantity] : null),

Basically, I'm setting a

maxValue

maxValue

on the

quantity

quantity

field. I'm also adding a

helperText

helperText

to give the user a more helpfull message. But I'm calling the same thing twice.

Any recommendations to avoid doing this?

Solution

I guess that's up to you to decide. I just said that because sometimes an extra

find

find

query is no big deal.

In any case, if you're in laravel 11+, have a look at this too https://flanger.dev/blog/post/avoid-duplicate-queries-in-filament-closures-for-eloquent-records

Jump to solution

Filament•11mo ago•

7 replies

Will Aguilar

Prevent multiple calls to the same model

I have the following scenario

Select::make('inventory_id')
    ->relationship('inventory', 'title')
    ->searchable()
    ->preload()
    ->live()
    ->required(),
TextInput::make('quantity')
    ->required()
    ->numeric()
    ->maxValue(fn(Get $get) => $get('inventory_id') ? Inventory::find($get('inventory_id'))->quantity : null)
    ->helperText(fn (Get $get) => $get('inventory_id') ? ['quantity' => Inventory::find($get('inventory_id'))->quantity] : null),

Select::make('inventory_id')
    ->relationship('inventory', 'title')
    ->searchable()
    ->preload()
    ->live()
    ->required(),
TextInput::make('quantity')
    ->required()
    ->numeric()
    ->maxValue(fn(Get $get) => $get('inventory_id') ? Inventory::find($get('inventory_id'))->quantity : null)
    ->helperText(fn (Get $get) => $get('inventory_id') ? ['quantity' => Inventory::find($get('inventory_id'))->quantity] : null),

Basically, I'm setting a

maxValue

maxValue

on the

quantity

quantity

field. I'm also adding a

helperText

helperText

to give the user a more helpfull message. But I'm calling the same thing twice.

Any recommendations to avoid doing this?

Solution

I guess that's up to you to decide. I just said that because sometimes an extra

find

find

query is no big deal.

In any case, if you're in laravel 11+, have a look at this too https://flanger.dev/blog/post/avoid-duplicate-queries-in-filament-closures-for-eloquent-records

Jump to solution

Prevent multiple calls to the same model

Similar Threads

Prevent multiple calls to the same model

Similar Threads

Similar Threads

Similar Threads