reactor_req - argument option in dsl is missing

Weird because wait_for does work, which supposedly unsugars to argument :_, result(step_to_wait_for). Error:

Compiling 1 file (.ex)
     error: undefined function argument/2 (there is no such import)
     │
 122 │     argument :agent_result, result(:generate)

Compiling 1 file (.ex)
     error: undefined function argument/2 (there is no such import)
     │
 122 │     argument :agent_result, result(:generate)

Solution:

https://github.com/ash-project/reactor_req/pull/13

GitHub

support argument option and pass extra arguments to guard by rtor...

Contributor checklist Leave anything that you believe does not apply unchecked. Bug fixes include regression tests Chores Documentation changes Features include unit/acceptance tests Refactor...

Jump to solution

14 Replies

ZachDaniel•4mo ago

What do the DSL docs for that step show?

rtorreswareOP•4mo ago

rtorreswareOP•4mo ago

argument is missing there too maybe I'm on a previous version, before ash absortion? https://hexdocs.pm/reactor_req/dsl-reactor-req.html#reactor-req_post I need an extra argument so I can check for it in a guard

rtorreswareOP•4mo ago

wonder what's going on, code does import it. This is the main branch in https://github.com/ash-project/reactor_req

GitHub

GitHub - ash-project/reactor_req: A Reactor DSL extension for makin...

A Reactor DSL extension for making HTTP requests with Req. - ash-project/reactor_req

ZachDaniel•4mo ago

Hmm...

rtorreswareOP•4mo ago

need a repro?

ZachDaniel•4mo ago

I wouldnt end up handling it TBH. My suggestion is to open an issue on the project 🙂

rtorreswareOP•4mo ago

any hints? Maybe I can knock it out msyelf I'm a bit of a noob on elixir I'll ask Mr Claude

ZachDaniel•4mo ago

I don't think that importing argument there does what you're thinking Actually I'm not sure But I'd look at another step that does support arguments and see 🙂

rtorreswareOP•4mo ago

maybe arguments: [Argument.__entity__(), WaitFor.__entity__()], is enough here I'll write a test success on receiving args, but they are not passed to the guard function. Checking that. ok, fixed

Solution

rtorresware•4mo ago

https://github.com/ash-project/reactor_req/pull/13

GitHub

support argument option and pass extra arguments to guard by rtor...

Contributor checklist Leave anything that you believe does not apply unchecked. Bug fixes include regression tests Chores Documentation changes Features include unit/acceptance tests Refactor...

rtorreswareOP•4mo ago

feel free to criticize my testing lol it's not the best. I'll follow your lead here

ZachDaniel•4mo ago

@James Harton will likely be the one to end up reviewing it 🙂

rtorreswareOP•4mo ago

kk. I'll add my fork to my deps in the meantime excelleeeent, it works with my code now. Marking resolved

Gaming

Programming

reactor_req - argument option in dsl is missing

Did you find this page helpful?