56 Replies
I think this is the correct format for right
it should be 1 , 2 ,3 right the 3 should be in the right ?
Yeah, that is fine too
ok let me edit them
@Rishabh
did I get it right ?
Lgtm!
cc @Seve
yea looks right!
ship!
Afk but trust 🫡
@Rishabh the meger is blocked by your requsted changes can you approve it ?
NVM I got it
@Rishabh @Seve this seems incorrect? what do you think?
left one is old version and right is latest version
I think old is correct according to this
I think the right side is wrong yes
Could be a symbols repo issue
yeah
just need to change the pin no
In your test, make sure that your connections object is like {{ emitter: “net.emitter” }} not {{ pin1: “net.emitter” }}, i think you did it right iirc
@Seve this will be npn
this will be pnp
@Rishabh I was just fixing the anchor text. is this for text?
I would say, it's better you fix the pinLabels as well. Hardly would take 2min and we need to follow the correct practice for labels
is the pin label incorrect?
pin numbers, take a reference from some of the symbols @Abse has done
I can help you
@Rishabh should we remove the horz and vert variants ?
Mmm.. not sure if we need those for backwards compatibility. I think just keep it
yeah my thoughts exactly
GitHub
Symbol Conventions · Issue #305 · tscircuit/schematic-symbols
Always travel from lower to higher, in the direction of the symbol. INCREASE in the direction of the symbol For example, if the symbol is "right", then we have pin1 on the left and pin2 o...
check this and let me know
I can also review your PR before calling for Rishabh
is the pin no incorrect in it?https://github.com/tscircuit/schematic-symbols/pull/329/files
@Techmannih no right version ?
right version have not anchor issue that why which is not updating
ok looks good to me the ports label follow the conventions the number increase in the direction of the symbol @Rishabh
wait
@Techmannih why are you not using modifySumbol ?
rotateSymbol is deprecated
you can use one of my PRs as a referenceI am not using rotateSymbol, which is already there
yeah but can't you fix it it's easy
we keep using deprecated methods
I'm working on a refactor for the script to use the new methods
but for now we should fix them manually
yeah sure
@Rishabh
you switched them to modifySymbol ?
if so I think this is good
All are anti-clockwise. Make sure the pin number is increasing in the clockwise direction
@Rishabh I think thie is an old rule no ?
I think @Seve said the largest number will be in the direction of the symbol no ?
(that is what I thought)
yeah, but some pin label wrong as rishabh suggested? I got confused due to this
how about now? @Rishabh
now I don't think this is right , I think the down variant should have the 3 in the bottom ?
.
It's not possible to have the largest always towards the direction. Checkout the example which you did
yeah
got it
so hopefully this is correct?
Follow the convention of rotation, it should be clockwise
@Rishabh https://github.com/tscircuit/schematic-symbols/pull/329
@Rishabh can you check it not
@Rishabh merge ?
Yes
@Rishabh https://github.com/tscircuit/core/pull/1074
@Seve do I need to fix this in the core, or should I update the pin numbering in the symbol?
@Rishabh I think this symbol also not following the clockwise, should i need to fix it before assigning the pin no to transistor's pin label
Yeah, go ahead and fix the direction
@Rishabh there is 3 pin how to identify left to right bit confusing . what ahould be the correct order of them?
The symbol is right, so the pin number
1 should be the left most and the order of pin number increases in the direction of right@Rishabh is it correct now?
Looks about right to me