@Seve any idea what this error means?
@Seve any idea what this error means?
Run npm run test:node-bundle
> @tscircuit/3d-viewer@0.0.313 test:node-bundle
> node ./scripts/load-bundle-in-node.js
file:///home/runner/work/3d-viewer/3d-viewer/dist/chunk-VPD3FYS5.js:11
throw Error('Dynamic require of "' + x + '" is not supported');
^
Error: Dynamic require of "react" is not supported
at file:///home/runner/work/3d-viewer/3d-viewer/dist/chunk-VPD3FYS5.js:11:9
at $$$reconciler (file:///home/runner/work/3d-viewer/3d-viewer/dist/index.js:39714:22)
at file:///home/runner/work/3d-viewer/3d-viewer/dist/index.js:119206:55
at ModuleJob.run (node:internal/modules/esm/module_job:329:25)
at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:644:26)
at async file:///home/runner/work/3d-viewer/3d-viewer/scripts/load-bundle-in-node.js:2:1
Node.js v22.17.1
Error: Process completed with exit code 1.12 Replies
Is it passing on main?
tbh this test is a bit confusing to me because the 3d viewer never has to load in node
it was probably added for a reason but i have no idea why
wdym?
this is the github workflow
right when it runs on main
oh it doesn't run on main
nvm it does and it's passing
npm ls react? Maybe a version change is causing it?
it's such a weird test, like i said i don't know it's purpose but it might prevent some kind of downstream bug with React
@Seve
Youve got two versions of react somehow 🤔
19 and 18
ugh can't believe this is holding us back 😠lmk if you need a hand, i'm spread a bit thin but ik it's blocking, just hmu if you're stuck
Can you please fix it? Im kinda stuck
i've been looking at this and it's taking forever
maybe i fixed it tho
@shibo merging, hopefully that fixes it, lmk if you hit stuff, it should be easier to fix things now. I had to update downstream deps to upgrade react and fiddle with deps