Issue with `traceFlags` Not Being Set When Value is 0 in `Tracer.withSpanContext`
I'm trying to use
But it seems:
1. traceFlags is not set on context when the value is 0 (https://github.com/Effect-TS/effect/blob/6bc3f8090cacefd201dbbc9613f681e0a8b87475/packages/opentelemetry/src/internal/tracer.ts#L191)
2. later, when effect creates new spans, it calls makeSpanContext
3. makeSpanContext defaults to OtelApi.TraceFlags.SAMPLED when traceFlags is not set on the context (https://github.com/Effect-TS/effect/blob/6bc3f8090cacefd201dbbc9613f681e0a8b87475/packages/opentelemetry/src/internal/tracer.ts#L284-L289)
Is the truthy check in 1 intentional? vs checking if defined
Tracer.withSpanContextBut it seems:
1. traceFlags is not set on context when the value is 0 (https://github.com/Effect-TS/effect/blob/6bc3f8090cacefd201dbbc9613f681e0a8b87475/packages/opentelemetry/src/internal/tracer.ts#L191)
2. later, when effect creates new spans, it calls makeSpanContext
3. makeSpanContext defaults to OtelApi.TraceFlags.SAMPLED when traceFlags is not set on the context (https://github.com/Effect-TS/effect/blob/6bc3f8090cacefd201dbbc9613f681e0a8b87475/packages/opentelemetry/src/internal/tracer.ts#L284-L289)
Is the truthy check in 1 intentional? vs checking if defined
Similar Threads
Was this page helpful?
