i fixed it here: https://github.com/
i fixed it here: https://github.com/tscircuit/core/pull/1344/files but your main branch is really weird, you might want to start over and just pull the relevant files
12 Replies
awesome, thanks. want me to just pr your changes? also can you please explain how you fixed it? I thought it wasn't possible without my hack
you had a bad merge, it wasn't possible with your Renderable code because it was missing any handling for
asyncDependencies
my change is super minor, i basically just checked out Renderable.ts from origin/main and made sure that asyncDependencies was set up properlyI was also missing this: PcbRouteNetIslands from the async dependencies
yes i'm not really sure that matters but i figured it was technically slightly more correct
https://github.com/tscircuit/core/pull/1345 now I need to draw them in circuit-json-to-gerber and pcb-viewer
GitHub
feat(pcb): Implement copper pour component by ShiboSoftwareDev · P...
Introduces a new <copperpour /> primitive component for creating copper fills on PCB layers.
The implementation adds a CopperPour class that performs the following during a new PcbCop...
fwiw the ground pour is not properly margined from the traces
i'm down to merge then we can just improve this one step at a time?
eventually we should move it into a dedicated solver because it's going to get quite complex, especially for hatched solving haha
ok, I'll now work on pcb-viewer and gerber repos, then I'll get back to the trace issue
sg
the upside of hatched is it looks cool
the only upside?
haha tbh most people just do it because it looks cool. It can help prevent thermal distortion if the pcb gets hot too