DOPΣ - anything not needed?

anything not needed?
16 Replies
Seve
Seve3w ago
why is it asking for the organization github handle? Shouldn't it just ask for org name? otherwise looks good, btw i'm introducing org_display_name to the API to allow capitals etc. in the org name org_name will have the same restrictions as github username with all lower case etc. the UI looks good tho
DOPΣ
DOPΣOP3w ago
oh thats minor ill update, but i guess we need to update how it handles in backend
No description
Seve
Seve3w ago
ugh yea so much broken been trying to merge org_display_name for a couple hours but random tests breaking so making the tests more stable 😭 i think people will create an org, then connect that org to github later FWIW- but we don't need to worry about that flow yet ig
DOPΣ
DOPΣOP3w ago
should i merge or wait for backend updated? @Seve
Seve
Seve3w ago
we can do incremental merging we're just approximating each step haha
DOPΣ
DOPΣOP3w ago
means i shoudl merge?
Seve
Seve3w ago
yea sure we'll just keep trying to get closer and keep fixing
DOPΣ
DOPΣOP3w ago
what is backend? i mean why its sending org to usernames
No description
Seve
Seve3w ago
what endpoint is that? it looks like a bug if it's accounts/get
DOPΣ
DOPΣOP3w ago
No description
Seve
Seve3w ago
oh that looks correct what's the issue? it's a personal org every user has a personal org
DOPΣ
DOPΣOP3w ago
ummm but it would make user page to org page, it doesnt says if its personal or or not
No description
Seve
Seve3w ago
we can add a flag is_personal_org to the org table i can throw that into a PR in a sec, the backend tests are so flaky i'm having trouble merging anything rn for some reason but feel free to add to fake for your logic
DOPΣ
DOPΣOP3w ago
in public mapping ig, i also added in fake rn
Seve
Seve3w ago
kk

Did you find this page helpful?