Disable shared album discount code?
As the title says, is there a way to disable the discount banner at the bottom of any shared album? It’s misleading for a couple reasons:
1. Most people don’t know what self-hosting is. This message is misleading, as it implies that I’m a member of the hosted service, and that the person viewing my album should sign up to more easily share photos with me. I don’t want to have to explain this to everyone I’m sharing photos with.
2. I’m guessing these codes don’t work because they’re generated by my server. This is a poor user experience when they go to sign up.
I’m all getting people signing up for ente, I just think this banner needs some work for it to be appropriate on self-hosted instances.
10 Replies
I'm sorry, I couldn't find the answer in the documentation.
-# If your issue is resolved, feel free to use the /solved command to close this thread. If you'd like to ask me another question use /docsearch
I don't think there is, feel free to create a feature request on GitHub discussions
I suspect this will not get prioritized anytime soon. Should I submit a PR instead?
For anyone interested in upvoting: https://github.com/ente-io/ente/discussions/7468
GitHub
[Self-hosting] Disable shared album discount code · ente-io ente ...
When self-hosted, the discount banner at the bottom of any shared album is misleading for a couple reasons: The banner implies that I’m a member of the hosted service, and that the person viewing m...
Hey @Manav is it okay if a PR gets created for this?
Sure, but I also don't want to add a config flag for every little thing, and I also don't want to permanently disable it (e.g. then it gets disabled when testing locally, and it is easy to break it for production)
If OP really wishes to not just fix it for their instance but create a PR, then this would be the place to add the flag https://github.com/ente-io/ente/blob/main/web/apps/photos/.env
GitHub
ente/web/apps/photos/.env at main · ente-io/ente
🔒 End-to-end encrypted cloud for photos, videos and 2FA secrets. - ente-io/ente
Yeah, not every little thing needs a flag, just the bits that directly reference ente’s servers. I can tell your team cares about making a polished self-hosting experience, and little things like this do matter.
Right, let's make this change then - we can add, e.g. NEXT_PUBLIC_ENTE_OMIT_REF_BANNER in the photos/.env and if that is truthy omit displaying the referral line
@Neeraj give a great idea of how to do this without (a) either introducing a new flag, and (b) still keep it working in dev mode. Have implemented it here - https://github.com/ente-io/ente/pull/7503