itsme - jlcpcb is still not able to interpret t...
jlcpcb is still not able to interpret the board outlines. https://tscircuit.com/Heinrich-XIAO/greenboard
Heinrich-XIAO/greenboard - tscircuit
This code configures a microcontroller-based development board with connected power, reset, and communication interface pins, along with a Greenpill module mounted onto the circuit. To use the component "@tsci/Heinrich-XIAO.greenboard":
1. Import the component:
2. Use ...
44 Replies
cc: @Seve
CC @shibo this is a gerber generation issue
this is his circuit json from the link above
GitHub
Outline not created/interpreted by JLCPCB properly · Issue #68 · ...
Circuit JSON: greenboard.json
Ill check it out
@shibo im driving but this might be the fix, we need to test gerber uploads on jlcpcb https://github.com/tscircuit/circuit-json-to-gerber/pull/71
GitHub
Fix outline closure and add greenboard snapshot test by seveibar ·...
Summary
close custom board outlines and flip Y coordinates when generating edge cut gerbers
add a regression test and SVG snapshots for the greenboard outline fixture
Testing
BUN_UPDATE_SNAPSHOT...
(Driving = temporarily stopped)
Do you mean we must enforce gerber file tesring on PR?
I might find an open source gerber viewer where we can use to create a dev server with vercel preview
we already have SVG snapshots tho with an open-source viewer, that's better than a vercel preview
i'm at my cpu briefly, will test PR #71 now
shibo fix confirmed
should i order the board?
Yea for sure, let me know what the full cost is (you can add assembly)
We dont have algora for reimbursement right now but we can figure something out. I can also give you a purchasing card
About to hop in my car but lmk we’ll get it sorted!
a p-card would probably work but it kinda depends since a lot of them dont work in canada
Itll work its a company card we’ve used them. I set a limit based on the full cost tho so lmk
We can als reimburse i just dont know what platform to use
also, i dont think the patch has propagated yet. im still seeing the same rectangular broken board.
yea it's not propagated yet
sorry totally forgot, thought someone else would help propagate
we should do this automatically in the future https://github.com/tscircuit/tscircuit/issues/1507
ok it's moving upstream now, should be up in an hour or so and i'm watching the pipeline
it still seems to be broken
are you using the file menu to download?
it might be broken still on tscircuit.com maybe- but from the
tsci dev file menu it should be up to date, if it's not i will do a deep investigation- sorry about thatyeah im using the file menu. ill try locally
ok will look into it, sorry about that
wait no i was using the downloadb menu
on tscircuit.com
yea that's always a bit outdated unfortunately because the release pipeline is relatively new
i sort of want to always dynamically load those converters on the fly so that it's always up to date for tscircuit.com
what's ncu?
is it like
bun update --latest?npm-check-updates
its 3rd party so im checking if that might be the problem
gotcha ok lmk
it still seems to be broken
can you do File > Bug Report just so that i have the exact code that's being run, i will repro
annoying
idk why it wouldn't be up to date
it updates, but the board outlines are still broken
getting this for some reason
so confused
i will look into this more in one sec
@itsme we've added a test for this on the CLI repo and we're investigating it, i don't know how you're not getting this error locally :feelsconfusedman: https://github.com/tscircuit/cli/pull/1202/files#diff-9f77e5165a3a22dcf37e9a736919d7ed946d7ef8aca221044167141174a8c42c
CC @Rishabh / @AyushJ can someone look into this? There's a nice repro- maybe claude can give a head start. I have no idea why it would say "process is not defined"- it's like it's somehow accidentally importing a node builtin(?)
oof the CI can't reproduce... i get this error locally but the CI doesn't :/
I can see the same
process is not defined on my end too!
Taking a look
https://github.com/tscircuit/common/pull/59
@tscircuit/common was being bundled with tsup and not tsup-node
amazing ty!