! Rushabh | Linux Shill - @shibo 3d images are ...
@shibo 3d images are messed up everywhere in tscircuit https://github.com/tscircuit/tscircuit.com/issues/2105
24 Replies
Even the circuit-json-to-gltf is not matching with the 3d viewer
3d viewer
circuit-json-to-gltf
Downloaded gltf file
Downloaded png
@Seve
Now i am confused, where to start debugging
yes both are different
seems like position offset issue there
are you importing this?
in which lib
my sparkfun prs are pending because of this issue https://github.com/tscircuit/sparkfun-boards/pulls
can you share the link of that package?
which pr?
https://github.com/tscircuit/sparkfun-boards/pull/218
top 3 pr are all mine
have all same issue?
i am struggling to fix it, need help
yes
???
which you are building in tscircuit.com
yes position offset issue
use
positionOffset: { x:-1.25, y: 0, z: 0 },
that i know, what about the gltf and 3d png
how to fix them
snapshot uses 3d png
also this
Actually, this issue is in the EasyEDA converter. When we import JLCPCB parts, there are some offset problems. So the fix needs to be made in EasyEDA.
need some help with that, i cant seem to figure out how does that lib works and what i need to fix in it. 🥺
You need to get the correct position offsets when importing the JLCPCB parts. I’ve referred you to two PRs for reference. Please also include these packages in the fix — you’ll need to dig into the conversion logic
where does this objUrl: "https://modelcdn.tscircuit.com/easyeda_models/download?uuid=dc634ef6f677426f9bef12d13c1b02cd&pn=C75749" comes from
tscircuit.com
the issue is in the circuit json right
that is a circuit json to gltf issue if the 3d viewer is displaying properly probably
maybe @Techmannih was right in that repro...