4 replies

Kysely deleteMany always returns 1

Hello!

I came across this when trying to build out a way to require my approval before a user can sign up. I created a minimal plugin that tells better-auth about my extra table, and I'd like to check and delete the appropriate row in the user.create.before databaseHook:

export const auth = betterAuth({
  database: {
    db: db, // kysely db instance
    type: "postgres",
    transaction: true,
    case: "snake",
  },
  plugins: [
    approvedSignupEmailPlugin(),
    ...
  ],
  ...
  databaseHooks: {
    user: {
      create: {
        before: async (user, ctx) => {
          let approvedEmail = false;

          if (user.email) {
            const adapter = await getCurrentAdapter(ctx?.context.adapter!);
            const result = await adapter.deleteMany({
              model: "approvedSignupEmail",
              where: [{ field: "email", operator: "eq", value: user.email }],
            });
            approvedEmail = result > 0;
        },
        // throw error if approvedEmail false
        ...

export const auth = betterAuth({
  database: {
    db: db, // kysely db instance
    type: "postgres",
    transaction: true,
    case: "snake",
  },
  plugins: [
    approvedSignupEmailPlugin(),
    ...
  ],
  ...
  databaseHooks: {
    user: {
      create: {
        before: async (user, ctx) => {
          let approvedEmail = false;

          if (user.email) {
            const adapter = await getCurrentAdapter(ctx?.context.adapter!);
            const result = await adapter.deleteMany({
              model: "approvedSignupEmail",
              where: [{ field: "email", operator: "eq", value: user.email }],
            });
            approvedEmail = result > 0;
        },
        // throw error if approvedEmail false
        ...

result

result

here is always 1 (even if you replace

value: user.email

value: user.email

with

value: "DOES-NOT-EXIST"

value: "DOES-NOT-EXIST"

My goal is to tie in to the existing better-auth postgres transaction so that throwing an error here or in the

after

after

hook (or if there is an issue with signing up the user) leaves the

approved_signup_emails

approved_signup_emails

record in the database. Using

getCurrentAdapter

getCurrentAdapter

seems to accomplish this, but please let me know if there's a more recommended path.

I'm new to better-auth and kysely, but I believe the issue is here: https://github.com/better-auth/better-auth/blob/b1ea1f520f504923e592910e959b057629908b9c/packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts#L575-L585

For Kysely, I think you'd need to check

.numDeletedRows

.numDeletedRows

of the result rather than just taking the length. I haven't dug into it, but I think there is a similar issue with updateMany.

I'm using the latest version of better-auth and kysely.

Let me know if you need any more info. Thanks!

GitHub

better-auth/packages/better-auth/src/adapters/kysely-adapter/kysely...

The most comprehensive authentication framework for TypeScript - better-auth/better-auth

Kysely deleteMany always returns 1

export const auth = betterAuth({
  database: {
    db: db, // kysely db instance
    type: "postgres",
    transaction: true,
    case: "snake",
  },
  plugins: [
    approvedSignupEmailPlugin(),
    ...
  ],
  ...
  databaseHooks: {
    user: {
      create: {
        before: async (user, ctx) => {
          let approvedEmail = false;

          if (user.email) {
            const adapter = await getCurrentAdapter(ctx?.context.adapter!);
            const result = await adapter.deleteMany({
              model: "approvedSignupEmail",
              where: [{ field: "email", operator: "eq", value: user.email }],
            });
            approvedEmail = result > 0;
        },
        // throw error if approvedEmail false
        ...

export const auth = betterAuth({
  database: {
    db: db, // kysely db instance
    type: "postgres",
    transaction: true,
    case: "snake",
  },
  plugins: [
    approvedSignupEmailPlugin(),
    ...
  ],
  ...
  databaseHooks: {
    user: {
      create: {
        before: async (user, ctx) => {
          let approvedEmail = false;

          if (user.email) {
            const adapter = await getCurrentAdapter(ctx?.context.adapter!);
            const result = await adapter.deleteMany({
              model: "approvedSignupEmail",
              where: [{ field: "email", operator: "eq", value: user.email }],
            });
            approvedEmail = result > 0;
        },
        // throw error if approvedEmail false
        ...

result

result

here is always 1 (even if you replace

value: user.email

value: user.email

with

value: "DOES-NOT-EXIST"

value: "DOES-NOT-EXIST"

My goal is to tie in to the existing better-auth postgres transaction so that throwing an error here or in the

after

after

hook (or if there is an issue with signing up the user) leaves the

approved_signup_emails

approved_signup_emails

record in the database. Using

getCurrentAdapter

getCurrentAdapter

.numDeletedRows

.numDeletedRows

GitHub

better-auth/packages/better-auth/src/adapters/kysely-adapter/kysely...

The most comprehensive authentication framework for TypeScript - better-auth/better-auth

Kysely deleteMany always returns 1

Kysely deleteMany always returns 1

Similar Threads

Similar Threads

Similar Threads