5 replies

Generic actions breaking in AshGraphql when require_user? is true for the domain

AshGraphQL

Ash✅Solved

Hey all, so as the title states, I have a generic action that's wired up through AshGraphql. We're on the most recent release for AshGraphql and Ash. When

require_actor?

require_actor?

is true for the action's domain I'm getting the following error with this stack trace:

17:21:36.490 [error] 6f389081-2595-4365-b715-5af025f4a5b5: Exception raised while resolving query.

** (Ash.Error.Forbidden) 
Forbidden Error

* The domain Mandark.Learning requires that an actor is provided at all times and none was provided.
  (ash 3.12.0) lib/ash/error/forbidden/domain_requires_actor.ex:8: Ash.Error.Forbidden.DomainRequiresActor.exception/1
  (ash 3.12.0) lib/ash/actions/helpers.ex:356: Ash.Actions.Helpers.add_actor/3
  (ash 3.12.0) lib/ash/actions/helpers.ex:318: Ash.Actions.Helpers.set_opts/3
  (ash 3.12.0) lib/ash/actions/helpers.ex:298: Ash.Actions.Helpers.set_context_and_get_opts/3
  (ash 3.12.0) lib/ash/action_input.ex:242: Ash.ActionInput.for_action/4
  (ash_graphql 1.8.5) lib/graphql/resolver.ex:65: AshGraphql.Graphql.Resolver.resolve/2

17:21:36.490 [error] 6f389081-2595-4365-b715-5af025f4a5b5: Exception raised while resolving query.

** (Ash.Error.Forbidden) 
Forbidden Error

* The domain Mandark.Learning requires that an actor is provided at all times and none was provided.
  (ash 3.12.0) lib/ash/error/forbidden/domain_requires_actor.ex:8: Ash.Error.Forbidden.DomainRequiresActor.exception/1
  (ash 3.12.0) lib/ash/actions/helpers.ex:356: Ash.Actions.Helpers.add_actor/3
  (ash 3.12.0) lib/ash/actions/helpers.ex:318: Ash.Actions.Helpers.set_opts/3
  (ash 3.12.0) lib/ash/actions/helpers.ex:298: Ash.Actions.Helpers.set_context_and_get_opts/3
  (ash 3.12.0) lib/ash/action_input.ex:242: Ash.ActionInput.for_action/4
  (ash_graphql 1.8.5) lib/graphql/resolver.ex:65: AshGraphql.Graphql.Resolver.resolve/2

I reproduced this using tests with Absinthe and also directly against the server. In both cases, I should be passing an actor. Interestingly, while poking around in the Ash and AshGraphql source code, I noticed that the actor is available in the

context

context

and

opts

opts

vars in

AshGraphql.Graphql.Resolver.resolve/2

AshGraphql.Graphql.Resolver.resolve/2

. However, it's not available in any of the ash functions in the stack trace. I noticed Ash.ActionInput.for_action/4 takes in an

opts

opts

param, and we're not passing the one we have available. When I made that change the error was resolved.

          input =
            %Ash.ActionInput{domain: domain, resource: resource}
            |> Ash.ActionInput.set_context(get_context(context))
            |> Ash.ActionInput.for_action(action.name, arguments, opts)

          input =
            %Ash.ActionInput{domain: domain, resource: resource}
            |> Ash.ActionInput.set_context(get_context(context))
            |> Ash.ActionInput.for_action(action.name, arguments, opts)

This feels a bit heavy handed, but if this error is reproducible and the fix is sensible then I'd be happy to open a PR for the change upstream. Thanks for any input!

Solution

https://github.com/ash-project/ash_graphql/pull/396 fix should be in the next release

GitHub

fix: pass opts to for_action for generic actions by barnabasJ · Pu...

Generic actions on domains with require_actor? true fail with this error even when an actor is properly provided in the GraphQL context:
** (Ash.Error.Forbidden)
Forbidden Error

* The domain AshGr...

Jump to solution

Ash Framework•2mo ago•

5 replies

samwest_9

Generic actions breaking in AshGraphql when require_user? is true for the domain

AshGraphQL

Ash✅Solved

Hey all, so as the title states, I have a generic action that's wired up through AshGraphql. We're on the most recent release for AshGraphql and Ash. When

require_actor?

require_actor?

is true for the action's domain I'm getting the following error with this stack trace:

17:21:36.490 [error] 6f389081-2595-4365-b715-5af025f4a5b5: Exception raised while resolving query.

** (Ash.Error.Forbidden) 
Forbidden Error

* The domain Mandark.Learning requires that an actor is provided at all times and none was provided.
  (ash 3.12.0) lib/ash/error/forbidden/domain_requires_actor.ex:8: Ash.Error.Forbidden.DomainRequiresActor.exception/1
  (ash 3.12.0) lib/ash/actions/helpers.ex:356: Ash.Actions.Helpers.add_actor/3
  (ash 3.12.0) lib/ash/actions/helpers.ex:318: Ash.Actions.Helpers.set_opts/3
  (ash 3.12.0) lib/ash/actions/helpers.ex:298: Ash.Actions.Helpers.set_context_and_get_opts/3
  (ash 3.12.0) lib/ash/action_input.ex:242: Ash.ActionInput.for_action/4
  (ash_graphql 1.8.5) lib/graphql/resolver.ex:65: AshGraphql.Graphql.Resolver.resolve/2

17:21:36.490 [error] 6f389081-2595-4365-b715-5af025f4a5b5: Exception raised while resolving query.

** (Ash.Error.Forbidden) 
Forbidden Error

* The domain Mandark.Learning requires that an actor is provided at all times and none was provided.
  (ash 3.12.0) lib/ash/error/forbidden/domain_requires_actor.ex:8: Ash.Error.Forbidden.DomainRequiresActor.exception/1
  (ash 3.12.0) lib/ash/actions/helpers.ex:356: Ash.Actions.Helpers.add_actor/3
  (ash 3.12.0) lib/ash/actions/helpers.ex:318: Ash.Actions.Helpers.set_opts/3
  (ash 3.12.0) lib/ash/actions/helpers.ex:298: Ash.Actions.Helpers.set_context_and_get_opts/3
  (ash 3.12.0) lib/ash/action_input.ex:242: Ash.ActionInput.for_action/4
  (ash_graphql 1.8.5) lib/graphql/resolver.ex:65: AshGraphql.Graphql.Resolver.resolve/2

context

context

and

opts

opts

vars in

AshGraphql.Graphql.Resolver.resolve/2

AshGraphql.Graphql.Resolver.resolve/2

. However, it's not available in any of the ash functions in the stack trace. I noticed Ash.ActionInput.for_action/4 takes in an

opts

opts

param, and we're not passing the one we have available. When I made that change the error was resolved.

          input =
            %Ash.ActionInput{domain: domain, resource: resource}
            |> Ash.ActionInput.set_context(get_context(context))
            |> Ash.ActionInput.for_action(action.name, arguments, opts)

          input =
            %Ash.ActionInput{domain: domain, resource: resource}
            |> Ash.ActionInput.set_context(get_context(context))
            |> Ash.ActionInput.for_action(action.name, arguments, opts)

This feels a bit heavy handed, but if this error is reproducible and the fix is sensible then I'd be happy to open a PR for the change upstream. Thanks for any input!

Solution

https://github.com/ash-project/ash_graphql/pull/396 fix should be in the next release

GitHub

fix: pass opts to for_action for generic actions by barnabasJ · Pu...

Jump to solution

Generic actions breaking in AshGraphql when require_user? is true for the domain

Generic actions breaking in AshGraphql when require_user? is true for the domain

Similar Threads

Similar Threads

Similar Threads