TanStack•4w ago•

5 replies

rubber-blue

QueryCollection optimistic updates are immediately reverted

Hi gang! I'm having some trouble getting optimistic updates working.

https://codesandbox.io/p/devbox/tanstack-db-bug-2-forked-8rltvq?workspaceId=ws_DBfSKcjaDqJaXRdZHw8eJ4

Clicking one of the todos should toggle it. But instead it looks like the todo is being toggled for one react render cycle and then reverted back straight after. If I set

{refetch : true}

{refetch : true}

then the toggle works.

I've vibed up a github issue but I just want to check I'm not doing anything silly first.

-

collection.update()

collection.update()

is called successfully
- The draft is mutated correctly (verified via console.log)
- The

onUpdate

onUpdate

handler persists the change and returns

{ refetch: false }

{ refetch: false }

- The transaction returns with

state: 'persisting'

state: 'persisting'

and eventually resolves
-

collection.subscribeChanges()

collection.subscribeChanges()

fires TWICE:
1. First with type

"insert"

"insert"

and the correct new value (optimistic update)
2. Immediately after (~1ms) with type
"update"
"update"
and the OLD value, reverting the change
-

useLiveQuery

useLiveQuery

correctly reflects the toggle but is immediately reverted by the second change
- The UI does not update until a full page refresh