10 replies

Bulk create does not properly rollback transaction when error occurs in related resource validation

Ash✅Solved

Im running an Ash.bulk_create inside of a transaction (with

transaction: all

transaction: all

Ash.bulk_create!(
  [
    %{
      id: "6f79f260-3a68-428b-99a1-caa697b22529",
      info: %{
        ...
        zipcode: "invalid",
        ...
      }
    }
  ],
  Cvs.Client.Dossier,
  :create,
  transaction: :all,
  return_errors?: true,
  return_records?: true,
  rollback_on_error?: true,
  authorize?: false,
  tenant: tenant.id
)

Ash.bulk_create!(
  [
    %{
      id: "6f79f260-3a68-428b-99a1-caa697b22529",
      info: %{
        ...
        zipcode: "invalid",
        ...
      }
    }
  ],
  Cvs.Client.Dossier,
  :create,
  transaction: :all,
  return_errors?: true,
  return_records?: true,
  rollback_on_error?: true,
  authorize?: false,
  tenant: tenant.id
)

Because the zipcode is invalid the action fails:

Error: ** (Ash.Error.Invalid) 
Bread Crumbs:
  > Error returned from: Cvs.Client.Info.create
  > Exception raised in bulk create: Cvs.Client.Dossier.create

Invalid Error
* Invalid value provided for zipcode: moet een geldige postcode zijn.
Value: "invalid"

Error: ** (Ash.Error.Invalid) 
Bread Crumbs:
  > Error returned from: Cvs.Client.Info.create
  > Exception raised in bulk create: Cvs.Client.Dossier.create

Invalid Error
* Invalid value provided for zipcode: moet een geldige postcode zijn.
Value: "invalid"

But the creation of the dossier is not rolled back..

If I run the non-bulk action it properly rolls back the entire transaction and the Dossier is not created:

Ash.create!(
  Cvs.Client.Dossier,
  %{
    id: "6f79f260-3a68-428b-99a1-caa697b22529",
    info: %Cvs.Import.ClientInfoParams{
      ...
      zipcode: "invalid",
      ...
    }
  },
  authorize?: false,
  tenant: tenant.id
)

Ash.create!(
  Cvs.Client.Dossier,
  %{
    id: "6f79f260-3a68-428b-99a1-caa697b22529",
    info: %Cvs.Import.ClientInfoParams{
      ...
      zipcode: "invalid",
      ...
    }
  },
  authorize?: false,
  tenant: tenant.id
)

Query logs are showing that the insert into dossiers is indeed committed:

[debug] QUERY OK db=0.4ms idle=1.6e3ms
begin []
↳ Ash.Actions.Create.Bulk.run/5, at: lib/ash/actions/create/bulk.ex:41
[debug] QUERY OK source="dossiers" db=0.7ms
INSERT INTO "dossiers" ("id","client_id","tenant_id","archived") VALUES ($1,$2,$3,$4) RETURNING "tenant_id","archived","client_id","id" ["6f79f260-3a68-428b-99a1-caa697b22529", "b32e1158-6a10-4780-b9b4-b0d1f076d9c4", "826109f6-b3cc-42de-a68f-7d8aa7a741ff", false]
↳ anonymous fn/3 in Ecto.Adapters.SQL.checkout_or_transaction/4, at: lib/ecto/adapters/sql.ex:1458
[debug] QUERY OK db=2.0ms
commit []
↳ Ash.Actions.Create.Bulk.run/5, at: lib/ash/actions/create/bulk.ex:41

[debug] QUERY OK db=0.4ms idle=1.6e3ms
begin []
↳ Ash.Actions.Create.Bulk.run/5, at: lib/ash/actions/create/bulk.ex:41
[debug] QUERY OK source="dossiers" db=0.7ms
INSERT INTO "dossiers" ("id","client_id","tenant_id","archived") VALUES ($1,$2,$3,$4) RETURNING "tenant_id","archived","client_id","id" ["6f79f260-3a68-428b-99a1-caa697b22529", "b32e1158-6a10-4780-b9b4-b0d1f076d9c4", "826109f6-b3cc-42de-a68f-7d8aa7a741ff", false]
↳ anonymous fn/3 in Ecto.Adapters.SQL.checkout_or_transaction/4, at: lib/ecto/adapters/sql.ex:1458
[debug] QUERY OK db=2.0ms
commit []
↳ Ash.Actions.Create.Bulk.run/5, at: lib/ash/actions/create/bulk.ex:41

Solution

I spent some time on it yesterday and today. And I found a problem, but it was only with

transaction: :batch

transaction: :batch

, could you show a bit more about your action definiton, that might help reproduce it.

I'm currently working on polishing the PRs for the fix I found while investigating https://github.com/ash-project/ash_postgres/pull/702

GitHub

test: regression tests for bulk manage_relationship rollback bug by...

Summary

Adds regression tests for a bug where run_after_action_hooks in bulk actions does not call Ash.DataLayer.rollback when manage_relationships fails
Tests cover bulk_create (including upserts...

Jump to solution

Ash Framework•2w ago•

10 replies

Rutgerdj

Bulk create does not properly rollback transaction when error occurs in related resource validation

Ash✅Solved

Im running an Ash.bulk_create inside of a transaction (with

transaction: all

transaction: all

Ash.bulk_create!(
  [
    %{
      id: "6f79f260-3a68-428b-99a1-caa697b22529",
      info: %{
        ...
        zipcode: "invalid",
        ...
      }
    }
  ],
  Cvs.Client.Dossier,
  :create,
  transaction: :all,
  return_errors?: true,
  return_records?: true,
  rollback_on_error?: true,
  authorize?: false,
  tenant: tenant.id
)

Ash.bulk_create!(
  [
    %{
      id: "6f79f260-3a68-428b-99a1-caa697b22529",
      info: %{
        ...
        zipcode: "invalid",
        ...
      }
    }
  ],
  Cvs.Client.Dossier,
  :create,
  transaction: :all,
  return_errors?: true,
  return_records?: true,
  rollback_on_error?: true,
  authorize?: false,
  tenant: tenant.id
)

Because the zipcode is invalid the action fails:

Error: ** (Ash.Error.Invalid) 
Bread Crumbs:
  > Error returned from: Cvs.Client.Info.create
  > Exception raised in bulk create: Cvs.Client.Dossier.create

Invalid Error
* Invalid value provided for zipcode: moet een geldige postcode zijn.
Value: "invalid"

Error: ** (Ash.Error.Invalid) 
Bread Crumbs:
  > Error returned from: Cvs.Client.Info.create
  > Exception raised in bulk create: Cvs.Client.Dossier.create

Invalid Error
* Invalid value provided for zipcode: moet een geldige postcode zijn.
Value: "invalid"

But the creation of the dossier is not rolled back..

If I run the non-bulk action it properly rolls back the entire transaction and the Dossier is not created:

Ash.create!(
  Cvs.Client.Dossier,
  %{
    id: "6f79f260-3a68-428b-99a1-caa697b22529",
    info: %Cvs.Import.ClientInfoParams{
      ...
      zipcode: "invalid",
      ...
    }
  },
  authorize?: false,
  tenant: tenant.id
)

Ash.create!(
  Cvs.Client.Dossier,
  %{
    id: "6f79f260-3a68-428b-99a1-caa697b22529",
    info: %Cvs.Import.ClientInfoParams{
      ...
      zipcode: "invalid",
      ...
    }
  },
  authorize?: false,
  tenant: tenant.id
)

Query logs are showing that the insert into dossiers is indeed committed:

[debug] QUERY OK db=0.4ms idle=1.6e3ms
begin []
↳ Ash.Actions.Create.Bulk.run/5, at: lib/ash/actions/create/bulk.ex:41
[debug] QUERY OK source="dossiers" db=0.7ms
INSERT INTO "dossiers" ("id","client_id","tenant_id","archived") VALUES ($1,$2,$3,$4) RETURNING "tenant_id","archived","client_id","id" ["6f79f260-3a68-428b-99a1-caa697b22529", "b32e1158-6a10-4780-b9b4-b0d1f076d9c4", "826109f6-b3cc-42de-a68f-7d8aa7a741ff", false]
↳ anonymous fn/3 in Ecto.Adapters.SQL.checkout_or_transaction/4, at: lib/ecto/adapters/sql.ex:1458
[debug] QUERY OK db=2.0ms
commit []
↳ Ash.Actions.Create.Bulk.run/5, at: lib/ash/actions/create/bulk.ex:41

[debug] QUERY OK db=0.4ms idle=1.6e3ms
begin []
↳ Ash.Actions.Create.Bulk.run/5, at: lib/ash/actions/create/bulk.ex:41
[debug] QUERY OK source="dossiers" db=0.7ms
INSERT INTO "dossiers" ("id","client_id","tenant_id","archived") VALUES ($1,$2,$3,$4) RETURNING "tenant_id","archived","client_id","id" ["6f79f260-3a68-428b-99a1-caa697b22529", "b32e1158-6a10-4780-b9b4-b0d1f076d9c4", "826109f6-b3cc-42de-a68f-7d8aa7a741ff", false]
↳ anonymous fn/3 in Ecto.Adapters.SQL.checkout_or_transaction/4, at: lib/ecto/adapters/sql.ex:1458
[debug] QUERY OK db=2.0ms
commit []
↳ Ash.Actions.Create.Bulk.run/5, at: lib/ash/actions/create/bulk.ex:41

Solution

I spent some time on it yesterday and today. And I found a problem, but it was only with

transaction: :batch

transaction: :batch

GitHub

test: regression tests for bulk manage_relationship rollback bug by...

Jump to solution

Bulk create does not properly rollback transaction when error occurs in related resource validation

Bulk create does not properly rollback transaction when error occurs in related resource validation

Similar Threads

Similar Threads

Similar Threads