11 Replies
is it ready for merge yet?
ready-ish
let me know once it is ready
Well it is ready for review
alright 👍
Should the uninstall script use
set -e? because something might fail if for example the installation wasn't fully completedis this wworking?
yes
though experimental
Can you use
set -e but handle all cases where "failure" is acceptable (if that makes sense)?That is a lot of checking
If you think it is not suitable, then don't use
set -e. It should be very clear to the user of the script if the script didn't quite finish perfectly, is the main goal at least.