18 replies

Testing express-validator?

Just wondering how to test my route validation? I remember being told before that you shouldn't test an external library, but surely I should test my implementation of it?

For example:

// routes.js
router.post(
  '/someroute', 
  [
    body('email')
    .isString()
  ],
  controller.doSomthing);

// routes.js
router.post(
  '/someroute', 
  [
    body('email')
    .isString()
  ],
  controller.doSomthing);

// controller.js
exports.doSomething = (req, res, next) => {
  const errors = validationResult(req);

  if(!errors.isEmpty()) {
      console.log(errors);
      const error = new Error('Validation Error');
      error.statusCode = 422;
      throw error;
  }
};

// controller.js
exports.doSomething = (req, res, next) => {
  const errors = validationResult(req);

  if(!errors.isEmpty()) {
      console.log(errors);
      const error = new Error('Validation Error');
      error.statusCode = 422;
      throw error;
  }
};

I should obviously mock/unit test the

doSomthing

doSomthing

function, but should I be using

chai-http

chai-http

to test if I'm using

express-validator

express-validator

correctly in

routes.js

routes.js

?

As a slight aside - I should run integration tests less frequently right? Anything that needs to actually query a db or make an http request seems like it's too time intensive to be running as part of my start script

Sorry if these questions seem obvious, it's been a while since I looked at testing, and even then I was new to it!

Testing express-validator?

Just wondering how to test my route validation? I remember being told before that you shouldn't test an external library, but surely I should test my implementation of it?

For example:

// routes.js
router.post(
  '/someroute', 
  [
    body('email')
    .isString()
  ],
  controller.doSomthing);

// routes.js
router.post(
  '/someroute', 
  [
    body('email')
    .isString()
  ],
  controller.doSomthing);

// controller.js
exports.doSomething = (req, res, next) => {
  const errors = validationResult(req);

  if(!errors.isEmpty()) {
      console.log(errors);
      const error = new Error('Validation Error');
      error.statusCode = 422;
      throw error;
  }
};

// controller.js
exports.doSomething = (req, res, next) => {
  const errors = validationResult(req);

  if(!errors.isEmpty()) {
      console.log(errors);
      const error = new Error('Validation Error');
      error.statusCode = 422;
      throw error;
  }
};

I should obviously mock/unit test the

doSomthing

doSomthing

function, but should I be using

chai-http

chai-http

to test if I'm using

express-validator

express-validator

correctly in

routes.js

routes.js

Testing express-validator?

Similar Threads

Testing express-validator?

Similar Threads

Similar Threads

Similar Threads