you just need to implement CORS correctly. you aren't even handling the CORS preflight request so of

you just need to implement CORS correctly. you aren't even handling the CORS preflight request so of course it won't work

sathoroOP•5/24/23, 3:11 PM

personally I call this function on all responses before returning them to the client:

const enableCORS = (request, response) => {
  const origin = request.headers.get("origin") || "";

  const isAllowedOrigin =
    origin === "http://localhost:3000" ||
    origin.endsWith(".example.com");

  if (isAllowedOrigin) {
    for (const [key, value] of Object.entries({
      "Access-Control-Allow-Origin": origin,
      "Access-Control-Allow-Methods": "POST, DELETE, GET, OPTIONS",
      "Access-Control-Allow-Headers": "*",
    })) {
      response.headers.append(key, value);
    }
  }

  return response;
};

const enableCORS = (request, response) => {
  const origin = request.headers.get("origin") || "";

  const isAllowedOrigin =
    origin === "http://localhost:3000" ||
    origin.endsWith(".example.com");

  if (isAllowedOrigin) {
    for (const [key, value] of Object.entries({
      "Access-Control-Allow-Origin": origin,
      "Access-Control-Allow-Methods": "POST, DELETE, GET, OPTIONS",
      "Access-Control-Allow-Headers": "*",
    })) {
      response.headers.append(key, value);
    }
  }

  return response;
};

and in my route handling I have a simple

if (request.method === "OPTIONS") {
  return new Response("ok");
}

if (request.method === "OPTIONS") {
  return new Response("ok");
}

and this is what ties it together...

const response = await handleRequest(request, env, context, sentry);

return enableCORS(request, response);

const response = await handleRequest(request, env, context, sentry);

return enableCORS(request, response);

Ssathoro you just need to implement CORS correctly. you aren't even handling the CORS pre...

banbanboi•5/24/23, 3:14 PM

thank you can I try this ?

Bbanbanboi thank you can I try this ?

sathoroOP•5/24/23, 3:15 PM

yeah go for it

Ssathoro Workers is only for "simple requests"? 🙂

Cyb3r-Jak3•5/24/23, 3:38 PM

I mean no heavy compute or long requests

CCyb3r-Jak3 I mean no heavy compute or long requests

sathoroOP•5/24/23, 3:39 PM

we do several minute long requests it works fine actually

sathoroOP•5/24/23, 3:39 PM

the client just needs to stay connected lol

sathoroOP•5/24/23, 3:40 PM

using SSE

kian•5/24/23, 3:42 PM

What's your Worker code?

NNeo Is Cloudflare Workers good for making an API server?

dave•5/24/23, 3:48 PM

all of our public facing API services are on Cloudflare Workers, and even most of the private APIs are also on Workers.

KKartik ```app.get("*", async (ctx) => { const cacheurl = new URL(ctx.req.url); // c...

kian•5/24/23, 3:49 PM

headers

headers

is always going to be blank other than

pix-api

pix-api

in that scenario.

kian•5/24/23, 3:50 PM

You're not using the request headers, you define

headers

headers

with

let headers = new Headers();

let headers = new Headers();

which is an empty object and then only contains the

pix-api

pix-api

header which you set.

kian•5/24/23, 3:50 PM

If you want to use the request headers, that'd be

ctx.req.headers

ctx.req.headers

tobi•5/24/23, 4:07 PM

with the upcoming workers snippets, in theory i should be able to make a "free" load balancer for an api; and the only real limit should be the dns resolution fees, is that correct (which only start at 1m/month)?

kian•5/24/23, 4:11 PM

Snippets can only make 1 subrequest so you wouldn't be able to do that.

kian•5/24/23, 4:11 PM

Well, you can do Math.random and select a subdomain based on that

kian•5/24/23, 4:11 PM

but you wouldn't be able to hit one and then decide to fallback if it failed

Neiki•5/24/23, 4:44 PM

can i somehow send me an email or sending with an webhook if that happens again? like let me notify

NNeiki can i somehow send me an email or sending with an webhook if that happens again?...

Neiki•5/24/23, 4:56 PM

i cant find anything to workers or crons in the notifications tab, only about pages

Kkian Well, you can do Math.random and select a subdomain based on that

tobi•5/24/23, 5:04 PM

yeah, fallback would not be a possibility. but i could do either random, or based on some "hash" of the request ip + maybe some user cookie or sth.

tobi•5/24/23, 5:07 PM

@kiannh then, if 1 request can be split to multiple subdomains, one could assign only functioning servers to those subdomains, i.e. if i know one of my servers is down, i change its subdomain to point to a known good server

tobi•5/24/23, 5:08 PM

one thing i had in mind was sending ppl to "local" servers; i.e. near their closest cf-POP. i hope this will be possible with snippets

Ttobi hi 😄 with the upcoming workers snippets, in theory i should be able to make a ...

dave•5/24/23, 5:28 PM

Is your API HTTP already?

tobi•5/24/23, 5:31 PM

yea

Ttobi yea

dave•5/24/23, 5:35 PM

you can already do multiple fetches in parallel and just race to the first one that completes.

tobi•5/24/23, 5:35 PM

hmm... doesn't seem like an elegant solution.

dave•5/24/23, 5:35 PM

sure it is

tobi•5/24/23, 5:36 PM

if i have lets say 5 servers then i get 5x the traffic with this method

tobi•5/24/23, 5:37 PM

yea, basically just "forwarding" the request somewhere, right?

Ttobi if i have lets say 5 servers then i get 5x the traffic with this method

dave•5/24/23, 5:37 PM

Sure, but you can cache the result too if it's problem.

tobi•5/24/23, 5:38 PM

depends on what one wants to accomplish.

dave•5/24/23, 5:38 PM

It's really nice since you can do "advanced" ish load balancing too if want.

e.g. can see the round-trip latency by doing:

curl -s "https://untrusted.files.ai.moda/api/v1.0.0-alpha/ping" | jq

curl -s "https://untrusted.files.ai.moda/api/v1.0.0-alpha/ping" | jq

tobi•5/24/23, 5:39 PM

if i, lets say want to build some kind of "low-latency" storage for small files, that is kinda guaranteed to have sub <50-60 ms latency, i could make that with less (or no) js on the user side, while still being able to serve the data quickly.

Ddave It's really nice since you can do "advanced" ish load balancing too if want. e...

tobi•5/24/23, 5:40 PM

what do you mean with that?

Ttobi if i, lets say want to build some kind of "low-latency" storage for small files,...

dave•5/24/23, 5:40 PM

https://untrusted.files.ai.moda/api/v1.0.0-alpha/url/generate_one_time

https://untrusted.files.ai.moda/api/v1.0.0-alpha/url/generate_one_time

^ we have a similar ish use-case, and made this to return the endpoint with the estimated lowest latency for the user.

tobi•5/24/23, 5:41 PM

ahhh

tobi•5/24/23, 5:41 PM

basically just a request to where the client should then upload to. so same thing accomplished, just not intransparent to the user

dave•5/24/23, 5:41 PM

sure it can be

tobi•5/24/23, 5:42 PM

uh, nearest datacenter hit is london?

const enableCORS = (request, response) => { const origin = request.headers.get("origin") || ""; const isAllowedOrigin = origin === "http://localhost:3000" || origin.endsWith(".example.com"); if (isAllowedOrigin) { for (const [key, value] of Object.entries({ "Access-Control-Allow-Origin": origin, "Access-Control-Allow-Methods": "POST, DELETE, GET, OPTIONS", "Access-Control-Allow-Headers": "*", })) { response.headers.append(key, value); } } return response; };

you just need to implement CORS correctly. you aren't even handling the CORS preflight request so of

Similar Threads

Similar Threads

Similar Threads