C#•3y ago

✅ Tic-Tac-Toe validation outputting wrong values

I have a validation loop that checks whether a box is appropriate or not. Whilst the validator checks and throws an error if the square is already occupied, requesting another input from the user (or AI). When it gets an valid input, it will output the incorrect one instead of the new one. In the case for the AI, it outputs all of the incorrect variations it tried when it receives a valid one, which results in it overriding anything and everything there.

I have included the two pics of the validation method and the human Make move function in hopes this will help. Thanks.

SinFluxx•8/16/23, 12:24 AM

$paste

SSinFluxx $paste

MODiX•8/16/23, 12:24 AM

If your code is too long, you can post to https://paste.mod.gg/ and copy the link into chat for others to see your shared code!

SinFluxx•8/16/23, 12:27 AM

As it's hard to figure out what's going on with incomplete cropped screenshots

SinFluxx•8/16/23, 12:29 AM

In your ValidateMove method though, shouldn't your loop be ?

DahyerinOP•8/16/23, 1:47 AM

This is just the player class, I changed the while loop to what you said, but now it just endlessly loops on the first error.
https://paste.mod.gg/ujixrhqrdacc/0

BlazeBin - ujixrhqrdacc

A tool for sharing your source code with the world!

TheBoxyBear•8/16/23, 3:17 AM

What does the boardSpot array represent?

TheBoxyBear•8/16/23, 3:19 AM

If it's mapping a number to a space on the board, how about finding the range of valid numbers mathematically and get XY to check if it's occupied?

TheBoxyBear•8/16/23, 3:23 AM

I thought you were doing recursion to handle errors but there actually seems to be circular calls between valdiateMove and makeMove

TheBoxyBear•8/16/23, 3:28 AM

Right so makeMove prompts the player and valdiateMove makes the validation so it's effectively recursion but across two methods.

When you're doing recursion, you need actually need a loop to repeat the instructions, you just need an exit condition. In your case since its based on user user action, I would stick to a loop over recursion to avoid ballooning. A user could break the app by spamming invalid input.

DahyerinOP•8/16/23, 5:42 AM

Thanks. I ended up figuring it out.

DahyerinOP•8/16/23, 5:42 AM

\close

SinFluxx•8/16/23, 5:53 AM

$close

SSinFluxx $close

MODiX•8/16/23, 5:53 AM

Use the </close:1007753098107813888> command to mark a forum thread as answered