C#•10mo ago

For-Loop doesnt work.

I cant fully understand, why its not working? The variable is an integer. Why is it giving me an error?

43 Replies

ero•10mo ago

threadCounter is only assigned to when readLine2 was > 0 and < 100

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

Yes. I made a goto, if its below 0 and made threadCounter = readLine2 if its above 100

ero•10mo ago

i'm not seeing any of that in what you provided

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

second

ero•10mo ago

$code

MODiX•10mo ago

To post C# code type the following: ```cs // code here ``` Get an example by typing $codegif in chat If your code is too long, post it to: https://paste.mod.gg/

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

how can i share it with you? ill do it different

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

better? so why is it giving me an error :/

ero•10mo ago

it's not better, no. the bot very clearly showed how you properly post code. anyway, you're not covering all possibilities there are times when threadCounter is still never assigned

TheRanger•10mo ago

$codegif

MODiX•10mo ago

https://cdn.discordapp.com/attachments/364492811489509376/892176158312001586/code.gif

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

but where? ohh, if its 0?

ero•10mo ago

when readLine2 is == 0 or == 100

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

ohhhh i see. i covered them. but still giving me the error i did by <=0 and >=100

TheRanger•10mo ago

then theres another possibility u didnt cover yet

ero•10mo ago

mhm

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

    int threadCounter;

    reloop:

    Console.WriteLine("Number Of Threads:\n");

    int readLine2 = int.Parse(Console.ReadLine());

    if (readLine2 > 0 && readLine2 < 100)
    {
        hesSure:
        threadCounter = readLine2;
    }
    else if (readLine2 >= 100)
    {
    reask:

        Console.WriteLine("Still want to continue? [Y]/[N]");

        var ignoreWarning = Console.ReadKey();

        if (ignoreWarning.Key == ConsoleKey.N)
        {
            Console.Clear();
            goto reloop;
        }
        else if (ignoreWarning.Key != ConsoleKey.Y && ignoreWarning.Key != ConsoleKey.N)
        {
            Console.Clear();
            goto reask;
        }
        else if (ignoreWarning.Key == ConsoleKey.Y)
        {
            threadCounter = readLine2;
        }
    }
    else if (readLine2 <= 0)
    {
        Console.WriteLine("\nPlease enter a valid number.");
        Thread.Sleep(3000);
        Console.Clear();
        goto reloop;
    }

    for (int i = threadCounter; threadCounter > 0; i--)
    {

    int threadCounter;

    reloop:

    Console.WriteLine("Number Of Threads:\n");

    int readLine2 = int.Parse(Console.ReadLine());

    if (readLine2 > 0 && readLine2 < 100)
    {
        hesSure:
        threadCounter = readLine2;
    }
    else if (readLine2 >= 100)
    {
    reask:

        Console.WriteLine("Still want to continue? [Y]/[N]");

        var ignoreWarning = Console.ReadKey();

        if (ignoreWarning.Key == ConsoleKey.N)
        {
            Console.Clear();
            goto reloop;
        }
        else if (ignoreWarning.Key != ConsoleKey.Y && ignoreWarning.Key != ConsoleKey.N)
        {
            Console.Clear();
            goto reask;
        }
        else if (ignoreWarning.Key == ConsoleKey.Y)
        {
            threadCounter = readLine2;
        }
    }
    else if (readLine2 <= 0)
    {
        Console.WriteLine("\nPlease enter a valid number.");
        Thread.Sleep(3000);
        Console.Clear();
        goto reloop;
    }

    for (int i = threadCounter; threadCounter > 0; i--)
    {

ero•10mo ago

though the branching might honestly just be too confusing for the compiler it might work if you change the warning logic to if-else-if-else if (N) else if (Y) else

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

I dont quite understand

ero•10mo ago

if (ignoreWarning.Key == ConsoleKey.N)
{
    Console.Clear();
    goto reloop;
}
else if (ignoreWarning.Key == ConsoleKey.Y)
{
    threadCounter = readLine2;
}
else
{
    Console.Clear();
    goto reask;
}

if (ignoreWarning.Key == ConsoleKey.N)
{
    Console.Clear();
    goto reloop;
}
else if (ignoreWarning.Key == ConsoleKey.Y)
{
    threadCounter = readLine2;
}
else
{
    Console.Clear();
    goto reask;
}

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

nope didnt fix it the error is: Use of the unassigned local variable "threadCounter".

TheRanger•10mo ago

oh i think i see the issue now

ero•10mo ago

it's just the branching roslyn needs an else branch to know everything is covered if you have

if (readLine2 > 0 && readLine2 < 100) { }
else if (readLine2 >= 100) { }
else if (readLine2 <= 0) { }

if (readLine2 > 0 && readLine2 < 100) { }
else if (readLine2 >= 100) { }
else if (readLine2 <= 0) { }

then yes, everything is covered but the compiler doesn't understand that

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

yes i have exactly that

ero•10mo ago

so you need

if (readLine2 >= 100) { }
else if (readLine2 <= 0) { }
else { }

if (readLine2 >= 100) { }
else if (readLine2 <= 0) { }
else { }

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

got them all covered

ero•10mo ago

please re-read what i said

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

ohh

Pascal•10mo ago

the issue with your code is that threadCounter, is sometimes unassigned. So the compiler does not know what to do when the value is unassigned and yet you are trying to access a value from it. you can fix this by assigning a default value to threadCounter. Something like int threadCounter = 0 or whatever your default value is.

ero•10mo ago

that would be another way to fix it, yes

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

seems to work

ero•10mo ago

but i think it's good to understand branching it will become crucial for more complex logic for null handling especially

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

i see but even tho in any way i covered all possibilities, i can confuse the compiler with that? because at the end it wouldve gotten an value anyways, right? wait

int threadCounter;

    reloop:

    Console.WriteLine("Number Of Threads:\n");

    int readLine2 = int.Parse(Console.ReadLine());

if (readLine2 >= 100) 
{
reask:

    Console.WriteLine("Still want to continue? [Y]/[N]");

    var ignoreWarning = Console.ReadKey();

    if (ignoreWarning.Key == ConsoleKey.N)
    {
        Console.Clear();
        goto reloop;
    }
    else if (ignoreWarning.Key == ConsoleKey.Y)
    {
        threadCounter = readLine2;
    }
    else
    {
        Console.Clear();
        goto reask;
    }

}
else if (readLine2 <= 0) 
{
    Console.WriteLine("\nPlease enter a valid number.");
    Thread.Sleep(3000);
    Console.Clear();
    goto reloop;
}
else 
{
    hesSure:
    threadCounter = readLine2;
}


for (int i = threadCounter; threadCounter > 0; i--)
    {

int threadCounter;

    reloop:

    Console.WriteLine("Number Of Threads:\n");

    int readLine2 = int.Parse(Console.ReadLine());

if (readLine2 >= 100) 
{
reask:

    Console.WriteLine("Still want to continue? [Y]/[N]");

    var ignoreWarning = Console.ReadKey();

    if (ignoreWarning.Key == ConsoleKey.N)
    {
        Console.Clear();
        goto reloop;
    }
    else if (ignoreWarning.Key == ConsoleKey.Y)
    {
        threadCounter = readLine2;
    }
    else
    {
        Console.Clear();
        goto reask;
    }

}
else if (readLine2 <= 0) 
{
    Console.WriteLine("\nPlease enter a valid number.");
    Thread.Sleep(3000);
    Console.Clear();
    goto reloop;
}
else 
{
    hesSure:
    threadCounter = readLine2;
}


for (int i = threadCounter; threadCounter > 0; i--)
    {

ero•10mo ago

well again, it needs that final else block

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

i have it like this now, and it works..

ero•10mo ago

yup

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

ye. okay. so it gets confused there. i see

ero•10mo ago

the final else block basically says "there cannot be any other possibility here" which means everything must be covered

₮ⱤØ₣Ⱡł₦Ɇ_฿Ⱡ₳₵₭•10mo ago

okay good. Thanks mates! :3

Gaming

Programming

For-Loop doesnt work.