C#•3y ago

❔ picking the right patterns

class Human{
  public int age { /*custom get n set*/ }
}

Human h = new Human();
h.age++;

class Human{
  public int age { /*custom get n set*/ }
}

Human h = new Human();
h.age++;

class Human{
  public int age { /*custom get n set*/ }
}

Human h = new Human();
h.age++;

class Human{
  public int age { /*custom get n set*/ }
}

Human h = new Human();
h.age++;

class Human{
  public int age { get; protected set; }
  public grow() { age++; }
}

Human h = new Human();
h.grow();

class Human{
  public int age { get; protected set; }
  public grow() { age++; }
}

Human h = new Human();
h.grow();

class Human{
  public int age { get; protected set; }
  public grow() { age++; }
}

Human h = new Human();
h.grow();

class Human{
  public int age { get; protected set; }
  public grow() { age++; }
}

Human h = new Human();
h.grow();

DecoherenceOP•10/7/23, 3:34 AM

basically, method vs setter

Jimmacle•10/7/23, 3:52 AM

but that's not the main difference between these

Mayor McCheese•10/7/23, 3:52 AM

Those are two different concepts; the first one you're capable of setting however you want, even negative numbers. The second is more closely controlled and tied to a behavior; grow always increments by one.

They're not even mutually exclusive

DecoherenceOP•10/7/23, 4:00 AM

so if my grow() method is ONLY concerned with incrementing the age, better to just use the setter?

DecoherenceOP•10/7/23, 4:00 AM

and if i had more things like aging, gaining height, etc, i use a method instead?

Mayor McCheese•10/7/23, 4:05 AM

It depends, that's not really what I said; in pointed out they do two different things

DecoherenceOP•10/7/23, 4:15 AM

Why isn't age++ considered tied to a behavior

DecoherenceOP•10/7/23, 4:16 AM

It seems semantically meaningful enough compared to grow()

JakenVeina•10/7/23, 4:20 AM

he means that making it a publicly settable property isn't "tied to a behavior"

JakenVeina•10/7/23, 4:20 AM

cause making it a settable property allows one to do a LOT more with it than just ++++

Jimmacle•10/7/23, 5:08 AM

by making the age setter protected and putting the operation inside the grow()grow() method, that allows the class to control exactly what can happen to the

age

age

property

Jimmacle•10/7/23, 5:09 AM

the difference is between saying "you can increment age" and "you can set age to anything you want" to code outside of the class

deprecatio•10/7/23, 7:30 AM

you are comparing a data class (which could be anything: an entity, an event, a message) with a business logic class

JakenVeina•10/7/23, 7:31 AM

indeed

DΣX•10/7/23, 10:42 AM

second one follows "tell, don't ask". it hides implementation details (like having the value in a property) behind a method interface and thus limits the complexity of the interface which in the end increases maintainability as you can change the internal implementation without breaking the interface.
Good Thing! Second one is the winner of clean-code enthusiasts

DecoherenceOP•10/7/23, 3:58 PM

okay thank you

DDΣX second one follows "tell, don't ask". it hides implementation details (like havi...

Mayor McCheese•10/7/23, 10:19 PM

It's not really a clean code issue

Mayor McCheese•10/7/23, 10:24 PM

class HumanCommand {}
class GrowCommand { protected GrowCommand(int growth, TimeSpan duration); } }
class SingleYearGrowCommand : GrowCommand {  SingleYearGrowCommand : base(1, TimeSpan.FromYears(1)); } }

class HumanCommand {}
class GrowCommand { protected GrowCommand(int growth, TimeSpan duration); } }
class SingleYearGrowCommand : GrowCommand {  SingleYearGrowCommand : base(1, TimeSpan.FromYears(1)); } }

Accord•10/8/23, 10:32 PM

Was this issue resolved? If so, run

/close

/close

otherwise I will mark this as stale and this post will be archived until there is new activity.

❔ picking the right patterns

Similar Threads

Similar Threads

Similar Threads