9 replies

Gave this a go here, https://github.com/

Gave this a go here, https://github.com/mrbbot/miniflare-browser-worker-test, currently seeing

ProtocolError: Protocol error (Browser.getVersion): Target closed.

ProtocolError: Protocol error (Browser.getVersion): Target closed.

ProtocolError: Protocol error (Browser.getVersion): Target closed.

ProtocolError: Protocol error (Browser.getVersion): Target closed.

I don't have any more time to keep hacking on this today, but I'll leave it here if you wanted to take a look. Let me know if you get anywhere with it!

TravisFrank•11/28/23, 12:43 PM

Interesting, I'm getting a different error: Server failed WebSocket handshake: added Sec-WebSocket-Extensions when client did not offer any.Server failed WebSocket handshake: added Sec-WebSocket-Extensions when client did not offer any. As far as I can tell the client is responding with sec-websocket-extensions: permessage-deflate; client_max_window_bits=15sec-websocket-extensions: permessage-deflate; client_max_window_bits=15, but I don't see the server sending any sec-websocket-extensionssec-websocket-extensions header, so I'm not sure what's going on

TravisFrank•11/28/23, 12:44 PM

Doh! The worker is the client in this scenario

MrBBotOP•11/28/23, 1:02 PM

Hmmm, you may need to add perMessageDeflate: falseperMessageDeflate: false here? https://github.com/cloudflare/workers-sdk/blob/1b34878287e3c98e8743e0a9c30b860107d4fcbe/packages/miniflare/src/http/fetch.ts#L71

GitHub

workers-sdk/packages/miniflare/src/http/fetch.ts at 1b34878287e3c98...

Home to Wrangler, the CLI for Cloudflare Workers® - cloudflare/workers-sdk

workers-sdk/packages/miniflare/src/http/fetch.ts at 1b34878287e3c98...

TravisFrank•11/28/23, 1:13 PM

Ah, probably - can you enlighten me on how this patches/miniflare+3.20231030.0.patchpatches/miniflare+3.20231030.0.patch works? I see the change in that file, but is it being applied somehow?

MrBBotOP•11/28/23, 1:14 PM

Ah looks like I missed out the postinstallpostinstall in the

package.json

package.json

, should be a case of running npx patch-packagenpx patch-package

TravisFrank•11/28/23, 1:15 PM

Woah that is magic

TravisFrank•11/28/23, 1:16 PM

Okay now I have the same error you were getting: Protocol error (Browser.getVersion): Target closed.Protocol error (Browser.getVersion): Target closed.. I'll keep poking

TravisFrank•11/28/23, 2:31 PM

I'm noticing that WorkersWebSocketTransport.createWorkersWebSocketTransport.create is returning a transporttransport with a WebSocketWebSocket that has an empty string for protocolprotocol, which I think shouldn't be happening. Could be a red herring, but I'm not finding much else amiss.

TravisFrank•11/28/23, 2:36 PM

Also perhaps worth noting that this (https://github.com/mrbbot/miniflare-browser-worker-test/blob/main/src/index.ts#L27) isn't doing anything, since puppeteer.launchpuppeteer.launch calls this.connectthis.connect instead of endpoint.connectendpoint.connect

GitHub

miniflare-browser-worker-test/src/index.ts at main · mrbbot/minifla...

Testing browser workers with Miniflare. Contribute to mrbbot/miniflare-browser-worker-test development by creating an account on GitHub.

MrBBotOP•11/28/23, 2:38 PM

That connect()connect() shouldn't be called, that's for TCP proxies (i.e. cloudflare:socketscloudflare:sockets stuff)

Gave this a go here, https://github.com/

Similar Threads

Similar Threads

Similar Threads