Kysely•2y ago

Type errors after 0.27.1 upgrade

After upgrading to the lastest verision, I've got a couple of type errors that I'm not sure how to resolve. They are both the same kind of error, I have a custom WHERE IN expression:

eb(
  "objects.type",
  "in",
  sql.raw(
    `(${ALLOWED_OBJECT_TYPES.map((o) => `'${o}'`).join(",")})`,
  ),
),

eb(
  "objects.type",
  "in",
  sql.raw(
    `(${ALLOWED_OBJECT_TYPES.map((o) => `'${o}'`).join(",")})`,
  ),
),

Which gives me this error:

Argument of type 'RawBuilder<unknown>' is not assignable to parameter of type 'OperandValueExpressionOrList<DB & { target_objects: { object_id: string; }; } & { objects: { id: string; oid: number; schema_id: string; name: string; type: string; owner_id: string; privileges: string[] | null; }; } & { transitive_dependencies: { ...; }; } & { ...; } & { ...; } & { ...; } & { ...; }, "objects" | "s...'.
  Property 'isSelectQueryBuilder' is missing in type 'RawBuilder<unknown>' but required in type 'SelectQueryBuilderExpression<Record<string, string | null>>'.

60               sql.raw(
                 ~~~~~~~~
61                 `(${ALLOWED_OBJECT_TYPES.map((o) => `'${o}'`).join(",")})`,
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
62               ),
   ~~~~~~~~~~~~~~~

Argument of type 'RawBuilder<unknown>' is not assignable to parameter of type 'OperandValueExpressionOrList<DB & { target_objects: { object_id: string; }; } & { objects: { id: string; oid: number; schema_id: string; name: string; type: string; owner_id: string; privileges: string[] | null; }; } & { transitive_dependencies: { ...; }; } & { ...; } & { ...; } & { ...; } & { ...; }, "objects" | "s...'.
  Property 'isSelectQueryBuilder' is missing in type 'RawBuilder<unknown>' but required in type 'SelectQueryBuilderExpression<Record<string, string | null>>'.

60               sql.raw(
                 ~~~~~~~~
61                 `(${ALLOWED_OBJECT_TYPES.map((o) => `'${o}'`).join(",")})`,
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
62               ),
   ~~~~~~~~~~~~~~~

I assume I need to pass a type to sql.raw, but I haven't been able to figure out what that type should be.

Solution:

yeah, I just realized that, I don't need sql.raw at all

Jump to solution

9 Replies

thelinuxlich•2y ago

The type should be the same of objects.type[]

RobinOP•2y ago

as in, string[]? that doesn't seem to work, maybe I'm not following I was looking through the code to see if there was something like an InExpression type or something, but I didn't find anything like that.

thelinuxlich•2y ago

Btw do you really need a sql.raw? What's stopping you from just passing allowed_object_types

Solution

Robin•2y ago

yeah, I just realized that, I don't need sql.raw at all

RobinOP•2y ago

That avoids the issue, thanks!

RobinOP•2y ago

oh, I just ran into another case where I can't avoid sql.raw:

.where(
  (eb) => eb("mal.finished_at", "-", eb.ref("mal.began_at")),
  ">=",
  sql`'${sql.raw(`${minDuration}`)} MILLISECONDS'`,
)

.where(
  (eb) => eb("mal.finished_at", "-", eb.ref("mal.began_at")),
  ">=",
  sql`'${sql.raw(`${minDuration}`)} MILLISECONDS'`,
)

thelinuxlich•2y ago

I think it should be sql<Date>${minDuration} MILLISECONDS

RobinOP•2y ago

sure enough, thanks!

Igal (mobile)•2y ago

it was mentioned in the release notes that sql template tag will require typing now.

Gaming

Programming

Type errors after 0.27.1 upgrade

Did you find this page helpful?