C#•5mo ago

✅ EF with MySQL getting double/triple time values ?!

So i assign task to user and set the assignTime to DateTime.Now so i should be able to get remaining time right?

var userTaskAssignment = dbContext.UserTaskAssignments.FirstOrDefault(assignment => assignment.TaskId == taskId && assignment.UserId == UserId);
                if (userTaskAssignment != null)
                {
                    RemainingTime = userTaskAssignment.TimeToCompleteTask - DateTime.Now;
                    RemainingHours = RemainingTime.TotalHours;
                    RemainingMinutes = RemainingTime.TotalMinutes;
                    RemainingSeconds = RemainingTime.TotalSeconds;
                }

var userTaskAssignment = dbContext.UserTaskAssignments.FirstOrDefault(assignment => assignment.TaskId == taskId && assignment.UserId == UserId);
                if (userTaskAssignment != null)
                {
                    RemainingTime = userTaskAssignment.TimeToCompleteTask - DateTime.Now;
                    RemainingHours = RemainingTime.TotalHours;
                    RemainingMinutes = RemainingTime.TotalMinutes;
                    RemainingSeconds = RemainingTime.TotalSeconds;
                }

    private async Task<Task?> AssignTaskToUserIds(List<int> userIds, int taskId, TimeSpan taskLifespan)
    {
        DateTime assignmentTime = DateTime.Now;

        foreach (int userId in userIds)
        {
            UserTaskAssignment userTaskAssignment = new UserTaskAssignment
            {
                UserId = userId,
                TaskId = taskId,
                AssignmentTime = assignmentTime,
            };

            dbContext.UserTaskAssignments.Add(userTaskAssignment);
        }
        
        await dbContext.SaveChangesAsync();
        
        var assignedTasks = dbContext.UserTaskAssignments
            .Where(uta => userIds.Contains(uta.UserId) && uta.TaskId == taskId)
            .ToList();
        
        foreach (var assignment in assignedTasks)
        {
            assignment.TimeToCompleteTask = assignment.AssignmentTime.Add(taskLifespan);
        }
        
        await dbContext.SaveChangesAsync();

        PageHelper.SetTempDataSuccessMessage("Task assigned successfully", TempData);
        return null;
    }

    private async Task<Task?> AssignTaskToUserIds(List<int> userIds, int taskId, TimeSpan taskLifespan)
    {
        DateTime assignmentTime = DateTime.Now;

        foreach (int userId in userIds)
        {
            UserTaskAssignment userTaskAssignment = new UserTaskAssignment
            {
                UserId = userId,
                TaskId = taskId,
                AssignmentTime = assignmentTime,
            };

            dbContext.UserTaskAssignments.Add(userTaskAssignment);
        }
        
        await dbContext.SaveChangesAsync();
        
        var assignedTasks = dbContext.UserTaskAssignments
            .Where(uta => userIds.Contains(uta.UserId) && uta.TaskId == taskId)
            .ToList();
        
        foreach (var assignment in assignedTasks)
        {
            assignment.TimeToCompleteTask = assignment.AssignmentTime.Add(taskLifespan);
        }
        
        await dbContext.SaveChangesAsync();

        PageHelper.SetTempDataSuccessMessage("Task assigned successfully", TempData);
        return null;
    }

For some reason when i set TimeToCompleteTask = 1h and i go to user i get 3h to complete task orr 1h 59min?

27 Replies

Jimmacle•5mo ago

first point - don't use DateTime, use DateTimeOffset

Angius•5mo ago

Task<Task?>

Jimmacle•5mo ago

DateTime does not know anything about time zone offsets and could easily lead to errors calculating durations if you aren't solely using UTC times

Whiteboy•5mo ago

well yea i created "Task" as a entity then realized it was bad naming tho everywhere?

Jimmacle•5mo ago

everywhere possible, yes

Whiteboy•5mo ago

i set task to 1h xd

Whiteboy•5mo ago

Jimmacle•5mo ago

besides that, have you checked what times are actually being used in calculations? like what's getting stored in the db, what are the actual time values when you set a breakpoint after the calculations

Whiteboy•5mo ago

nope

Jimmacle•5mo ago

that wasn't a yes or no question well not the one you replied to do that and see if you can find the problem

Whiteboy•5mo ago

does this look good or cursed tho

        int days = ParseAndValidateInput(Request.Form["Days"]);
        int hours = ParseAndValidateInput(Request.Form["Hours"]);
        int minutes = ParseAndValidateInput(Request.Form["Minutes"]);

        TimeSpan timeToCompleteTask = new TimeSpan(days, hours, minutes, 0);

        int days = ParseAndValidateInput(Request.Form["Days"]);
        int hours = ParseAndValidateInput(Request.Form["Hours"]);
        int minutes = ParseAndValidateInput(Request.Form["Minutes"]);

        TimeSpan timeToCompleteTask = new TimeSpan(days, hours, minutes, 0);

Jimmacle•5mo ago

could be worse, but i think your naming is confusing that looks like a different value than what TimeToCompleteTask in your entity should be why is it a timespan?

Whiteboy•5mo ago

idk that's what i tought it should be

Jimmacle•5mo ago

timespans represent durations

Whiteboy•5mo ago

im 1st time ever dealing with time

Jimmacle•5mo ago

you want datetime/datetimeoffset for a point in time preferably datetimeoffset

Whiteboy•5mo ago

but that's not point in time no? im confused rn it's like i set timeToCompleteTask = 2h so the task is visible fro 2h

Jimmacle•5mo ago

how does that make sense in the context of userTaskAssignment.TimeToCompleteTask - DateTime.Now;? you should be comparing DateTime.Now with another point in time, not a duration i think your naming is just confusing, it should be consistent throughout your code

Whiteboy•5mo ago

        foreach (var assignment in assignedTasks)
        {
            assignment.DeadLineDateTime = assignment.AssignmentTime.Add(timeToCompleteTask);
        }

        foreach (var assignment in assignedTasks)
        {
            assignment.DeadLineDateTime = assignment.AssignmentTime.Add(timeToCompleteTask);
        }

yeah sure i should rename it but then i add to it the timeToCompleteTask so it's point in time when i compare it

Jimmacle•5mo ago

okay, so use your debugger and find out what values you're actually comparing

Whiteboy•5mo ago

Whiteboy•5mo ago

so i set timeToCompleteTask to 1h and on site im getting 1h 59mins

Jimmacle•5mo ago

what time zone are you in?

Whiteboy•5mo ago

i found the issue

Whiteboy•5mo ago

There should be JUST "Hours/Minutes/Seconds" Not total because with total the minutes were setting to 60 at 1h timeToCompleteTask and the hours timer is also 1h so 2h at ttoal xd

Jimmacle•5mo ago

that would also do it

Gaming

Programming

✅ EF with MySQL getting double/triple time values ?!