C
C#•5mo ago
zobweyt

Implementing rate limiting for discord bot interactions with absolute expiration of items

I’m trying to create a simple and customizable RateLimitAttribute for interactions in Discord.Net using their preconditions. I'm too confused about all the possibilities. So, how would you implement this? What decisions would you make and what data structures would you use? Expected usage 
[RateLimit(max: 2, period: TimeSpan.FromMinutes(1), ignore: Ignore.Owner | Ignore.DMs)]
[SlashCommand("ping", "Pings the bot.")]
public async Task PingAsync() => await RespondAsync("Pong!");
[RateLimit(max: 2, period: TimeSpan.FromMinutes(1), ignore: Ignore.Owner | Ignore.DMs)]
[SlashCommand("ping", "Pings the bot.")]
public async Task PingAsync() => await RespondAsync("Pong!");
Expected behavior /ping — Pong! (count is now 1) /ping — Pong! (count is now 2) /ping — Wait 60 seconds for limit to expire! /ping (30 seconds later) — Wait 30 seconds for limit to expire! … (30 seconds later) — Remove rate limit from store in background. /ping (any time later) — Pong! (count is now 1) Wanted features: - Users can define custom ignore policies: for instance, if you have a database with different roles like admins and regular users, you might want to apply rate limiting to all users but exclude admins. - Users can access the store of rate limits: for example, EPIC RPG’s /cd command shows the cooldowns for each command per user. Problems I’ve met - Attributes require constant values: TimeSpan cannot be used directly. Instead, people use parameters specifying periods in seconds. Alternatively, a converter could be used with double period and enum TimeMeasure. - Caching with absolute expiration: IMemoryCache's AbsoluteExpiration simplifies caching implementation because it removes the rate limits right when they expire, but the keys there are strings and not generic types. Using System.Threading.RateLimiting, it’s hard to display the exact remaining time until the limit expires.
4 Replies
zobweyt
zobweyt•5mo ago
zobweyt
zobweyt•5mo ago
So here I tried to implement this using System.Threading.RateLimiting

System.Threading.Rat...

zobweyt
zobweyt•5mo ago
And here is implementation using MemoryCache

MemoryCache.cs

zobweyt
zobweyt•5mo ago
Also, I thought about using polymorphism instead of IgnoreTargets, but I couldn’t get to a good and working implementation
Want results from more Discord servers?
Add your server
More Posts
✅ How to force C# to copy data?I am trying to debug code and I have a list of `rooms` and another list of `backup_rooms`. They bothManually execute default ModelBinding from AspNetCoreFor reasons I am in an ActionFilter and want to transform the `IFormCollection `I have into a model thread-safe concurrent task compilation systemhttps://gist.github.com/mgood7123/878b7c2988372838c51d11ee4fad84c3 how can i correctly set up lockiCan I set some static values into a .xalm file?Is there any way to get the width of something and have it as a static value to be used later?Primary constructor parameter is null after being run in a TaskThe following snippet of code is responsible for starting a background service ```csharp public claHow to slow down my api call to a external service using pollyHow to reduce or slow down my api to call external system. I want to call contentful cms but they haWPF DataGridHey, I want to import data from a csv file to an dataGrid. I use LINQ to split. The splitted data, wPolymorphic query handling in EF Core - Thoughts?So I'm having to deal a lot with entity polymorphism and querying the db to avoid having to execute How to show validation message for a nested object's property in a list in blazorI have 2 models Customer and Contact. A customer can have 1 or more contacts. I'm using EditForm andmaking an overlayI want to make my own overlay, just like xbox gamebar or that geforce experience thing where you can