TanStackT
TanStack•2y ago•
10 replies
nursing-lime

[Possible Bug] getTotalSize is calculated incorrectly.

I have a waterfall style of grid with 4 lanes and each item can be a different height. I have the calculations correct but sometimes at the bottom content gets cut off. I was banging my head against the wall but then I realized there might be a bug and just wanted to confirm.

You can see the list of measurements in the image. You can see index 16 as an end that is bigger than index 17, but getTotalSize() only takes the last item of the array into consideration.

This is taken straight from the source:
  getTotalSize = () =>
    (this.getMeasurements()[this.options.count - 1]?.end ||
      this.options.paddingStart) -
    this.options.scrollMargin +
    this.options.paddingEnd


Shouldn't this fin the biggest end value and use that instead of just presuming the last element? Just trying to confirm that this is a bug in the logic. Thank you!
image.png
Was this page helpful?