19 replies

@kflansburg is there a specific reason

@kflansburg is there a specific reason you removed this re-export in PR 481?

pub use crate::schedule::*;

pub use crate::schedule::*;

pub use crate::schedule::*;

pub use crate::schedule::*;

avsaaseOP•3/27/24, 1:40 PM

It breaks usage of ScheduledEventScheduledEvent

avsaaseOP•3/27/24, 1:45 PM

GitHub

I think this was erroneously removed in #481.

avsaaseOP•3/27/24, 3:26 PM

No worries. It happens.

avsaaseOP•3/27/24, 6:22 PM

Mistakes like this could be caught by tools like cargo-semver-checkscargo-semver-checks. They provide github actions to automate these checks.

avsaaseOP•3/27/24, 6:28 PM

Yes that's true but in this case the tool would have made it clear that some previously accessible types where not accessible anymore.

avsaaseOP•3/27/24, 6:30 PM

I haven't checked yet what the exact CI setup should be to make this work.

avsaaseOP•3/27/24, 6:59 PM

What I would try to do is build and ideally run the examples in CI

avsaaseOP•3/27/24, 7:41 PM

Looks like the pr checks don't run on the release PR