C#•2y ago

List not returning all matching elements

hey, I have this method

public List<T> GetStatementsOfType<T>() where T : ASTStatement
{
    return statements.OfType<T>().ToList();
}

public List<T> GetStatementsOfType<T>() where T : ASTStatement
{
    return statements.OfType<T>().ToList();
}

public List<T> GetStatementsOfType<T>() where T : ASTStatement
{
    return statements.OfType<T>().ToList();
}

public List<T> GetStatementsOfType<T>() where T : ASTStatement
{
    return statements.OfType<T>().ToList();
}

and i call it like this:

foreach(ASTVariableDeclaration dec in astScope.GetStatementsOfType<ASTVariableDeclaration>()) 
{
    _globalVariables.Add(dec.name.value, null);
}

foreach(ASTVariableDeclaration dec in astScope.GetStatementsOfType<ASTVariableDeclaration>()) 
{
    _globalVariables.Add(dec.name.value, null);
}

foreach(ASTVariableDeclaration dec in astScope.GetStatementsOfType<ASTVariableDeclaration>()) 
{
    _globalVariables.Add(dec.name.value, null);
}

foreach(ASTVariableDeclaration dec in astScope.GetStatementsOfType<ASTVariableDeclaration>()) 
{
    _globalVariables.Add(dec.name.value, null);
}

for some reason it only returns one element matching that type but it should return two

TheosOP•4/8/24, 7:55 PM

hmm, it acutally seems to return 2 elements correctly

TheosOP•4/8/24, 7:55 PM

but the foreach loop fails

TheosOP•4/8/24, 7:55 PM

this is only called once

Mayor McCheese•4/8/24, 11:51 PM

What does "fails" mean? Throws an exception?